From patchwork Thu Feb 16 11:20:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 57979 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp242996wrn; Thu, 16 Feb 2023 03:27:39 -0800 (PST) X-Google-Smtp-Source: AK7set/QDSagwImpVbUWuydFWkZGypWvWaV5oW/WOIvImE0MCoqCHc8z245wTcFvQn7Ic8eQUk8e X-Received: by 2002:aa7:d04c:0:b0:4ad:4c4e:2b66 with SMTP id n12-20020aa7d04c000000b004ad4c4e2b66mr1203629edo.11.1676546859836; Thu, 16 Feb 2023 03:27:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676546859; cv=none; d=google.com; s=arc-20160816; b=GvGZDtgkUWTMk1SEpAEIET662vHdRoksXbzDlxfx7d9PxggrIPLwiTdnnKZ3Q3wH0Z 07Z0dKbQIDxcCBgKZ3WovS1Ce+34r+nFP4WGHZYRvtUECPNvPdjKtmGPvp2CU4rRK8/e HRqDjpTVzG7vfrohVVS5wvIMgtYjAs9eB+tkSgM8pAGRJ38mHeQxERfRzstunRKiBxPf f0M0z60HzPLDAB+g42VhB9yPJOBNLtFU13eP61Vwt8JcxlgMpi7sOHSQBnZHPDCmVQjr ISQc08N1MuS6w63RqJJjN/NdJ9x1EIhK0ikOQ5lMfgTPn7MYfqxBVYurGCPlrRGXC2W1 09tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:cc:to:date :resent-to:resent-message-id:resent-date:resent-from:dmarc-filter :delivered-to:dkim-signature:dkim-filter; bh=1uor8bgPaQqiVOaVdtioHWf5QOGdllp6j+vWC13I79U=; b=SVOAIjwzlpn7rLcrdimkhJ2xJ0MWoIpIB5mTDtYviozOgpSPvkQaj0I9TyQVotNvmD HEYIbhfY72J+eV5Kbxc21mwzamxvwiAo1UFHhq2O3tTGHl/qFG3WA88c8+on6kTvJoIe ZwkqB9RovXV/BLA10QhhiDcOFpCJk7MBD36gGFQYcDkk80QhIR6C0IlMuAnRb1nmMSpx zvZEAHjoavpH/oaKhSAjpiRcf01FTtxsC1zDwthHUQ5BP45bIwy1fuIDjhf0ENZ2/Sao AMLY57UrBK+Zgw3T68i8o5LPjbHD6kJUDuwQqH844vDJUWC9w5EbkNYFzA+SP3iotaLk pNgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=rAadeIaX; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id c13-20020a056402120d00b004ab4d3427d8si1822531edw.314.2023.02.16.03.27.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 03:27:39 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=rAadeIaX; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CCF5B3858028 for ; Thu, 16 Feb 2023 11:27:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CCF5B3858028 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1676546854; bh=1uor8bgPaQqiVOaVdtioHWf5QOGdllp6j+vWC13I79U=; h=Resent-From:Resent-Date:Resent-To:Date:To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=rAadeIaXwIsrdYZgWObhYyFc4p6x24L5tYyHUW3ru2gQi/4z7aFpcG111Rt3JeidK dOBP2U9/HZZVBf+t6tS+mgurmTvQJORWy4HgEq4tzZ51TGVH1zaFz22han3TetwvXN 4xWopFqmvIMlkPDw8Kq2ELlRE9DafK/vS4K1o3Oc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 81BA83858C5F for ; Thu, 16 Feb 2023 11:26:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81BA83858C5F Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-99-eah8tyhuNkOX-A-eRSH7cQ-1; Thu, 16 Feb 2023 06:26:48 -0500 X-MC-Unique: eah8tyhuNkOX-A-eRSH7cQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 94A8E85D063; Thu, 16 Feb 2023 11:26:47 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.211]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 50F46492C3C; Thu, 16 Feb 2023 11:26:47 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 31GBQKTC2903477 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 16 Feb 2023 12:26:34 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 31GBQEkw2903476; Thu, 16 Feb 2023 12:26:14 +0100 Resent-From: Jakub Jelinek Resent-Date: Thu, 16 Feb 2023 12:26:14 +0100 Resent-Message-ID: Resent-To: Tobias Burnus , gcc-patches@gcc.gnu.org Date: Thu, 16 Feb 2023 12:20:17 +0100 To: gcc-patches@gcc.gnu.org Cc: Tobias Burnus Subject: [committed] libgomp: Fix comment typo Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jakub Jelinek via Gcc-patches From: Jakub Jelinek Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757986799926802172?= X-GMAIL-MSGID: =?utf-8?q?1757986799926802172?= Hi! I saw FAIL: libgomp.fortran/target-nowait-array-section.f90 -O execution test in my last x86_64-linux bootstrap. From quick skimming, it might be just unreliable test, which assumes that asynchronous execution wouldn't produce ordered sequence, but can't it happen even with asynchronous execution? That said, while skimming the test, I've noticed a comment typo and this patch fixes that up. Tested on x86_64-linux, committed to trunk. 2023-02-16 Jakub Jelinek * testsuite/libgomp.fortran/target-nowait-array-section.f90: Fix comment typo and improve its wording. Jakub --- libgomp/testsuite/libgomp.fortran/target-nowait-array-section.f90.jj 2022-05-16 09:46:02.329060126 +0200 +++ libgomp/testsuite/libgomp.fortran/target-nowait-array-section.f90 2023-02-16 12:04:11.227347228 +0100 @@ -1,4 +1,4 @@ -! Runs the the target region asynchrolously and checks for it +! Run the target region asynchronously and check it ! ! Note that map(alloc: work(:, i)) + nowait should be safe ! given that a nondescriptor array is used. However, it still