diff mbox series

[committed] libgomp: Fix comment typo

Message ID Y+4RZHrFT1+jua/0@tucnak
State Unresolved
Headers
Series [committed] libgomp: Fix comment typo |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

Jakub Jelinek Feb. 16, 2023, 11:20 a.m. UTC 
  Hi!

I saw
FAIL: libgomp.fortran/target-nowait-array-section.f90   -O  execution test
in my last x86_64-linux bootstrap.  From quick skimming, it might be just
unreliable test, which assumes that asynchronous execution wouldn't produce
ordered sequence, but can't it happen even with asynchronous execution?

That said, while skimming the test, I've noticed a comment typo and
this patch fixes that up.

Tested on x86_64-linux, committed to trunk.

2023-02-16  Jakub Jelinek  <jakub@redhat.com>

	* testsuite/libgomp.fortran/target-nowait-array-section.f90: Fix
	comment typo and improve its wording.


	Jakub

Comments

Thomas Schwinge Feb. 16, 2023, 2:50 p.m. UTC | #1 
Hi!

On 2023-02-16T12:20:17+0100, Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
> I saw
> FAIL: libgomp.fortran/target-nowait-array-section.f90   -O  execution test
> in my last x86_64-linux bootstrap.  From quick skimming, it might be just
> unreliable test, which assumes that asynchronous execution wouldn't produce
> ordered sequence, but can't it happen even with asynchronous execution?

Yes, that does match my findings reported a while ago, see:
<https://inbox.sourceware.org/gcc-patches/87iljk4ji8.fsf@euler.schwinge.homeip.net>.


Grüße
 Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
diff mbox series

Patch

--- libgomp/testsuite/libgomp.fortran/target-nowait-array-section.f90.jj	2022-05-16 09:46:02.329060126 +0200
+++ libgomp/testsuite/libgomp.fortran/target-nowait-array-section.f90	2023-02-16 12:04:11.227347228 +0100
@@ -1,4 +1,4 @@ 
-! Runs the the target region asynchrolously and checks for it
+! Run the target region asynchronously and check it
 !
 ! Note that  map(alloc: work(:, i)) + nowait  should be safe
 ! given that a nondescriptor array is used. However, it still