Message ID | PAWPR08MB8982AEB5FE30726A1FDB466283C3A@PAWPR08MB8982.eurprd08.prod.outlook.com |
---|---|
State | Corrupt patch |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1928519vqu; Tue, 26 Sep 2023 06:48:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHD2Th7RIl3/RsFmd3jppLAoEZCivmEEraxcmFcMJfxyEPWA4G7zmD1Qz2xcuwKBD9eiuo9 X-Received: by 2002:a17:906:cb2:b0:9b2:a078:4461 with SMTP id k18-20020a1709060cb200b009b2a0784461mr1391231ejh.44.1695736094363; Tue, 26 Sep 2023 06:48:14 -0700 (PDT) Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id e18-20020a17090681d200b0099399ac6fdesi10873424ejx.79.2023.09.26.06.48.14 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 06:48:14 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=XWgU02s9; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=XWgU02s9; arc=fail (DNS record missing); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DC6043851AB7 for <ouuuleilei@gmail.com>; Tue, 26 Sep 2023 13:48:04 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2063.outbound.protection.outlook.com [40.107.21.63]) by sourceware.org (Postfix) with ESMTPS id 6CFCF3858D35 for <gcc-patches@gcc.gnu.org>; Tue, 26 Sep 2023 13:47:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6CFCF3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V7RS7sJdylBSfjm5hzOOV/gSzSPRdwyeeIMhM87Ww2A=; b=XWgU02s9S4qYJjGqqA6DdUqTwgz4rKwPaVwSVy23jiURMd18z3vHA6lYkc/CJkLSVTfylUyIKhDKaSUQbELGjpSsawuP+dCjXJadhzHAW+QUTKnqGHKa3uBxZPHNbONXqb+Iw70gi8QIHg2eu35105/qzmcjBczqVBboxVQxwQQ= Received: from AM7PR02CA0014.eurprd02.prod.outlook.com (2603:10a6:20b:100::24) by AS8PR08MB10172.eurprd08.prod.outlook.com (2603:10a6:20b:628::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Tue, 26 Sep 2023 13:47:29 +0000 Received: from AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:100:cafe::28) by AM7PR02CA0014.outlook.office365.com (2603:10a6:20b:100::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.35 via Frontend Transport; Tue, 26 Sep 2023 13:47:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT023.mail.protection.outlook.com (100.127.140.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.20 via Frontend Transport; Tue, 26 Sep 2023 13:47:28 +0000 Received: ("Tessian outbound 5c548696a0e7:v175"); Tue, 26 Sep 2023 13:47:28 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c2a8486d13300792 X-CR-MTA-TID: 64aa7808 Received: from 476980279a8f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6E50BB43-0A65-43F3-802D-DE60D611B1AA.1; Tue, 26 Sep 2023 13:46:10 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 476980279a8f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 26 Sep 2023 13:46:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NwX6SdINn0+duBs/4dKf6JyndJRqqwYE8+D1cvkba8gmdq8iNb6mShsjuqFBzIelxWVOiS6bc26TsbRWDK/+yNDQElhq0kwv76KYPt//gaOgexhO4N3+6rte5k/oFAPGYGy2pN0Q8JeyiUOcMCjOC/alQqXJ+kzZ+0bKNk0y6gOzS8mZ39ndfd1LKmXrvaPBqCrey7ZIU9qr/15qyBsDTU7IOIPjD9rhJGyzutI0/qJCuah4wqMY/oSs6abWFgKaprf4jC0kUnyZ5xTYo6kQGpoxXjRzqL4iFIPOCOp9ktRRc/v7M6/bweGuUYJFFCNzgHxfO3Oj9y75KVudXw6n0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V7RS7sJdylBSfjm5hzOOV/gSzSPRdwyeeIMhM87Ww2A=; b=UIoVS0QixNp7mrZCNYmff1vTgJhBYs72k/p0aOGzoj1NbLYTSX+eQHvLsDbii6n2b+nXgFRP7inP4T1fmbBNwLh60sY77hgdDGzq5YoHv/Xq4MbXstHOmQnu/0cjAWFsKwcJ+VF0R5CTN1+RRsgWU3so7/BCZuw7Syaaxjc5Jp7VZtoTxdcpCsM5etO9ADwngEhnFX1XdR/5wYcajrBN9IoxUWdDzHjEU5acgZcSERE3zz5WySyDDk9+MWYr+QpG5tK3wGkpL22mZsUQF6PoYt5Z64RvRVfNAJKvv1jSxps3br3H4oEhRoQjRaiSqMS3QHdY+XV1Ao6drlE3HRk92A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V7RS7sJdylBSfjm5hzOOV/gSzSPRdwyeeIMhM87Ww2A=; b=XWgU02s9S4qYJjGqqA6DdUqTwgz4rKwPaVwSVy23jiURMd18z3vHA6lYkc/CJkLSVTfylUyIKhDKaSUQbELGjpSsawuP+dCjXJadhzHAW+QUTKnqGHKa3uBxZPHNbONXqb+Iw70gi8QIHg2eu35105/qzmcjBczqVBboxVQxwQQ= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by AM9PR08MB6161.eurprd08.prod.outlook.com (2603:10a6:20b:280::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.25; Tue, 26 Sep 2023 13:46:08 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::ff3d:6e95:9971:a7e]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::ff3d:6e95:9971:a7e%5]) with mapi id 15.20.6813.027; Tue, 26 Sep 2023 13:46:08 +0000 From: Wilco Dijkstra <Wilco.Dijkstra@arm.com> To: GCC Patches <gcc-patches@gcc.gnu.org> CC: Richard Sandiford <Richard.Sandiford@arm.com>, Richard Earnshaw <Richard.Earnshaw@arm.com>, Ramana Radhakrishnan <ramana.gcc@googlemail.com> Subject: [PATCH] AArch64: Remove BTI from outline atomics Thread-Topic: [PATCH] AArch64: Remove BTI from outline atomics Thread-Index: AQHZ8Huzae7m6bV7PUqduzFEJDPFKLAtHkL0 Date: Tue, 26 Sep 2023 13:46:07 +0000 Message-ID: <PAWPR08MB8982AEB5FE30726A1FDB466283C3A@PAWPR08MB8982.eurprd08.prod.outlook.com> References: <PAWPR08MB8982EDEA30B35BFB7178002283C3A@PAWPR08MB8982.eurprd08.prod.outlook.com> In-Reply-To: <PAWPR08MB8982EDEA30B35BFB7178002283C3A@PAWPR08MB8982.eurprd08.prod.outlook.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|AM9PR08MB6161:EE_|AM7EUR03FT023:EE_|AS8PR08MB10172:EE_ X-MS-Office365-Filtering-Correlation-Id: 36b1a3ec-e062-4cc0-9675-08dbbe972014 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 47t9F7WGBSPcdTpRG9z1zZ4ME8NtteobL/0JbDJEEhBbT4D6fIfZ10CGY14Epk9+PE2kF7FGe9Rch0rrqHs4PsNptwOfO6nsWh+7WBGAov2LqvWlAsgpqbyT8jCMLcci+caHDJazmgwrygUTV1rLIQwx6QE7JVo+YHZ/K0Zi2YZ0AxQYrD+4xbE0BiuxHqEu9cIVQXshQoU0W91lzhadL0HEayf1RgHKK3xN0BruqBv9QSG5D/6vAeY5moEX/VB93826uWqCWatsH4oMfHEQ05pu/Hgl//W5vcKLQ+kaMMpd0ESAs9+RWGIACnXQUawfNxkFtguVXlNuFCt4Wb16tHkSVK0fiLuWx2XZC2YXwptqA9jOMpohHXxaUe6OuzFedkkVJXkR8aCQmhN/nsHC1RFusOeV6mAqbo8VLWpLKnqlBBVT/fev8Ctc2L3VhTKAjZi1KWFhKgLfWO/2cNxxRI+FM6JGek7DYyvoaejwMmTsszhsA22KMMXwcfxu5cd6xRdx3chMSm7ERwvADpImAOs35X7s5zsK+u6bmq4yHrmKNtW19cubILjawAtCf2pgqUGaKCMS+RaJ/Q2IzUZmPjg8pejHUer6cxjX4oilWl9Xf6rx281OyabuUNZQxHYA X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAWPR08MB8982.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(346002)(366004)(136003)(39860400002)(230922051799003)(451199024)(1800799009)(186009)(33656002)(55016003)(86362001)(2940100002)(478600001)(38070700005)(38100700002)(122000001)(9686003)(26005)(76116006)(83380400001)(2906002)(5660300002)(8936002)(8676002)(41300700001)(52536014)(66476007)(7696005)(71200400001)(6506007)(66556008)(4744005)(64756008)(91956017)(54906003)(6916009)(4326008)(66446008)(66946007)(316002); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6161 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cf4646c7-81eb-4349-3e8c-08dbbe96efc9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hknFUuSTy1Q6yrTY5gTX9Qmhe8duV75J/MZzmTu2eLPGEkZMrDXkRYZERBFP0an7iFBvpyB2W5OSTmOCYeS83OiRwNFl6hFy1gNbV9mozSWIFGmUdFiI5bcXdQWYs+t2vOBmp6/dAP+HkFk2XTEdqXIoYMUXRhlDRLH95EbZoBtdaoGKVrbyONm5yvMAf3MGzAhb3z2mwe0kGM03GZ84W3OvjriyTbYGTG0SIe5E9w6wcqkyBqafcyR5e/mN2VrDaUlYQy/Fh8xEYC8hCb2BmkJ2BWHkM81fweaOlqW3sdXD+/5Haoc6iq5GEiMn4a//xuioTMDXYP9Gj6DE/9RlZQ849Bw2AC7nrbYJ4SbeKCc2rZOKietexG7Fzoh8vufCLyvOX2wwB+blD09QhhtgIpfG0SFMd1+ISvZDHdeS/u0NmWr/TSO+cpNZOkBIOIybJaH8ByGC2XOl5X65OCCTt+stjqHSHKOcumNjICejR2YwOIiQFxkwtUK+WwQpxkgj7ITQmaCx4/CN9ay9g8dEzuQzRTs0OZ8FL+8kp/HLQSxYO2OP1ufvSCeZw16BJ+JEhmGIom56+yiCS81wX6/8boQrN9UC8K3rxpTM50WQu6glMBQwqGI1/5kV7XnhSd2KkLs+JVDtoi1FQYVq9V6FMGkyzjW5uk0iuq+RXAU/8sgxoTlaySf32aSL92ud2JQyKR/LF+THfKOFN8MRbLnOol0q+bXK/jtys2sT+PquboSFa6Ku3pdrzrdDzMgRel3C X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(376002)(136003)(39860400002)(396003)(230922051799003)(451199024)(1800799009)(186009)(82310400011)(40470700004)(46966006)(36840700001)(336012)(54906003)(2940100002)(40460700003)(2906002)(6916009)(4744005)(41300700001)(55016003)(5660300002)(40480700001)(316002)(52536014)(6506007)(8936002)(4326008)(8676002)(33656002)(70206006)(86362001)(82740400003)(478600001)(70586007)(26005)(9686003)(7696005)(356005)(83380400001)(36860700001)(107886003)(47076005)(81166007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 13:47:28.9991 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 36b1a3ec-e062-4cc0-9675-08dbbe972014 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10172 X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778108171191425669 X-GMAIL-MSGID: 1778108171191425669 |
Series |
AArch64: Remove BTI from outline atomics
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
Wilco Dijkstra
Sept. 26, 2023, 1:46 p.m. UTC
The outline atomic functions have hidden visibility and can only be called directly. Therefore we can remove the BTI at function entry. This improves security by reducing the number of indirect entry points in a binary. The BTI markings on the objects are still emitted. Passes regress, OK for commit? libgcc/ChangeLog: * config/aarch64/lse.S (BTI_C): Remove define. ---
Comments
On 26/09/2023 14:46, Wilco Dijkstra wrote: > > The outline atomic functions have hidden visibility and can only be called > directly. Therefore we can remove the BTI at function entry. This improves > security by reducing the number of indirect entry points in a binary. > The BTI markings on the objects are still emitted. Please can you add a comment to that effect in the source code. OK with that change. R. > > Passes regress, OK for commit? > > libgcc/ChangeLog: > * config/aarch64/lse.S (BTI_C): Remove define. > > --- > > diff --git a/libgcc/config/aarch64/lse.S b/libgcc/config/aarch64/lse.S > index ba05047ff02b6fc5752235bffa924fc4a2f48c04..dbfb83fb09083641bf06c50b631a5f27bdf61b80 100644 > --- a/libgcc/config/aarch64/lse.S > +++ b/libgcc/config/aarch64/lse.S > @@ -163,8 +163,6 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see > #define tmp3 14 > #define tmp4 13 > > -#define BTI_C hint 34 > - > /* Start and end a function. */ > .macro STARTFN name > .text > @@ -174,7 +172,6 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see > .type \name, %function > .cfi_startproc > \name: > - BTI_C > .endm > > .macro ENDFN name
diff --git a/libgcc/config/aarch64/lse.S b/libgcc/config/aarch64/lse.S index ba05047ff02b6fc5752235bffa924fc4a2f48c04..dbfb83fb09083641bf06c50b631a5f27bdf61b80 100644 --- a/libgcc/config/aarch64/lse.S +++ b/libgcc/config/aarch64/lse.S @@ -163,8 +163,6 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see #define tmp3 14 #define tmp4 13 -#define BTI_C hint 34 - /* Start and end a function. */ .macro STARTFN name .text @@ -174,7 +172,6 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see .type \name, %function .cfi_startproc \name: - BTI_C .endm .macro ENDFN name