diff mbox series

Basic asm blocks should always be volatile

Message ID CAP2b4GPn7Ls+OOn-MeDss4tw1d3M3dRg85jdQN_5VHTE2pBvmg@mail.gmail.com
State Not Applicable
Headers
Series Basic asm blocks should always be volatile |

Checks

Context Check Description
snail/gcc-patch-check fail Git am fail log

Commit Message

Julian Waters June 27, 2023, 4:05 p.m. UTC 
  gcc's documentatation mentions that all basic asm blocks are always volatile,
yet the parser fails to account for this by only ever setting
volatile_p to true
if the volatile qualifier is found. This patch fixes this by adding a
special case check for extended_p before finish_asm_stmt is called

From 3094be39e3e65a6a638f05fafd858b89fefde6b5 Mon Sep 17 00:00:00 2001
From: TheShermanTanker <tanksherman27@gmail.com>
Date: Tue, 27 Jun 2023 23:56:38 +0800
Subject: [PATCH] asm not using extended syntax should always be volatile

---
 gcc/cp/parser.cc | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc
index a6341b9..ef3d06a 100644
--- a/gcc/cp/parser.cc
+++ b/gcc/cp/parser.cc
@@ -22355,6 +22355,9 @@  cp_parser_asm_definition (cp_parser* parser)
       /* Create the ASM_EXPR.  */
       if (parser->in_function_body)
  {
+          if (!extended_p) {
+            volatile_p = true;
+          }
    asm_stmt = finish_asm_stmt (asm_loc, volatile_p, string, outputs,
        inputs, clobbers, labels, inline_p);
    /* If the extended syntax was not used, mark the ASM_EXPR.  */