From patchwork Fri Nov 3 06:44:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Richard Thomas X-Patchwork-Id: 161191 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp862871vqu; Fri, 3 Nov 2023 00:48:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF70hgmU/PsoPTe5Cgm3G0OayWa/8jYmQLhCDy352CXzrnf1PlTllLpSEWwpswyRIeLSlpu X-Received: by 2002:a05:6214:2264:b0:66f:b8a2:521a with SMTP id gs4-20020a056214226400b0066fb8a2521amr27110425qvb.17.1698997721913; Fri, 03 Nov 2023 00:48:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1698997721; cv=pass; d=google.com; s=arc-20160816; b=zjIyeFtoPJTDQxZNxGHdMNKxV7IuMYyWrdDA2Aas/LSEXRxcAKTxDxNyKH4g0MJMbP F6vRGgvaAxsdhdHm9BanpLb2mC2BbQl3qzk7FwRCqCjfxnhh2qz89dpIwU+2gfcaHlr9 ReioXKQyVHkymhxFTBbMjIPF3cmnSdIpMKoRJoY89dxarN7uV4i5PoEullpa0e9SRhL7 M293TGri+kmckDDr3zTXs+L9GZSodhzc63ktkmw0wOoGZ3MZW4LNukP6HsbqHDy+6sly aJvKgk726GrNeOTed8QFG74LGd2Nig8uIsCphGnHYShCubcZNpPHEenFnXgHKmnRAEOW zS2A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:to:subject:message-id:date:from :mime-version:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=aRMAaWK0c1IKfXhZCRmanj/9tuobOtqg9kAbW2U5BXk=; fh=GSsCLkWBfXoFiGnDCFSEBskKkonF6jVDtKqqw8KzaAo=; b=p7zzVgj6eGFSgMXayatuXn/7qnukrr5zKsSTXS4DlYgz1R6nW9xEFi1LGPrJW+UuxT 35pMLVhj9lphsosDcRSNdObv3OfwuiOIg6MTrn02RpMWqGYaGq6jR0tbyI2GES6YPtq/ cPuy1LcAp89lHYEeO/augYo1HG/UHs6KQKyeuxGxOMWM2jCd8fjNdqcoPy/PXXMXn596 d1eIhiIkv2sOHHN19EYXV073v/VVkzDKO7Qp+A7qdxDlphuX/k9KuromaRN1gFALm21U ZRqK2QB8Ct8JkcJPIL1QgLbgqo9ROfYiTDDNsZrT1iS1KcQd8WuHct9Q5h1xEBM9wB9c Asqw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=LT9+q+tZ; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id f6-20020ad442c6000000b00670fef9af89si1056080qvr.28.2023.11.03.00.48.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 00:48:41 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=LT9+q+tZ; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DF943385782B for ; Fri, 3 Nov 2023 06:45:21 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 9C4643858C50; Fri, 3 Nov 2023 06:44:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9C4643858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9C4643858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::435 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698993898; cv=none; b=FkH3dgM5tXssqmE+pw1gkw0QKzIhy4GIO7vfw/9+x3FV7S0zwYUIXukYM50rPdYYC37cvTmmAymdEd5vL7qPYTyBwAHFB+8uboElDXUOgEbrhWxWkbVahJ8wQgBRukm8Trt30pA5jsjL38MFiSFab1Z+ZXmXkNrxjyIOyB7iPaM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698993898; c=relaxed/simple; bh=s9pwYfwSWdeRN1CHdo16c7f2RPSifnhuramJ0c8oegA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=P+Dy5eOiU8RD586L/2ALA5NDC92ZmyCF/2YdTI5tI70A3x3wEGCEJli/yZrL9Qm4zshYiXFECr/Z1Yw6v9KXCM9SBevNUHi91J58gl9BUwlJQCNSfjr2IGDAu/WMpcK7pbrhjemaa7rBBoL2HJMWeLdF3/nqzWp9gzSWSSqsOxg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6b1d1099a84so1850124b3a.1; Thu, 02 Nov 2023 23:44:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698993887; x=1699598687; darn=gcc.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=aRMAaWK0c1IKfXhZCRmanj/9tuobOtqg9kAbW2U5BXk=; b=LT9+q+tZXmQMrm+HvCaon0KY030L5yM1XdgrPlhs4EHZrrU26l9F85/PC0mRObznsw aTo15aNhBXicA49pprGVQkCsCGUlbIgRnIa3T/YD3pXB+yx8uuwncl2xyEypac7Ke1Z3 SLBbe1TRkzlbWO3avN6ZX+v+NKMnumPYNNPV/s/R6kQneQRJD2fpVmSWgkzGYJlYtGti 0FJliD+19HUk9ofsNsJmPfn603a974j8w+ILYXXhhcuBgKMVi3UTSmeThdjGxk5lLeGX 9tgUuG5gCVq8rMISpmFL6OVZDFXT0gcW4xUkuaLQFDQ110/NFEta863UKB6ayDaqgisi Xbng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698993887; x=1699598687; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=aRMAaWK0c1IKfXhZCRmanj/9tuobOtqg9kAbW2U5BXk=; b=FWKvuJZp1uM0GKhr7cfaeMpIoFhPYQ+ExKG7TcXsvRdliFHvzp4uBf6CP/imqJKYR4 oTBVLAmq+gYBB3Vc189xVlqJWvzVRQWrMqZITHtq8H37PfVQNfJOY8lzRwD8ob5HUcki bRcmH85MG7cXrNUsCWqfUyRZ1YC+qHiMcWafhmG459Oaa0eAbchtRjZiUMC11+mGvSXX 2jD7kJpI5e9HfXRhDMq4eG8rMpTAziWSrYuW5BGoK2X43Ynn7iWcOq+uQJde2Lym5YA8 7FdVMFfEaP6HivRohxK3a6rJpK8xo4TM24GoF40MyCeuCETIjpeQkJk++piKMdrsUKdb Q84w== X-Gm-Message-State: AOJu0YyUr1kLuEwBd9FUGHYy9wLpNJbLPoyWXtwABkcvO8KSStLnKouC iarrt6Q7eLJxJFFREzTI7ondwgrt0m6n2PI2NvIA+5TEZLs= X-Received: by 2002:a05:6a20:8e2a:b0:132:ff57:7fab with SMTP id y42-20020a056a208e2a00b00132ff577fabmr26096763pzj.2.1698993887025; Thu, 02 Nov 2023 23:44:47 -0700 (PDT) MIME-Version: 1.0 From: Paul Richard Thomas Date: Fri, 3 Nov 2023 06:44:35 +0000 Message-ID: Subject: [Patch, fortran] PR112316 - [13 Regression] Fix for PR87477 rejects valid code with a bogus error... To: "fortran@gcc.gnu.org" , gcc-patches X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781528235238804656 X-GMAIL-MSGID: 1781528235238804656 Hi All, I have pushed as 'obvious' a fix for this regression to both 13-branch and mainline. The patch itself looks substantial but it consists entirely of the removal of a condition and repagination of the corresponding block. Please see below for part of my first comment on the PR for an explanation. Paul A temporary work around is to invert the order of the contained procedures. The problem is caused by a stupid (on my part :-( ) oversight: fixes the problem and regtests OK. diff --git a/gcc/fortran/parse.cc b/gcc/fortran/parse.cc index e103ebee557..f88f9be3be8 100644 --- a/gcc/fortran/parse.cc +++ b/gcc/fortran/parse.cc @@ -5196,7 +5196,7 @@ parse_associate (void) } } - if (target->rank) + if (1) { int rank = 0; rank = target->rank;