From patchwork Thu Feb 16 17:39:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 58175 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp435184wrn; Thu, 16 Feb 2023 09:40:15 -0800 (PST) X-Google-Smtp-Source: AK7set9BHS3HKQEPja7vu+1e96MxlcHiVWUr+gIzF05VPzsedJKbPFEXCTtnahFH7aWBw7GLq3Q+ X-Received: by 2002:aa7:cb4c:0:b0:4ac:d925:1a94 with SMTP id w12-20020aa7cb4c000000b004acd9251a94mr6971943edt.24.1676569215265; Thu, 16 Feb 2023 09:40:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676569215; cv=none; d=google.com; s=arc-20160816; b=sZFmHoqwk5ozzS/fKdBUKXRAUJQprnm9mphsrunv5CIta0iOqjspoVmjhh5MLJhsEN jK8FHSiaECnMSS1LOSFMW94VSJLfhbccrXaUNY8MspgcEV2NZysVfyC+MgIWFSN9XaYj GKPGNJAQjgsPskh4zyUgFV+iXkgyq0U2QwWe2Pe0koafEpEfOVulTEEU4JRlypJHOjT+ bOO2Qka3mlPhz7RtViw33X8NGzZJNkYy+AQBGQ/c16eryliAPMsvd5hLr0tFx4T2BtFi GaiY+xiHg2weUHJLalqXy9GuPWTTFsUAAnz45/WmLdcbC+c/+GCVrHrRl2vPH8Uhr/uf xv0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:cc:to:subject :message-id:date:mime-version:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=Dtngyu9uVw+SbqOI2M0xneCyP4X/iufICDDtSgwlCXU=; b=Tm731bdioi2AIhS/zgsRFXZ79N41O31v8FHeacS+oYbBb80GyZ2rIYnH3tHbsnB0dQ jKifPhh9YpKS2lQ7AB0TYZ46Rm84TbHuJWhUZ63zjZQ+MyNTIdHff/aiv1SAkwu3AUaR odg3il8FdhgUFNi1BdEY/URnR6XZO0q897BxOLHkiekCA5T+KSxv2vEdpRMAyar0bUMe IVec2hCKVTdwHUZ+rJAO/1jHKtU6+Xi1/j64wZOmlgjHC8uqSdLaPvJaVWSCBDecNpSs pdJcnP4lNc67lEFT/ZHc3RQXfn2Tl2WRbWEgilVs2Cq6EJXhoOElap7/xug2a2t9IQxC DK4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=he02x+tt; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id m11-20020a50ef0b000000b004ad797532easi413887eds.34.2023.02.16.09.40.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 09:40:15 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=he02x+tt; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 156863858281 for ; Thu, 16 Feb 2023 17:40:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 156863858281 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1676569214; bh=Dtngyu9uVw+SbqOI2M0xneCyP4X/iufICDDtSgwlCXU=; h=Date:Subject:To:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=he02x+tt2p2UzwqVOubWIn+VCcULK6HCAg+5Rdg8v3yWRVVzXIGBNWBN1HV8K8OeM 39pPqnQ80Z3+zm/T+hotGf8ow+h6DVF5IlkPe31/ghCiq0SUH0UagJ3MeqxfHtXIws pw/SLREF4/lRSPDq8dR/yLGg+mZz63M7Pmpwar8Y= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by sourceware.org (Postfix) with ESMTPS id 41AAC3858D33 for ; Thu, 16 Feb 2023 17:39:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41AAC3858D33 Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-5342c9c53a0so1671237b3.2 for ; Thu, 16 Feb 2023 09:39:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Dtngyu9uVw+SbqOI2M0xneCyP4X/iufICDDtSgwlCXU=; b=Je7mLdLej00Ab+51gxZPRpn4LGNdGWmS5m9taq8nQ6RNoj/Rx7gKTuBQ1XYD4fJMmn v1MrQeyV5SOgObPnYg/6NyOkeROTi+LLO6RjlPLx0T3R0rp9P7hrpod/X3MI5+QHA2It 5gmGX8vCoeBHFoxf9pHTAiJJcdJ/4+9w76SgZ8oJpONA2sstrATj3dF5HfpuOpVjdhk/ 6QETtkUl7jQ4aPWJXIK73lY1mW7Tig9xsyA4TiZIDUCgOMBNKPSLHWiWRMNcZWTga00n aMAe0ji5weV2S7YsJ3jr7DhXK8hPK16IAtRA+a5NrUUF9YpGF8EAKRFloYCwOdh5QFxW TzUg== X-Gm-Message-State: AO0yUKVE1a5upJOWyZvAdLl0c3+nSMgnKwkHJWcAl3YN8g91AuXBFlYV RwsUqwrfUFar19YCnt5ivCxHc8VcoFMxaEonCZHJNoQMbkCydQ== X-Received: by 2002:a81:dd11:0:b0:52e:ee32:89bf with SMTP id e17-20020a81dd11000000b0052eee3289bfmr772706ywn.241.1676569168282; Thu, 16 Feb 2023 09:39:28 -0800 (PST) MIME-Version: 1.0 Date: Thu, 16 Feb 2023 18:39:16 +0100 Message-ID: Subject: [PATCH] simplify-rtx: Fix VOIDmode operand handling in simplify_subreg [PR108805] To: "gcc-patches@gcc.gnu.org" Cc: Richard Sandiford , Richard Biener X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Uros Bizjak via Gcc-patches From: Uros Bizjak Reply-To: Uros Bizjak Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758010241196985518?= X-GMAIL-MSGID: =?utf-8?q?1758010241196985518?= simplify_subreg can return VOIDmode const_int operand and will cause ICE in simplify_gen_subreg when this operand is passed to it. The patch prevents VOIDmode temporary from entering simplify_gen_subreg. We can't process const_int operand any further, since outermode is not an integer mode here. 2023-02-16 Uroš Bizjak gcc/ChangeLog: PR target/108805 * simplify_rtx.cc (simplify_context::simplify_subreg): Prevent VOIDmode const_int result from simplify_subreg from entering simplify_gen_subreg. gcc/testsuite/ChangeLog: PR target/108805 * gcc.dg/pr108805.c: New test. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. OK for master and release branches? Uros. diff --git a/gcc/simplify-rtx.cc b/gcc/simplify-rtx.cc index 0a1dd88b0a8..281bc418df0 100644 --- a/gcc/simplify-rtx.cc +++ b/gcc/simplify-rtx.cc @@ -7664,7 +7664,7 @@ simplify_context::simplify_subreg (machine_mode outermode, rtx op, 0).exists (&int_outermode)) { rtx tem = simplify_subreg (int_outermode, op, innermode, byte); - if (tem) + if (tem && GET_MODE (tem) != VOIDmode) return simplify_gen_subreg (outermode, tem, GET_MODE (tem), 0); } diff --git a/gcc/testsuite/gcc.dg/pr108805.c b/gcc/testsuite/gcc.dg/pr108805.c new file mode 100644 index 00000000000..280d3f5c377 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr108805.c @@ -0,0 +1,20 @@ +/* { dg-do compile { target longlong64 } } */ +/* { dg-options "-O" } */ +/* { dg-additional-options "-msse2" { target x86_64-*-* i?86-*-* } } */ + +typedef __INT8_TYPE__ __attribute__((__vector_size__ (4))) U; +typedef __INT32_TYPE__ __attribute__((__vector_size__ (4))) V; +typedef __UINT64_TYPE__ __attribute__((__vector_size__ (8))) W; + +int i; +U h; +W g; + +U +foo (void) +{ + W w = i != g; + V v = __builtin_convertvector (i | w >> 2, V); + U u = (U) v[0] + h; + return u; +}