Message ID | 9cd24eab-f811-01fd-72f1-36c4c7a7f1ea@gmail.com |
---|---|
State | Accepted |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp869808vqg; Sat, 22 Jul 2023 08:54:12 -0700 (PDT) X-Google-Smtp-Source: APBJJlFAf8p4h/e6pWQrc5/4FIBJh3nweKY44GlYvHtjCs6BI/vpeEHtt0vF7alNa19oWzcLYLNz X-Received: by 2002:a17:907:2710:b0:992:764b:90d5 with SMTP id w16-20020a170907271000b00992764b90d5mr4386568ejk.71.1690041252242; Sat, 22 Jul 2023 08:54:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690041252; cv=none; d=google.com; s=arc-20160816; b=DbOXFfz3F8+iKyxWeeflGcpMm4oPv/egf0k+GBE3AfBOR8MRb7wgD/4nf7cWR4xLyw iKY98v7Ie/K1bmGkuZqoksWdl8VOT/SMp8/LaXirJfcTGDhk3ZAMKzhswIDXt55vanei ZiB/lBPZtQML2SsChIdKPuswKnf69RRy4qTqy8i8eSG2Bn6SOu//OnFqvzDgcFZjh5Rw HfgKeuMhyqVeVHPDSElpGj9R8kLbdKemEB336wqqF5NrhK/YHiTed3QS2s+Wy5KezC/3 lbJgdwLIflI10mgdnkb7xMkrYoeaW9Fy1aX+5VFtYTJMWoT6JqFvWXHuXiGiZKOq9WRV N+JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:to:subject :content-language:user-agent:mime-version:date:message-id :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=1Se8DXsIU/aQMB8fPCAGAjWdOZ/B74+FemXdVVYnTNU=; fh=M5qwlmhoC9OW65qhxcbZ1oi6Och98fkiOGD1Iw/ypWA=; b=DZ0AukdDhDYEJNoG/mtnFOH/bkqlbe2CoFQMwLX7hKsPMUueAD5HxlcAAk0PYN0tAg EKYeHjxvI+EIzYyFsP3kyaRutSLLGAOJy5sK9InbePAMBjpYmrsT/xkdm/DhawHjVpU4 rgt2Fv6G7ZF2I9IvHgtjv9AeaoIqnM0SNC7Jv9l9zZfE/EwcacQcG1JhOnqAfA6aUNsi xxVjc/Zgyi9i1iMocX0QACdhb8CBXQF3eKxyxjrVfpRsz+E2f8r0AP4mwuLJIT+QfnMO B7PoUaSMOG0rIYcrDwUzhe451tVFjiRtyJRl197qyFFCe5HaLPdcqbxalnCkzYZlc8LR cqqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=TxNjOUb8; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id pk15-20020a170906d7af00b00988ce522544si4005600ejb.753.2023.07.22.08.54.12 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jul 2023 08:54:12 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=TxNjOUb8; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 17A7F3858CDA for <ouuuleilei@gmail.com>; Sat, 22 Jul 2023 15:54:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 17A7F3858CDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1690041251; bh=1Se8DXsIU/aQMB8fPCAGAjWdOZ/B74+FemXdVVYnTNU=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=TxNjOUb8Ggf+KIK4rX8JKS1ZkHCek2WIEmQqQ54VUaG/Q5VbD2BHeo8rTT7BPwmoe Ap6pz8cGQab2Q2AFcceNoQ3iFuelixCxwNWaMrJW0iPEgfJV7YmZdV0B3DhEwc8/D/ /FH15mhDtAV6Uc6xkBfSl34TfUlXPM8p93qjH53w= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 730653853D1A for <gcc-patches@gcc.gnu.org>; Sat, 22 Jul 2023 15:53:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 730653853D1A Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1b8ad356fe4so18582135ad.2 for <gcc-patches@gcc.gnu.org>; Sat, 22 Jul 2023 08:53:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690041207; x=1690646007; h=to:subject:from:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1Se8DXsIU/aQMB8fPCAGAjWdOZ/B74+FemXdVVYnTNU=; b=B2nnA5oWr2rLqlWCWhkvVb8Gbe6/jld+rGZlbT3LvhkkbG3RiQEyv/uP0mXkqu6F/3 Yz0Kqc5u1sl45RlmTbmF3B5/QEw2gYRUC9JjdKI/AKhIMdFk+J0/wGYiw5zor6q4c+2B 8re23MzLGw5oS/4tY4vXWEDdARYoImQpAHw2zM4VT+76F5NMgXKOoEemD2cL/WdXzvDz /lB/EyYQ/4JRneWVc4r8KOGztOSiRMuxdEPjny2hMOVsyJjrnlcsU9TW/C/gyrOyDUNb 5eA0TXpIRIwJIo5FUCUXOrvh+6h4s27xQLKN46WkhzICm3dQb1RRAHWnh4Ccki3TLHtq ihUQ== X-Gm-Message-State: ABy/qLanStw9VJ4ilJOzOznPk5m32Ja6ew4lzgek38iIM8y4ac0nco+a DYFIZ9+kSzO6W5Nj8omAZOxb7ltlYlF84g== X-Received: by 2002:a17:902:ecc3:b0:1bb:141c:3034 with SMTP id a3-20020a170902ecc300b001bb141c3034mr5265177plh.12.1690041206865; Sat, 22 Jul 2023 08:53:26 -0700 (PDT) Received: from [172.31.1.103] ([172.56.168.196]) by smtp.gmail.com with ESMTPSA id t19-20020a1709028c9300b001993a1fce7bsm1665673plo.196.2023.07.22.08.53.25 for <gcc-patches@gcc.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Jul 2023 08:53:26 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------P0bSmw900AMiVknZbp0gLMDk" Message-ID: <9cd24eab-f811-01fd-72f1-36c4c7a7f1ea@gmail.com> Date: Sat, 22 Jul 2023 09:53:24 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US Subject: [committed] Fix length computation bug in bfin port To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org> X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Jeff Law via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Jeff Law <jeffreyalaw@gmail.com> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772136695969174810 X-GMAIL-MSGID: 1772136695969174810 |
Series |
[committed] Fix length computation bug in bfin port
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | success | Github commit url |
Commit Message
Jeff Law
July 22, 2023, 3:53 p.m. UTC
The tester seemed to occasionally ping-pong a compilation failure on the builtin-bitops-1.c test. I long suspected it was something like length computations. I finally got a few minutes to dig into it, and sure enough the blackfin port was claiming the "ones" operation was 2 bytes when it is in fact 4 bytes. This fixes the compilation failure for the builtin-bitops-1.c test. Sadly, it doesn't fix any of the other failures on the bfin port. Committed to the trunk. Jeff commit bb095e8a343db043a0cd0b0da9b2ab1186d1a1ed Author: Jeff Law <jlaw@ventanamicro.com> Date: Sat Jul 22 09:47:21 2023 -0600 [committed] Fix length computation bug in bfin port The tester seemed to occasionally ping-pong a compilation failure on the builtin-bitops-1.c test. I long suspected it was something like length computations. I finally got a few minutes to dig into it, and sure enough the blackfin port was claiming the "ones" operation was 2 bytes when it is in fact 4 bytes. This fixes the compilation failure for the builtin-bitops-1.c test. Sadly, it doesn't fix any of the other failures on the bfin port. Committed to the trunk. gcc/ * config/bfin/bfin.md (ones): Fix length computation.
diff --git a/gcc/config/bfin/bfin.md b/gcc/config/bfin/bfin.md index 9b5ab071778..c6b174dc3bd 100644 --- a/gcc/config/bfin/bfin.md +++ b/gcc/config/bfin/bfin.md @@ -1401,7 +1401,8 @@ (define_insn "ones" (popcount:SI (match_operand:SI 1 "register_operand" "d"))))] "" "%h0 = ONES %1;" - [(set_attr "type" "alu0")]) + [(set_attr "type" "alu0") + (set_attr "length" "4")]) (define_expand "popcountsi2" [(set (match_dup 2)