Cleanup gdb printers.py

Message ID 964f50d9-4bc2-8481-b855-d2f10a2e7f41@gmail.com
State Accepted, archived
Headers
Series Cleanup gdb printers.py |

Checks

Context Check Description
snail/gcc-patches-check success Github commit url

Commit Message

François Dumont Sept. 21, 2022, 7:56 p.m. UTC
  I stopped my research to find out if those types ever existed in 2001. 
Clearly they do not exist now.

     libstdc++: Remove useless gdb printer registrations.

     libstdc++-v3/ChangeLog:

             * python/libstdcxx/v6/printers.py: Remove printer 
registration for non-existing
             types std::__debug::unique_ptr, std::__debug::stack, 
std::__debug::queue,
             std::__debug::priority_queue.

Ok to commit ?

François
  

Comments

Jonathan Wakely Sept. 21, 2022, 8:45 p.m. UTC | #1
On Wed, 21 Sept 2022 at 20:57, François Dumont via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> I stopped my research to find out if those types ever existed in 2001.
> Clearly they do not exist now.
>
>      libstdc++: Remove useless gdb printer registrations.
>
>      libstdc++-v3/ChangeLog:
>
>              * python/libstdcxx/v6/printers.py: Remove printer
> registration for non-existing
>              types std::__debug::unique_ptr, std::__debug::stack,
> std::__debug::queue,
>              std::__debug::priority_queue.
>
> Ok to commit ?

Oh good catch, please commit, thanks!
  

Patch

diff --git a/libstdc++-v3/python/libstdcxx/v6/printers.py b/libstdc++-v3/python/libstdcxx/v6/printers.py
index bd4289c1c62..5a3dcbd13f9 100644
--- a/libstdc++-v3/python/libstdcxx/v6/printers.py
+++ b/libstdc++-v3/python/libstdcxx/v6/printers.py
@@ -2246,12 +2246,7 @@  def build_libstdcxx_dictionary ():
     libstdcxx_printer.add('std::__debug::map', StdMapPrinter)
     libstdcxx_printer.add('std::__debug::multimap', StdMapPrinter)
     libstdcxx_printer.add('std::__debug::multiset', StdSetPrinter)
-    libstdcxx_printer.add('std::__debug::priority_queue',
-                          StdStackOrQueuePrinter)
-    libstdcxx_printer.add('std::__debug::queue', StdStackOrQueuePrinter)
     libstdcxx_printer.add('std::__debug::set', StdSetPrinter)
-    libstdcxx_printer.add('std::__debug::stack', StdStackOrQueuePrinter)
-    libstdcxx_printer.add('std::__debug::unique_ptr', UniquePointerPrinter)
     libstdcxx_printer.add('std::__debug::vector', StdVectorPrinter)
 
     # These are the TR1 and C++11 printers.