From patchwork Wed Jul 13 18:18:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: will schmidt X-Patchwork-Id: 241 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a98:d5ce:0:b0:178:cc93:bf7d with SMTP id g14csp391179eik; Wed, 13 Jul 2022 11:19:22 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tdnextaHD3ZCvKCVHHez2dHnoSlmQ/8UL+0HA7rKIGFhgOkyWFX0SRj6rjHJ55nuzkLHea X-Received: by 2002:a17:907:75e9:b0:72b:2ddb:41fe with SMTP id jz9-20020a17090775e900b0072b2ddb41femr4804903ejc.329.1657736362297; Wed, 13 Jul 2022 11:19:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657736362; cv=none; d=google.com; s=arc-20160816; b=DlJtYe8CIVfaYjJ4HRLSSHnnKkpf6rksd4Sltx688DmNd2M1otwSQm5DB7sVNUFFnQ 8WRGp2armEP3ZoAlPd5pMLbtYCdFSshi63Fp+3vQmHFYVdApKTGU5uzJGeKd+0zKBiAX nFUB4xHkT92MxEfQMY7NZ9hGXLSHlwwkDusKu38YSVsrIEdHtFUWqnu1oK2Q9mATYsuI j2mrrAi1R6LtmW3UTJXOuZYeWpOZ4M1znaE4VrnfrhsrJCxaB4Jap7/n27AgwBdW7o3j qp2CPd709ouSHhtN/MPlkz28iE515VucRBCeSOb/66fw2pmtKMngPF8wKSsrbCfUEfvJ I2lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:date:to:subject:message-id :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=qmVxRQADvYRSg3HBJNwtIErOTpgMNwn5Cyowlh4h4Zc=; b=TPTuqHCzF6dxP02oNcDqXXyJ8Ut37R2NtrU5Wes2iv0qHIrRDEBTqQH5k8BqtA6yXE btEORLeTRYXoOIGhwGQupGQyym2ZoDgJcQJ8RZtWk55/ArboGnN7rMf3osczhQvpB5c/ sgYnfNzkPrQCKmfm4RVnr284+ZYqwagpqfqjv4WkdtAXFeTyU/FAuD7upwJOK8OymDdl ZDPX7S8Xo6yRT7a292jKhZqArkbpim/x+cNi8YpCrrZNan38+BLHrXXRZC39F5wwvRlk F+PPfCDb1nBsAqur5SVcMlQFQb8iRMLVgYUTJ4lfANZwbnKR2IgQDB1XJC49iNy+F5pS WI0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=ZHSsnHE9; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id hp29-20020a1709073e1d00b0072ed0d06c0csi817378ejc.411.2022.07.13.11.19.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 11:19:22 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=ZHSsnHE9; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EA98B384D17C for ; Wed, 13 Jul 2022 18:19:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EA98B384D17C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1657736361; bh=qmVxRQADvYRSg3HBJNwtIErOTpgMNwn5Cyowlh4h4Zc=; h=Subject:To:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=ZHSsnHE9Ag8yjVy2iIuPUsnhwj4ZFX5xYF5URAo9ffZiil/d3btM+CTs/JDFHDp9F eRLldthEUtKDOcE8F9PnlxMTfcSSvYhXSOzHAWLQsm8Dzwl1+pGyHEyN23ssaZVmO/ eZj2Jp3OoTsVIqYaB7kv7t3Jc3D2L6B1TrYacL3Q= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 57939384D18D for ; Wed, 13 Jul 2022 18:18:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 57939384D18D Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26DICJlm005181; Wed, 13 Jul 2022 18:18:33 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ha346r4wt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Jul 2022 18:18:33 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 26DIDOwf007841; Wed, 13 Jul 2022 18:18:32 GMT Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ha346r4wc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Jul 2022 18:18:32 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 26DHomsw023763; Wed, 13 Jul 2022 18:18:31 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma02dal.us.ibm.com with ESMTP id 3h9am4sgc4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Jul 2022 18:18:31 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 26DIIU4418481990 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Jul 2022 18:18:30 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BF14A28059; Wed, 13 Jul 2022 18:18:30 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 58F6A28058; Wed, 13 Jul 2022 18:18:30 +0000 (GMT) Received: from lexx (unknown [9.160.8.243]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 13 Jul 2022 18:18:30 +0000 (GMT) Message-ID: <6da1e35def9d282bcf87483e78cf578fff604723.camel@vnet.ibm.com> Subject: [PATCH, rs6000] Cleanup some vstrir define_expand naming inconsistencies To: GCC Patches Date: Wed, 13 Jul 2022 13:18:29 -0500 X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: mw8N9DaI1eLnaP2o_cOkmfFfldDYXDpY X-Proofpoint-ORIG-GUID: R3_Ps0-3Yqiiz4pDKVUmtj6Wm1YYkhmT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-13_07,2022-07-13_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 mlxscore=0 mlxlogscore=738 impostorscore=0 spamscore=0 clxscore=1015 suspectscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207130073 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: will schmidt via Gcc-patches From: will schmidt Reply-To: will schmidt Cc: David Edelsohn , Segher Boessenkool Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1738262563663994106?= X-GMAIL-MSGID: =?utf-8?q?1738262563663994106?= [PATCH, rs6000] Cleanup some vstrir define_expand naming inconsistencies Hi, This cleans up some of the naming around the vstrir and vstril instruction definitions, with some cosmetic changes for consistency. No functional changes. Regtested just in case, no regressions. :-) OK for trunk? Thanks, gcc/ * config/rs6000/altivec.md (vstrir_code_): Rename to vstrir_internal_. (vstrir_p_code_): Rename to vstrir_p_internal_. (vstril_code_): Rename to vstril_internal_. (vstril_p_code_): Rename to vstril_p_internal_. diff --git a/gcc/config/rs6000/altivec.md b/gcc/config/rs6000/altivec.md index efc8ae35c2e7..5aea02e9ad6e 100644 --- a/gcc/config/rs6000/altivec.md +++ b/gcc/config/rs6000/altivec.md @@ -884,44 +884,44 @@ (define_expand "vstrir_" (unspec:VIshort [(match_operand:VIshort 1 "altivec_register_operand")] UNSPEC_VSTRIR))] "TARGET_POWER10" { if (BYTES_BIG_ENDIAN) - emit_insn (gen_vstrir_code_ (operands[0], operands[1])); + emit_insn (gen_vstrir_internal_ (operands[0], operands[1])); else - emit_insn (gen_vstril_code_ (operands[0], operands[1])); + emit_insn (gen_vstril_internal_ (operands[0], operands[1])); DONE; }) -(define_insn "vstrir_code_" +(define_insn "vstrir_internal_" [(set (match_operand:VIshort 0 "altivec_register_operand" "=v") (unspec:VIshort [(match_operand:VIshort 1 "altivec_register_operand" "v")] UNSPEC_VSTRIR))] "TARGET_POWER10" "vstrir %0,%1" [(set_attr "type" "vecsimple")]) -;; This expands into same code as vstrir_ followed by condition logic +;; This expands into same code as vstrir followed by condition logic ;; so that a single vstribr. or vstrihr. or vstribl. or vstrihl. instruction ;; can, for example, satisfy the needs of a vec_strir () function paired ;; with a vec_strir_p () function if both take the same incoming arguments. (define_expand "vstrir_p_" [(match_operand:SI 0 "gpc_reg_operand") (match_operand:VIshort 1 "altivec_register_operand")] "TARGET_POWER10" { rtx scratch = gen_reg_rtx (mode); if (BYTES_BIG_ENDIAN) - emit_insn (gen_vstrir_p_code_ (scratch, operands[1])); + emit_insn (gen_vstrir_p_internal_ (scratch, operands[1])); else - emit_insn (gen_vstril_p_code_ (scratch, operands[1])); + emit_insn (gen_vstril_p_internal_ (scratch, operands[1])); emit_insn (gen_cr6_test_for_zero (operands[0])); DONE; }) -(define_insn "vstrir_p_code_" +(define_insn "vstrir_p_internal_" [(set (match_operand:VIshort 0 "altivec_register_operand" "=v") (unspec:VIshort [(match_operand:VIshort 1 "altivec_register_operand" "v")] UNSPEC_VSTRIR)) (set (reg:CC CR6_REGNO) @@ -936,17 +936,17 @@ (define_expand "vstril_" (unspec:VIshort [(match_operand:VIshort 1 "altivec_register_operand")] UNSPEC_VSTRIR))] "TARGET_POWER10" { if (BYTES_BIG_ENDIAN) - emit_insn (gen_vstril_code_ (operands[0], operands[1])); + emit_insn (gen_vstril_internal_ (operands[0], operands[1])); else - emit_insn (gen_vstrir_code_ (operands[0], operands[1])); + emit_insn (gen_vstrir_internal_ (operands[0], operands[1])); DONE; }) -(define_insn "vstril_code_" +(define_insn "vstril_internal_" [(set (match_operand:VIshort 0 "altivec_register_operand" "=v") (unspec:VIshort [(match_operand:VIshort 1 "altivec_register_operand" "v")] UNSPEC_VSTRIL))] "TARGET_POWER10" @@ -962,18 +962,18 @@ (define_expand "vstril_p_" (match_operand:VIshort 1 "altivec_register_operand")] "TARGET_POWER10" { rtx scratch = gen_reg_rtx (mode); if (BYTES_BIG_ENDIAN) - emit_insn (gen_vstril_p_code_ (scratch, operands[1])); + emit_insn (gen_vstril_p_internal_ (scratch, operands[1])); else - emit_insn (gen_vstrir_p_code_ (scratch, operands[1])); + emit_insn (gen_vstrir_p_internal_ (scratch, operands[1])); emit_insn (gen_cr6_test_for_zero (operands[0])); DONE; }) -(define_insn "vstril_p_code_" +(define_insn "vstril_p_internal_" [(set (match_operand:VIshort 0 "altivec_register_operand" "=v") (unspec:VIshort [(match_operand:VIshort 1 "altivec_register_operand" "v")] UNSPEC_VSTRIL)) (set (reg:CC CR6_REGNO)