diff mbox series

Fix configure script comments(!?!) (Was: Re: [PATCH] genemit: Split insn-emit.cc into ten files)

Message ID 65491c69.670a0220.24aca.643bSMTPIN_ADDED_BROKEN@mx.google.com
State Unresolved
Headers
Series Fix configure script comments(!?!) (Was: Re: [PATCH] genemit: Split insn-emit.cc into ten files) |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

Martin Jambor Nov. 6, 2023, 5:03 p.m. UTC 
  Hello,

On Thu, Oct 12 2023, Robin Dapp wrote:
>
[...]
> gcc/ChangeLog:
>
> 	PR bootstrap/84402
> 	PR target/111600
>
> 	* Makefile.in: Handle split insn-emit.cc.
> 	* configure: Regenerate.
> 	* configure.ac: Add --with-insnemit-partitions.
> 	* genemit.cc (output_peephole2_scratches): Print to file instead
> 	of stdout.
> 	(print_code): Ditto.
> 	(gen_rtx_scratch): Ditto.
> 	(gen_exp): Ditto.
> 	(gen_emit_seq): Ditto.
> 	(emit_c_code): Ditto.
> 	(gen_insn): Ditto.
> 	(gen_expand): Ditto.
> 	(gen_split): Ditto.
> 	(output_add_clobbers): Ditto.
> 	(output_added_clobbers_hard_reg_p): Ditto.
> 	(print_overload_arguments): Ditto.
> 	(print_overload_test): Ditto.
> 	(handle_overloaded_code_for): Ditto.
> 	(handle_overloaded_gen): Ditto.
> 	(print_header): New function.
> 	(handle_arg): New function.
> 	(main): Split output into 10 files.
> 	* gensupport.cc (count_patterns): New function.
> 	* gensupport.h (count_patterns): Define.
> 	* read-md.cc (md_reader::print_md_ptr_loc): Add file argument.
> 	* read-md.h (class md_reader): Change definition.

Following this commit, our buildbot script which checks that configure
scripts where re-generated correctly is unhappy because it insists
comments are wrong, it wants to them to be like this:

------------------------------------------------------------
------------------------------------------------------------

I'm not sure what that means, whether a wrong version of
autoconf/automake was used (though when I accidentally tried that, it
has always complained loudly) or if some environment difference can
cause this.  Perhaps I should change the script not to care about
commits though that won't happen soon (or perhaps I should drop the
checks completely) but would people be OK with me checking in the patch
above (with appropriate ChangeLog) to silence buildbot for a while
again?

Thanks,

Martin
diff mbox series

Patch

diff --git a/gcc/configure b/gcc/configure
index 4d0357cbc28..0d818ae6850 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -20000,7 +20000,7 @@  else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 19995 "configure"
+#line 20003 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -20106,7 +20106,7 @@  else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 20101 "configure"
+#line 20109 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H