diff mbox series

testsuite, rs6000: Adjust ppc-fortran.exp to support dg-{warning,error}

Message ID 60621672-5c9e-ddb3-51fa-5565d678899c@linux.ibm.com
State Accepted
Headers
Series testsuite, rs6000: Adjust ppc-fortran.exp to support dg-{warning,error} |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Kewen.Lin March 6, 2023, 9:27 a.m. UTC 
  Hi,

According to Haochen's finding in [1], currently ppc-fortran.exp
doesn't support Fortran specific warning or error messages well.
By looking into it, it's due to that gfortran uses some different
warning/error prefixes as follows:

    set gcc_warning_prefix "\[Ww\]arning:"
    set gcc_error_prefix "(Fatal )?\[Ee\]rror:"

comparing to:

    set gcc_warning_prefix "warning:"
    set gcc_error_prefix "(fatal )?error:"

So this is to override these two prefixes and make it support
dg-{warning,error} checks.

Tested on powerpc64-linux-gnu P7/P8/P9 and
powerpc64le-linux-gnu P9/P10.

[1] https://gcc.gnu.org/pipermail/gcc-patches/2023-March/613302.html

BR,
Kewen
-----

gcc/testsuite/ChangeLog:

	* gcc.target/powerpc/ppc-fortran/ppc-fortran.exp: Override
	gcc_{warning,error}_prefix with Fortran specific one used in
	gfortran_init.
---
 gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp | 5 +++++
 1 file changed, 5 insertions(+)

--
2.39.1

Comments

HAO CHEN GUI March 10, 2023, 8:36 a.m. UTC | #1 
Hi Kewen,
  I tested it with my fortran test case. It works. Thanks a lot.

Gui Haochen

在 2023/3/6 17:27, Kewen.Lin 写道:
> Hi,
> 
> According to Haochen's finding in [1], currently ppc-fortran.exp
> doesn't support Fortran specific warning or error messages well.
> By looking into it, it's due to that gfortran uses some different
> warning/error prefixes as follows:
> 
>     set gcc_warning_prefix "\[Ww\]arning:"
>     set gcc_error_prefix "(Fatal )?\[Ee\]rror:"
> 
> comparing to:
> 
>     set gcc_warning_prefix "warning:"
>     set gcc_error_prefix "(fatal )?error:"
> 
> So this is to override these two prefixes and make it support
> dg-{warning,error} checks.
> 
> Tested on powerpc64-linux-gnu P7/P8/P9 and
> powerpc64le-linux-gnu P9/P10.
> 
> [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-March/613302.html
> 
> BR,
> Kewen
> -----
> 
> gcc/testsuite/ChangeLog:
> 
> 	* gcc.target/powerpc/ppc-fortran/ppc-fortran.exp: Override
> 	gcc_{warning,error}_prefix with Fortran specific one used in
> 	gfortran_init.
> ---
>  gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp b/gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp
> index a556d7b48a3..f7e99ac8487 100644
> --- a/gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp
> +++ b/gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp
> @@ -58,6 +58,11 @@ proc dg-compile-aux-modules { args } {
>      }
>  }
> 
> +# Override gcc_{warning,error}_prefix with Fortran specific prefixes used
> +# in gfortran_init to support dg-{warning,error} checks.
> +set gcc_warning_prefix "\[Ww\]arning:"
> +set gcc_error_prefix "(Fatal )?\[Ee\]rror:"
> +
>  # Main loop.
>  gfortran-dg-runtest [lsort \
>         [glob -nocomplain $srcdir/$subdir/*.\[fF\]{,90,95,03,08} ] ] "" $DEFAULT_FFLAGS
> --
> 2.39.1
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp b/gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp
index a556d7b48a3..f7e99ac8487 100644
--- a/gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp
+++ b/gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp
@@ -58,6 +58,11 @@  proc dg-compile-aux-modules { args } {
     }
 }

+# Override gcc_{warning,error}_prefix with Fortran specific prefixes used
+# in gfortran_init to support dg-{warning,error} checks.
+set gcc_warning_prefix "\[Ww\]arning:"
+set gcc_error_prefix "(Fatal )?\[Ee\]rror:"
+
 # Main loop.
 gfortran-dg-runtest [lsort \
        [glob -nocomplain $srcdir/$subdir/*.\[fF\]{,90,95,03,08} ] ] "" $DEFAULT_FFLAGS