diff mbox series

[expand] Add const0 move checking for CLEAR_BY_PIECES optabs

Message ID 4dbb7f96-1ba1-4ab3-88d9-0e82de1b0124@linux.ibm.com
State Unresolved
Headers
Series [expand] Add const0 move checking for CLEAR_BY_PIECES optabs |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

HAO CHEN GUI Jan. 16, 2024, 2:04 a.m. UTC 
  Hi,
  This patch adds const0 move checking for CLEAR_BY_PIECES. The original
vec_duplicate handles duplicates of non-constant inputs. But 0 is a
constant. So even a platform doesn't support vec_duplicate, it could
still do clear by pieces if it supports const0 move by that mode.

  The test cases will be added in subsequent target specific patch.

  Bootstrapped and tested on x86 and powerpc64-linux BE and LE with no
regressions.

Thanks
Gui Haochen

ChangeLog
expand: Add const0 move checking for CLEAR_BY_PIECES optabs

vec_duplicate handles duplicates of non-constant inputs.  The 0 is a
constant.  So even a platform doesn't support vec_duplicate, it could
still do clear by pieces if it supports const0 move.  This patch adds
the checking.

gcc/
	* expr.cc (by_pieces_mode_supported_p): Add const0 move checking
	for CLEAR_BY_PIECES.

patch.diff

Comments

Jeff Law Jan. 17, 2024, 2:34 a.m. UTC | #1 
On 1/15/24 19:04, HAO CHEN GUI wrote:
> Hi,
>    This patch adds const0 move checking for CLEAR_BY_PIECES. The original
> vec_duplicate handles duplicates of non-constant inputs. But 0 is a
> constant. So even a platform doesn't support vec_duplicate, it could
> still do clear by pieces if it supports const0 move by that mode.
> 
>    The test cases will be added in subsequent target specific patch.
> 
>    Bootstrapped and tested on x86 and powerpc64-linux BE and LE with no
> regressions.
> 
> Thanks
> Gui Haochen
> 
> ChangeLog
> expand: Add const0 move checking for CLEAR_BY_PIECES optabs
> 
> vec_duplicate handles duplicates of non-constant inputs.  The 0 is a
> constant.  So even a platform doesn't support vec_duplicate, it could
> still do clear by pieces if it supports const0 move.  This patch adds
> the checking.
> 
> gcc/
> 	* expr.cc (by_pieces_mode_supported_p): Add const0 move checking
> 	for CLEAR_BY_PIECES.'
This doesn't look like it fixes a regression.  So it seems to me it 
ought to wait for gcc-15.

Jeff
diff mbox series

Patch

diff --git a/gcc/expr.cc b/gcc/expr.cc
index 34f5ff90a9f..cd960349a53 100644
--- a/gcc/expr.cc
+++ b/gcc/expr.cc
@@ -1006,14 +1006,21 @@  can_use_qi_vectors (by_pieces_operation op)
 static bool
 by_pieces_mode_supported_p (fixed_size_mode mode, by_pieces_operation op)
 {
-  if (optab_handler (mov_optab, mode) == CODE_FOR_nothing)
+  enum insn_code icode = optab_handler (mov_optab, mode);
+  if (icode == CODE_FOR_nothing)
     return false;

-  if ((op == SET_BY_PIECES || op == CLEAR_BY_PIECES)
+  if (op == SET_BY_PIECES
       && VECTOR_MODE_P (mode)
       && optab_handler (vec_duplicate_optab, mode) == CODE_FOR_nothing)
     return false;

+  if (op == CLEAR_BY_PIECES
+      && VECTOR_MODE_P (mode)
+      && optab_handler (vec_duplicate_optab, mode) == CODE_FOR_nothing
+      && !insn_operand_matches (icode, 1, CONST0_RTX (mode)))
+    return false;
+
   if (op == COMPARE_BY_PIECES
       && !can_compare_p (EQ, mode, ccp_jump))
     return false;