[pushed] fortran: Plug leak of associated_dummy memory. [PR108923]
Checks
Commit Message
Hello,
I have just pushed a for PR108923 (a memory leak).
It fixes the small reproducer that I pasted in bugzilla, and I have run
it through the fortran regression testsuite.
More details in the patch.
From 545a7d5da5fcc338e29c5241b574ac99d03f4454 Mon Sep 17 00:00:00 2001
From: Mikael Morin <mikael@gcc.gnu.org>
Date: Fri, 24 Feb 2023 22:11:17 +0100
Subject: [PATCH] fortran: Plug leak of associated_dummy memory. [PR108923]
This fixes a memory leak by accompanying the release of
gfc_actual_arglist elements' memory with a release of the
associated_dummy field memory (if allocated).
Actual argument copy is adjusted as well so that each copy can free
its field independently.
PR fortran/108923
gcc/fortran/ChangeLog:
* expr.cc (gfc_free_actual_arglist): Free associated_dummy
memory.
(gfc_copy_actual_arglist): Make a copy of the associated_dummy
field if it is set in the original element.
---
gcc/fortran/expr.cc | 7 +++++++
1 file changed, 7 insertions(+)
@@ -545,6 +545,7 @@ gfc_free_actual_arglist (gfc_actual_arglist *a1)
a2 = a1->next;
if (a1->expr)
gfc_free_expr (a1->expr);
+ free (a1->associated_dummy);
free (a1);
a1 = a2;
}
@@ -565,6 +566,12 @@ gfc_copy_actual_arglist (gfc_actual_arglist *p)
new_arg = gfc_get_actual_arglist ();
*new_arg = *p;
+ if (p->associated_dummy != NULL)
+ {
+ new_arg->associated_dummy = gfc_get_dummy_arg ();
+ *new_arg->associated_dummy = *p->associated_dummy;
+ }
+
new_arg->expr = gfc_copy_expr (p->expr);
new_arg->next = NULL;
--
2.39.1