diff mbox series

ira: update allocated_hardreg_p[] in improve_allocation() [PR110254]

Message ID 202aea78-0a16-c78b-206c-824ba7bab65d@linux.vnet.ibm.com
State Accepted
Headers
Series ira: update allocated_hardreg_p[] in improve_allocation() [PR110254] |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Surya Kumari Jangala July 21, 2023, 10:13 a.m. UTC 
  The improve_allocation() routine does not update the
allocated_hardreg_p[] array after an allocno is assigned a register.

If the register chosen in improve_allocation() is one that already has
been assigned to a conflicting allocno, then allocated_hardreg_p[]
already has the corresponding bit set to TRUE, so nothing needs to be
done.

But improve_allocation() can also choose a register that has not been
assigned to a conflicting allocno, and also has not been assigned to any
other allocno. In this case, allocated_hardreg_p[] has to be updated.

2023-07-21  Surya Kumari Jangala  <jskumari@linux.ibm.com>

gcc/
	PR rtl-optimization/PR110254
	* ira-color.cc (improve_allocation): Update array
---

Comments

Surya Kumari Jangala Aug. 1, 2023, 5:20 a.m. UTC | #1 
Ping

On 21/07/23 3:43 pm, Surya Kumari Jangala via Gcc-patches wrote:
> The improve_allocation() routine does not update the
> allocated_hardreg_p[] array after an allocno is assigned a register.
> 
> If the register chosen in improve_allocation() is one that already has
> been assigned to a conflicting allocno, then allocated_hardreg_p[]
> already has the corresponding bit set to TRUE, so nothing needs to be
> done.
> 
> But improve_allocation() can also choose a register that has not been
> assigned to a conflicting allocno, and also has not been assigned to any
> other allocno. In this case, allocated_hardreg_p[] has to be updated.
> 
> 2023-07-21  Surya Kumari Jangala  <jskumari@linux.ibm.com>
> 
> gcc/
> 	PR rtl-optimization/PR110254
> 	* ira-color.cc (improve_allocation): Update array
> ---
> 
> diff --git a/gcc/ira-color.cc b/gcc/ira-color.cc
> index 1fb2958bddd..5807d6d26f6 100644
> --- a/gcc/ira-color.cc
> +++ b/gcc/ira-color.cc
> @@ -3340,6 +3340,10 @@ improve_allocation (void)
>  	}
>        /* Assign the best chosen hard register to A.  */
>        ALLOCNO_HARD_REGNO (a) = best;
> +
> +      for (j = nregs - 1; j >= 0; j--)
> +	allocated_hardreg_p[best + j] = true;
> +
>        if (internal_flag_ira_verbose > 2 && ira_dump_file != NULL)
>  	fprintf (ira_dump_file, "Assigning %d to a%dr%d\n",
>  		 best, ALLOCNO_NUM (a), ALLOCNO_REGNO (a));
Vladimir Makarov Aug. 2, 2023, 1:23 p.m. UTC | #2 
On 8/1/23 01:20, Surya Kumari Jangala wrote:
> Ping
Sorry for delay with the answer. I was on vacation.
> On 21/07/23 3:43 pm, Surya Kumari Jangala via Gcc-patches wrote:
>> The improve_allocation() routine does not update the
>> allocated_hardreg_p[] array after an allocno is assigned a register.
>>
>> If the register chosen in improve_allocation() is one that already has
>> been assigned to a conflicting allocno, then allocated_hardreg_p[]
>> already has the corresponding bit set to TRUE, so nothing needs to be
>> done.
>>
>> But improve_allocation() can also choose a register that has not been
>> assigned to a conflicting allocno, and also has not been assigned to any
>> other allocno. In this case, allocated_hardreg_p[] has to be updated.
The patch is OK for me.  Thank you for finding and fixing this issue.
>> 2023-07-21  Surya Kumari Jangala  <jskumari@linux.ibm.com>
>>
>> gcc/
>> 	PR rtl-optimization/PR110254
>> 	* ira-color.cc (improve_allocation): Update array

I guess you missed the next line in the changelog.  I suspect it should 
be "Update array allocated_hard_reg_p."

Please, fix it before committing the patch.

>> ---
>>
>> diff --git a/gcc/ira-color.cc b/gcc/ira-color.cc
>> index 1fb2958bddd..5807d6d26f6 100644
>> --- a/gcc/ira-color.cc
>> +++ b/gcc/ira-color.cc
>> @@ -3340,6 +3340,10 @@ improve_allocation (void)
>>   	}
>>         /* Assign the best chosen hard register to A.  */
>>         ALLOCNO_HARD_REGNO (a) = best;
>> +
>> +      for (j = nregs - 1; j >= 0; j--)
>> +	allocated_hardreg_p[best + j] = true;
>> +
>>         if (internal_flag_ira_verbose > 2 && ira_dump_file != NULL)
>>   	fprintf (ira_dump_file, "Assigning %d to a%dr%d\n",
>>   		 best, ALLOCNO_NUM (a), ALLOCNO_REGNO (a));
Peter Bergner Aug. 18, 2023, 4:51 p.m. UTC | #3 
On 8/2/23 8:23 AM, Vladimir Makarov wrote:
>>> gcc/
>>>     PR rtl-optimization/PR110254
>>>     * ira-color.cc (improve_allocation): Update array
> 
> I guess you missed the next line in the changelog.  I suspect it should be "Update array allocated_hard_reg_p."
> 
> Please, fix it before committing the patch.

Is this a fix we want backported?

Peter
diff mbox series

Patch

diff --git a/gcc/ira-color.cc b/gcc/ira-color.cc
index 1fb2958bddd..5807d6d26f6 100644
--- a/gcc/ira-color.cc
+++ b/gcc/ira-color.cc
@@ -3340,6 +3340,10 @@  improve_allocation (void)
 	}
       /* Assign the best chosen hard register to A.  */
       ALLOCNO_HARD_REGNO (a) = best;
+
+      for (j = nregs - 1; j >= 0; j--)
+	allocated_hardreg_p[best + j] = true;
+
       if (internal_flag_ira_verbose > 2 && ira_dump_file != NULL)
 	fprintf (ira_dump_file, "Assigning %d to a%dr%d\n",
 		 best, ALLOCNO_NUM (a), ALLOCNO_REGNO (a));