| Message ID | 20240304030307.12335-1-guojie@loongson.cn |
|---|---|
| State | Accepted |
| Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id
ju23csp1190526dyc;
Sun, 3 Mar 2024 19:04:40 -0800 (PST)
X-Forwarded-Encrypted: i=3;
AJvYcCV/7HAYmYdhVixTWdC3bQAizzoxP6dr9OvJCYfwHNgyJ1AlefgI7tzQFtXFk+hYgZZSWmJocIhqsbNbr9M7AU63jltVfA==
X-Google-Smtp-Source:
AGHT+IHERxegGpi4BvWtYxZqVFYfovgt1So6KJVvpxvql/BNXKsiMlo9O84vhboHYaEDYbgRX+7D
X-Received: by 2002:a05:620a:4d16:b0:788:1a77:ea5f with SMTP id
wa22-20020a05620a4d1600b007881a77ea5fmr5483180qkn.20.1709521480009;
Sun, 03 Mar 2024 19:04:40 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1709521479; cv=pass;
d=google.com; s=arc-20160816;
b=JL24hUC5/dwveY7LHagDj+XdpqlpK8k6Wfe5ZS2p1axKX+5zr3MO/67Q4ydfAUr40y
PwgbO+dC6b0zBElShwC0dcaHrwtyxg/Fu4w1jU97/w2Dm2J3mVJ4InYQbhIUrAFOkjYx
f6486AO2bK0ftxSVUAY3rwX/d+bR1O8hnstiDAm6EM5zDb35F4Gb9vdlYE388VQKRjKp
n//8vHXFKn2cel/Z56WkNyMglPvrInbtNYcXQOxGw0bT/bypUpGw5/THQTgvBLDnAc68
eOjmoPLWWrjlKnzt9rm/5uJAIzga4/vrzvPPWdjP+9/G2laMIs9SOpr06SPq/0s/Oq0n
64Cg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=errors-to:list-subscribe:list-help:list-post:list-archive
:list-unsubscribe:list-id:precedence:content-transfer-encoding
:mime-version:message-id:date:subject:cc:to:from:arc-filter
:dmarc-filter:delivered-to;
bh=Kj8+MyiqOd/4Fjhk15Yob1NqzoiPY1ph843CzUJFV3M=;
fh=FCC/Zx3UOwReG8Kz3H/ln+uGOf+6klnWwvVPHAnfABw=;
b=IWecmMjDGBc9YZ0W97Nm3/t9HXIVXtM8GZFrmPMnlB09V948Z3EuhMjFHlwmejOknG
om9Icd54vIUSmTgQfijXCiiTT217dI9INXKKfkO6vZKM0+Ix9cRIgrS/un+ktY9HrzxA
Wf57vS30zNtx07b8tkB59GgfSy9qeB7NovGluO/6swn+oreuX/LWmxJ2vxqZ2BA+ty40
J2/T/Q2MmrxhhcIacaVxXK4vDy7BZAyTETpUJyz6+es6EANTnXZJ0kCF899eBrUBoK3j
VjxJ1/DgSSteg8kSbBGsJpU0Xz3HqZ1c7azrWwwJMpnIBcl5FqBMRnsGykHx17Bd7oeM
rrSg==;
dara=google.com
ARC-Authentication-Results: i=2; mx.google.com;
arc=pass (i=1);
spf=pass (google.com: domain of
gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates
2620:52:3:1:0:246e:9693:128c as permitted sender)
smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"
Received: from server2.sourceware.org (server2.sourceware.org.
[2620:52:3:1:0:246e:9693:128c])
by mx.google.com with ESMTPS id
b6-20020a05620a0f8600b00787e58dc49dsi8397425qkn.200.2024.03.03.19.04.39
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 03 Mar 2024 19:04:39 -0800 (PST)
Received-SPF: pass (google.com: domain of
gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates
2620:52:3:1:0:246e:9693:128c as permitted sender)
client-ip=2620:52:3:1:0:246e:9693:128c;
Authentication-Results: mx.google.com;
arc=pass (i=1);
spf=pass (google.com: domain of
gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates
2620:52:3:1:0:246e:9693:128c as permitted sender)
smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"
Received: from server2.sourceware.org (localhost [IPv6:::1])
by sourceware.org (Postfix) with ESMTP id 97708385840B
for <ouuuleilei@gmail.com>; Mon, 4 Mar 2024 03:04:39 +0000 (GMT)
X-Original-To: gcc-patches@gcc.gnu.org
Delivered-To: gcc-patches@gcc.gnu.org
Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163])
by sourceware.org (Postfix) with ESMTP id 49A753858D28
for <gcc-patches@gcc.gnu.org>; Mon, 4 Mar 2024 03:03:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 49A753858D28
Authentication-Results: sourceware.org;
dmarc=none (p=none dis=none) header.from=loongson.cn
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 49A753858D28
Authentication-Results: server2.sourceware.org;
arc=none smtp.remote-ip=114.242.206.163
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709521441; cv=none;
b=r+S3WegUvFkQhzO21TG0IXDQE+NIJggrqBo37a4X16RHX4RXtcqj2V59JqQthGanx4dxgRGYZnoLABozIdn3PHzopGKpVPtHstUJ02buWmEs4Q3xtqf57I/Hblccf6yd7Q3Mrn5KWM/M6u8LCe7KJLujpP0oMiJr6yg+7kmf8o4=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
t=1709521441; c=relaxed/simple;
bh=s5YyYHYStHqdLP37/mk3yGk3yV/KaRxFXxrZK11aSRA=;
h=From:To:Subject:Date:Message-Id:MIME-Version;
b=PCJXPjwnhx2B7/btReZamxMUaDly1OR1Hd0Rbq5pUBF8XqvMQsDvb/NfH2g/7y/fZtKGbf4uxAg89DWAYFmwN0DXrk0O4IdpIHpryG9Xt1pz2AQjSTmMXKTbIN1s2O2JnZfdV8irQkaRuyZ6KbpWn4VO529wkAOUQPhnYpb/hn4=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from loongson.cn (unknown [10.20.4.191])
by gateway (Coremail) with SMTP id _____8BxefAaOuVlafETAA--.51343S3;
Mon, 04 Mar 2024 11:03:54 +0800 (CST)
Received: from loongson-pc.loongson.cn (unknown [10.20.4.191])
by localhost.localdomain (Coremail) with SMTP id
AQAAf8DxDc8HOuVlM4RNAA--.9335S4;
Mon, 04 Mar 2024 11:03:51 +0800 (CST)
From: Guo Jie <guojie@loongson.cn>
To: gcc-patches@gcc.gnu.org
Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, i@xen0n.name,
xry111@xry111.site, Guo Jie <guojie@loongson.cn>
Subject: [PATCH] LoongArch: Fix inconsistent description in
*sge<u>_<X:mode><GPR:mode>
Date: Mon, 4 Mar 2024 11:03:07 +0800
Message-Id: <20240304030307.12335-1-guojie@loongson.cn>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-CM-TRANSID: AQAAf8DxDc8HOuVlM4RNAA--.9335S4
X-CM-SenderInfo: xjxryx3h6o00pqjv00gofq/
X-Coremail-Antispam: 1Uk129KBj9xXoWrtFy3XFWkCFy3GF48GF43XFc_yoWDGrb_Ww
13ta1UKr4UWayktwsF9F15tryUXa18XFnxZFn3Krs2vF1fJr13Cry8X3Z8ZryY93yDJFsx
ArWFyrnxCrnrtosvyTuYvTs0mTUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUj1kv1TuYvT
s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI
cSsGvfJTRUUUb7kYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20x
vaj40_Wr0E3s1l1IIY67AEw4v_JrI_Jryl8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS
w2x7M28EF7xvwVC0I7IYx2IY67AKxVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV
WUJVW8JwA2z4x0Y4vEx4A2jsIE14v26F4j6r4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_
Gr1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc
02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAF
wI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28IcxkI7V
AKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCj
r7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6x
IIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAI
w20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x
0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxU25EfUUUUU
X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, GIT_PATCH_0,
KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP,
T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
<mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
<mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1792563195142369985
X-GMAIL-MSGID: 1792563195142369985
|
| Series |
LoongArch: Fix inconsistent description in *sge<u>_<X:mode><GPR:mode>
|
|
Checks
| Context | Check | Description |
|---|---|---|
| snail/gcc-patch-check | success | Github commit url |
Commit Message
Guo Jie
March 4, 2024, 3:03 a.m. UTC
The constraint of op[1] is inconsistent with the output template. gcc/ChangeLog: * config/loongarch/loongarch.md (define_insn "*sge<u>_<X:mode><GPR:mode>"): Fix inconsistency error. --- gcc/config/loongarch/loongarch.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Mon, 2024-03-04 at 11:03 +0800, Guo Jie wrote: > The constraint of op[1] is inconsistent with the output template. > > gcc/ChangeLog: > > * config/loongarch/loongarch.md > (define_insn "*sge<u>_<X:mode><GPR:mode>"): Fix inconsistency > error. > > --- > gcc/config/loongarch/loongarch.md | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/config/loongarch/loongarch.md > b/gcc/config/loongarch/loongarch.md > index f3b5c641fce..2d25374bdc9 100644 > --- a/gcc/config/loongarch/loongarch.md > +++ b/gcc/config/loongarch/loongarch.md > @@ -3357,10 +3357,10 @@ (define_insn "*sgt<u>_<X:mode><GPR:mode>" > > (define_insn "*sge<u>_<X:mode><GPR:mode>" > [(set (match_operand:GPR 0 "register_operand" "=r") > - (any_ge:GPR (match_operand:X 1 "register_operand" "r") > + (any_ge:GPR (match_operand:X 1 "arith_operand" "rI") > (const_int 1)))] No, arith_operand is just register_operand or const_imm12_operand, but comparing a const_imm12_operand with (const_int 1) should be folded into a constant (even at -O0, AFAIK). So allowing const_imm12_operand here makes no benefit. > "" > - "slt<u>i\t%0,%.,%1" > + "slt<u>%i1\t%0,%.,%1" > [(set_attr "type" "slt") > (set_attr "mode" "<X:MODE>")]) >
diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md index f3b5c641fce..2d25374bdc9 100644 --- a/gcc/config/loongarch/loongarch.md +++ b/gcc/config/loongarch/loongarch.md @@ -3357,10 +3357,10 @@ (define_insn "*sgt<u>_<X:mode><GPR:mode>" (define_insn "*sge<u>_<X:mode><GPR:mode>" [(set (match_operand:GPR 0 "register_operand" "=r") - (any_ge:GPR (match_operand:X 1 "register_operand" "r") + (any_ge:GPR (match_operand:X 1 "arith_operand" "rI") (const_int 1)))] "" - "slt<u>i\t%0,%.,%1" + "slt<u>%i1\t%0,%.,%1" [(set_attr "type" "slt") (set_attr "mode" "<X:MODE>")])