From patchwork Thu Feb 15 15:20:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ken Matsui X-Patchwork-Id: 201541 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:b825:b0:106:860b:bbdd with SMTP id da37csp473086dyb; Thu, 15 Feb 2024 07:23:15 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWhKB13sAXPTN41JrdjYgD6+/StjZpK2o7+gCuiOp82u/pxOY/m/RUaXDc7PR4W3FHbRXsaXLe2zk99xsX5eAE7+V33Bg== X-Google-Smtp-Source: AGHT+IHz4A6FFp5wg8TaTW3TpOnN4v8zWMeZ4p3PwFX9tLjYiKg2XsvQA+p9CCvvpFVAFG6wpB/T X-Received: by 2002:a5b:60c:0:b0:dc6:9399:849e with SMTP id d12-20020a5b060c000000b00dc69399849emr1940001ybq.11.1708010594919; Thu, 15 Feb 2024 07:23:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708010594; cv=pass; d=google.com; s=arc-20160816; b=wSJQB5emhZAFi/ggXTQPqNwvI4TQYRFjl1jq4SJzsEzu1NHm6SufEQyGOnQDDVcae4 ZTKKExjWXRM0meltIpMfVV7ILbj45zy734mQROucCkJoKFvocmyJSZ1sgZRcQ3buGejJ 5MNZJbqDI4n0AXR3/fJGarcLTXGaowOamhDhifRGoQw+bpvSTZsvuJ2EnhFvQtASrJKE kk78BENHfBUusN4CJDjivD8uqKzyFmC9uJNdBt6nNH1G7q9ZDJLtoC5cN/P9z1tjkMLp 1zaxEq2dDGTW4FBL1merNl1AQNM9EUSQd3imdtxVh66efMLsqp9sTeRx6TjL3ITVSbVv ZuTQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=dkEAshbr4K+pXGJo/ZDuCKfVD6NXufREzwHlrx1rfhw=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=dQr8QrwcfaXuVB9x/qXdKCq6B873NQqCxAxGNGxVi7L9DC3+U6MYKiDBNlmvlHOiP/ pK1rMKdVChtf2McjT4UrG8h5YXt80pQfNbhbCC1oBTzToKgS9JxGWDyMCTEHbksbNvkS fIWU/AVYltyslvfz0N2RFsnm8lQqn7VRxrAxh+Dm4lcchLj+1FO+dim32JR3fnQns5Kh cCgTlGLkzyPMEisT9MWm/KFr5wa3nMsL8m7sy0THVViudvqNl1rWbCBVu66QxI28rmIp ikV1avXR12S1vvPdMRrQG0ITZNJZOWwqTa/slk6Pwfc1Ii4fMO8mjoQ6Li6HhF5ovbhG q9Bw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=H65ZGruE; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id c9-20020a05620a200900b007834b7bf527si1731732qka.351.2024.02.15.07.23.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 07:23:14 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=H65ZGruE; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0CEBC386C5A1 for ; Thu, 15 Feb 2024 15:23:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0CEBC386C5A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1708010594; bh=dkEAshbr4K+pXGJo/ZDuCKfVD6NXufREzwHlrx1rfhw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=H65ZGruEy5KcLUInf4DrbdS9Ix3ri5LEqg4DNAaaYCZfPP34cGKpvuZYn5/U3DtKh Ih8Cgm58/hN7zfLvuTKFb9kF3aZOQTxUqsGyu8LEO9T76X574PBVk03ShkxK1Th7We bOOcl7vAPjEerhEvdA0cWodbFTndfgyw1lO5yHag= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-00641c01.pphosted.com (mx0b-00641c01.pphosted.com [205.220.177.146]) by sourceware.org (Postfix) with ESMTPS id 5F017384CBBA; Thu, 15 Feb 2024 15:20:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F017384CBBA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5F017384CBBA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.177.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708010460; cv=none; b=aIRhtd/cbp1ThvlzW3O6ptjpOtCa2qGlaMa5o1eyDph1TAnKdsONSVurutSZAhUbsB/c2xWNx4P/8S9a7DiBu1Uc7teZNLdRgr+xouygsKJ8jmEuuxGA7fl88Nh+rDv4o/0GrmYD6ASEX5g50+7N/HJLGhryz43PUxmns7MsTuQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708010460; c=relaxed/simple; bh=t2jAdqwW6QGJBGEY9KIWY7by0tGyR+EA5NyovQUG/HQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=gvqRuUZdr40yeKu85DvmSR8qUnOQM25Gx2Jm2LvQDI5RHO+Ul26v5unP2amInYIX9FB5JTjNoae2PDFKisjXi17K7NlUryLregydRtDjy1WNh+3Nq5jL/hW8tn/k1cBO05xoQ3X3NGTVye7VYPDLI3fCx1a5JK+QArI0r2Y5vzo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247478.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41FFJlk7022836; Thu, 15 Feb 2024 15:20:57 GMT Received: from mxout26.s.uw.edu (mxout26.s.uw.edu [140.142.234.176]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3w94rewhhp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 15:20:56 +0000 Received: from smtp.washington.edu (smtp.washington.edu [140.142.234.157]) by mxout26.s.uw.edu (8.14.4+UW20.07/8.14.4+UW24.02) with ESMTP id 41FFKl7V010514 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2024 07:20:47 -0800 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.154.74.143]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW24.02) with ESMTPSA id 41FFKkgs029956 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 07:20:47 -0800 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui Subject: [PATCH v5 08/14] libstdc++: Optimize std::add_lvalue_reference compilation performance Date: Thu, 15 Feb 2024 07:20:31 -0800 Message-ID: <20240215152037.720162-8-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215152037.720162-1-kmatsui@gcc.gnu.org> References: <20240215045258.3025806-1-kmatsui@gcc.gnu.org> <20240215152037.720162-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: qu4gG4nk91X7QzC-jiFA6O3wivGYaogT X-Proofpoint-GUID: qu4gG4nk91X7QzC-jiFA6O3wivGYaogT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-15_14,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 bulkscore=0 spamscore=0 mlxlogscore=695 lowpriorityscore=0 adultscore=0 suspectscore=0 clxscore=1034 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402150123 X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790969326088288499 X-GMAIL-MSGID: 1790978917802816614 This patch optimizes the compilation performance of std::add_lvalue_reference by dispatching to the new __add_lvalue_reference built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (add_lvalue_reference): Use __add_lvalue_reference built-in trait. (__add_lvalue_reference_helper): Likewise. Signed-off-by: Ken Matsui --- libstdc++-v3/include/std/type_traits | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 2e1cc1c1d5f..1f4e6db72f4 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -1129,6 +1129,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION }; /// @cond undocumented +#if _GLIBCXX_USE_BUILTIN_TRAIT(__add_lvalue_reference) + template + struct __add_lvalue_reference_helper + { using type = __add_lvalue_reference(_Tp); }; +#else template struct __add_lvalue_reference_helper { using type = _Tp; }; @@ -1136,6 +1141,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template struct __add_lvalue_reference_helper<_Tp, __void_t<_Tp&>> { using type = _Tp&; }; +#endif template using __add_lval_ref_t = typename __add_lvalue_reference_helper<_Tp>::type; @@ -1703,9 +1709,15 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION #endif /// add_lvalue_reference +#if _GLIBCXX_USE_BUILTIN_TRAIT(__add_lvalue_reference) + template + struct add_lvalue_reference + { using type = __add_lvalue_reference(_Tp); }; +#else template struct add_lvalue_reference { using type = __add_lval_ref_t<_Tp>; }; +#endif /// add_rvalue_reference template