From patchwork Thu Feb 15 15:20:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ken Matsui X-Patchwork-Id: 201548 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:b825:b0:106:860b:bbdd with SMTP id da37csp474189dyb; Thu, 15 Feb 2024 07:24:59 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVN+OmxpAvSHP4a0H7XgiJIUgwntEve0Q0JQTNCZjZFzjuZns9CxpAH84ShAIhd7p4AG2FL5DarX9kMuNp+iIJ2E648Eg== X-Google-Smtp-Source: AGHT+IF/nl0Eh5qvZ2pfTZmfoKBE59R1Is6LCnafR5TGpVF3HV0eVR4Jz6gaXGtXbc/wC3FyfoSG X-Received: by 2002:a05:622a:1048:b0:42b:ff78:2033 with SMTP id f8-20020a05622a104800b0042bff782033mr2607102qte.56.1708010699306; Thu, 15 Feb 2024 07:24:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708010699; cv=pass; d=google.com; s=arc-20160816; b=Drk4nweLvvtgd7cyWpJ1iyxC+n8M8gBAqWIvOJHcoFena/LuMcsbLMkILKQkSJ/9ZH vpRt6/F4D5sLPpO8S2A/NJpwsiQvxK7EFE2pI5S5yemtkfrl/JmXR1fWEN6svpKIGpFJ W53qHmaQI9LJGvW9BaEm7hZrhsgUNZtNFYFzNRjfwnYtE6hP5mxq2r9b65zwnzAZ7ag4 ZRHGkj3VLvN283A2GbpCdGBBEgy/R+D9J07GQih6um1WzVv5cvMq0GrZZvNUeDmnaa06 2XC1zXBXHWStGnfN8wD81fN1q2jQSjeNeBp5zOBOpo2yE8kTiuIMbGU7bjD2Y+fTrXAy Jfdg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=piDE3AgxzrW0dXa2e3uQh2wEapv7CFxKuS7kgH2unj0=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=rzmkRoGWPU45pd2VqkXQHYpl4ex/L5qPiCFzk07WYGiuNVIhxpgGiL13eN1bZzd37f BydDUz2vrE9tl++Nsw9wO3C819cLiGPOF0Aks0ncDwC1BjfUUtLVwa/UwQahhOSnpBiZ TtB6VjbjswQOhQELWCtDbS2JSH8NA7AtyGMFQYAh2y386INgt1++naq6FtiiGCuHCXXr QL1O4bpI1dVi9y/4LFl1L9beNE7CvHZQdJaAfeJ3vTcIfMcOBGS6Tp7aXi74SAhCFyJK yTjxb+ofiwmZcus1mvXRbQiz2uCsLM+wdJiKDskSnBldFZz41LF8ZvovTauf7+esvGUc L4mg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="ZsjLgp/C"; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id o13-20020a05622a138d00b0042c28da72e2si1671023qtk.341.2024.02.15.07.24.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 07:24:59 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="ZsjLgp/C"; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A5E2F384CBAD for ; Thu, 15 Feb 2024 15:24:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A5E2F384CBAD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1708010698; bh=piDE3AgxzrW0dXa2e3uQh2wEapv7CFxKuS7kgH2unj0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZsjLgp/C7NRDyTwQ+/HJxuK3FKdZM32ObD+5y3+VQ5Fn/rXpKSbagO1N0YKvsTfil VDZlgm5QCqhVC54hLavCtuhboKAw1Md7LN+w24YsVDnELy037XhsLdb+xqLrvRp6AD OzrAxVobDzl3FLtWHBsOAJJ8ul7/XFRXLfaqgxhY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-00641c01.pphosted.com (mx0a-00641c01.pphosted.com [205.220.165.146]) by sourceware.org (Postfix) with ESMTPS id A135B3865C24; Thu, 15 Feb 2024 15:21:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A135B3865C24 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A135B3865C24 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.165.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708010476; cv=none; b=DngvT8khl0FXSzMHMLs5oruch5FlCjQc1m9jwnfpHNR+n9WBjrjrtJQPw3QMtt8ydxueuVGZryBtMaOy2iRmweXp6dS4ujgBH0gU52/FohyLCwO/56PH5qzxrDTiT0YZleFuRo/Ho3YXLyFLFcF/fASXHxsUpeMoR0ykEPNwgqQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708010476; c=relaxed/simple; bh=mgSd9TEezsOin328Daikj7GhRV0O1ne8sDSsrKJn60A=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=jJlLmkbQdatN9RAA4Fz0VFbhHimG+zobtaOdemQwO/Du87gCWMdEThW/p2gHiFMqND/BUnQP/3v3YtWqljEI9h5+NcWgBwxYs+t8hWWg2+GkrdwDqbxAlW28MvHJK/QTrw++UT9UPGRJd5n/vUPnd393yEugXVbBGWNAI7ZrbOA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247470.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41FFDcBo025439; Thu, 15 Feb 2024 15:21:08 GMT Received: from mxout23.cac.washington.edu (mxout23.cac.washington.edu [140.142.32.140]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3w97csc6f7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 15:21:08 +0000 Received: from smtp.washington.edu (smtp.washington.edu [140.142.234.157]) by mxout23.cac.washington.edu (8.14.4+UW20.07/8.14.4+UW24.02) with ESMTP id 41FFKk5u025820 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2024 07:20:47 -0800 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.154.74.143]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW24.02) with ESMTPSA id 41FFKkgm029956 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 07:20:46 -0800 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui Subject: [PATCH v5 02/14] libstdc++: Optimize std::add_pointer compilation performance Date: Thu, 15 Feb 2024 07:20:25 -0800 Message-ID: <20240215152037.720162-2-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215152037.720162-1-kmatsui@gcc.gnu.org> References: <20240215045258.3025806-1-kmatsui@gcc.gnu.org> <20240215152037.720162-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 X-Proofpoint-GUID: ZJ9TnbQ4ShoLWOmuQjtzp7Mr4kPwbeUW X-Proofpoint-ORIG-GUID: ZJ9TnbQ4ShoLWOmuQjtzp7Mr4kPwbeUW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-15_14,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 mlxlogscore=502 clxscore=1034 priorityscore=1501 mlxscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402150123 X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790979027175991111 X-GMAIL-MSGID: 1790979027175991111 This patch optimizes the compilation performance of std::add_pointer by dispatching to the new __add_pointer built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (add_pointer): Use __add_pointer built-in trait. Signed-off-by: Ken Matsui --- libstdc++-v3/include/std/type_traits | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 21402fd8c13..3bde7cb8ba3 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -2121,6 +2121,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION { }; #endif + /// add_pointer +#if _GLIBCXX_USE_BUILTIN_TRAIT(__add_pointer) + template + struct add_pointer + { using type = __add_pointer(_Tp); }; +#else template struct __add_pointer_helper { using type = _Tp; }; @@ -2129,7 +2135,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION struct __add_pointer_helper<_Tp, __void_t<_Tp*>> { using type = _Tp*; }; - /// add_pointer template struct add_pointer : public __add_pointer_helper<_Tp> @@ -2142,6 +2147,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template struct add_pointer<_Tp&&> { using type = _Tp*; }; +#endif #if __cplusplus > 201103L /// Alias template for remove_pointer