From patchwork Thu Feb 15 15:20:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ken Matsui X-Patchwork-Id: 201552 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:b825:b0:106:860b:bbdd with SMTP id da37csp475551dyb; Thu, 15 Feb 2024 07:27:15 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU7BZ/Xg9UNAFbEAuGLEKJK59fgbWbF+8fcfXaFQCRxFdRPJRckSZGM9dJVycqodIiCsCDaH9Ba9uxSClvFen37dYQzrQ== X-Google-Smtp-Source: AGHT+IHjNCMMYxJZ1ftEBDIBbjP5JUmR+wU+vamecvJBtazqxfdQ+bIqoqaaV+GQy5rW/mq9Iy0C X-Received: by 2002:a05:622a:3cb:b0:42d:bf4f:8453 with SMTP id k11-20020a05622a03cb00b0042dbf4f8453mr2563065qtx.58.1708010835342; Thu, 15 Feb 2024 07:27:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708010835; cv=pass; d=google.com; s=arc-20160816; b=OnaNbtLdVGjYAEDhqUHgeUOcX5AUsMhkfjWVre2AM8uv0hQNElf4N9xC2X7TyyI6DD Frkx+9fzqoEF4WuQOEHyY6+8KvOrQ4e/2dwoMhxB4YH2VkAo4RwDplDDQQfURiYcS8k3 bgpTaQnL5AbeDdtO+uFAuacvlm8RFpeTDOXvK71KEWDeOP4vYhwjZniHYARE5OKqWzkw zOaV6vsvroBufozK0qkpeS5d6ZyWVzr+RLrKwNI712mgyS5kpnGE3RxCX6SITjanwHHu yb9l4qePBRusI+NcaKHtjVdYft46phRnrqYDisCRlo3E2m9z4b64sVsGvKoxrqDOOP2J Cm7w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=6yjO2rxQpBvyYdXJQcSBJjI76ovn/UO6OSWCf7wn8nc=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=MFn/gAshKEu91zcpF6pEOum4GX6gT53X09pUvJZqRDexUogrXvXCyk0OdxbyPLf82x x85e3rX4R5SJ9DeMle//9QiCGwdqVYNEgm9g6bRAcpnDG2+XtfCe9IyVi2lMNH1MSCYP pheaGk7wuZD++yfjGcy1PLe078pRGCh3E5fhET8yUkRAFdE5NiGPsV7BuuK6i7u/7NJ7 eXMlq8MdXsrOMe4LcoQhF9zGA7qtIhsYth2EArJI4dk895u9vQf/cgvbHaqAlE+Aw1u6 A01+Ll4MBQr6MhozEVoMxEFhtAAHVYDwkMwdaMyzbIuMFr5gVVm0erS9Neiuu4IDDEny uBDg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=kgxhXmV1; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id a4-20020a05620a102400b0078732d2a79fsi1680588qkk.280.2024.02.15.07.27.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 07:27:15 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=kgxhXmV1; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F2296386C582 for ; Thu, 15 Feb 2024 15:27:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F2296386C582 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1708010835; bh=6yjO2rxQpBvyYdXJQcSBJjI76ovn/UO6OSWCf7wn8nc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kgxhXmV10KlkLl6MZdHcRQRmrZl0/b2TrvFfuZPgAzjbblB3pSn9SFNCkcG33GIjP v3g6kablSQ2QFiu4ndaXfTbiYMyiERcJLD98VCskCrBXh0pXoSd6lT7Xw0uZtBj7uJ 8GDnOhFfU4shiCf4RxMcO3cioz4bU0EAiNWfIk5U= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-00641c01.pphosted.com (mx0b-00641c01.pphosted.com [205.220.177.146]) by sourceware.org (Postfix) with ESMTPS id 01B4B38618BE; Thu, 15 Feb 2024 15:21:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01B4B38618BE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 01B4B38618BE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.177.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708010476; cv=none; b=txChqg3jt+WsExPA/co9irlC0UMpbOuVtZo0zC2hg2xfmRwQTbKJ8/wJcn4b5DV735UGDCqlPu+1aAHO4MtDVbb6ed3hDERglKbK0HHT2xCCBu+MQHqrQidDSbAMd8cyUfRrkRiBCI65Ez6JSSbFh/p9iQO7ZvUDVeZRoVzcaXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708010476; c=relaxed/simple; bh=Lvl+FT8IvryzLxkGcHzhKpdBdzMobGciTXizVO8O2UQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=kNXMedOIlmZpouuG+l4j6d3t1Qbn+uEwNrFRIZu6VbheuodXfkveZyIJBpq+xk14AUIlbI+MIoIql1+Ex3rueEdZDG+ONKDbeEF3c7Zb1S5XBELPt22tBGZGkeuDqqfulc+6zd9Bhfu5r6FioXELRxNrgWTwYC0yPzKzUJFdudw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247477.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41FFL5e0008929; Thu, 15 Feb 2024 15:21:08 GMT Received: from mxout23.cac.washington.edu (mxout23.cac.washington.edu [140.142.32.140]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3w97y0uq7n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 15:21:08 +0000 Received: from smtp.washington.edu (smtp.washington.edu [140.142.234.157]) by mxout23.cac.washington.edu (8.14.4+UW20.07/8.14.4+UW24.02) with ESMTP id 41FFKlqP025822 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2024 07:20:47 -0800 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.154.74.143]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW24.02) with ESMTPSA id 41FFKkgu029956 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 07:20:47 -0800 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui Subject: [PATCH v5 10/14] libstdc++: Optimize std::add_rvalue_reference compilation performance Date: Thu, 15 Feb 2024 07:20:33 -0800 Message-ID: <20240215152037.720162-10-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215152037.720162-1-kmatsui@gcc.gnu.org> References: <20240215045258.3025806-1-kmatsui@gcc.gnu.org> <20240215152037.720162-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: 3Czf2xgH_6DtH0ak5vh6HfHWRQfL79_D X-Proofpoint-GUID: 3Czf2xgH_6DtH0ak5vh6HfHWRQfL79_D X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-15_14,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 adultscore=0 mlxlogscore=598 malwarescore=0 bulkscore=0 priorityscore=1501 suspectscore=0 spamscore=0 mlxscore=0 clxscore=1034 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402150123 X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790969304001046850 X-GMAIL-MSGID: 1790979169510150067 This patch optimizes the compilation performance of std::add_rvalue_reference by dispatching to the new __add_rvalue_reference built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (add_rvalue_reference): Use __add_rvalue_reference built-in trait. (__add_rvalue_reference_helper): Likewise. Signed-off-by: Ken Matsui --- libstdc++-v3/include/std/type_traits | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 1f4e6db72f4..219d36fabba 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -1157,6 +1157,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION }; /// @cond undocumented +#if _GLIBCXX_USE_BUILTIN_TRAIT(__add_rvalue_reference) + template + struct __add_rvalue_reference_helper + { using type = __add_rvalue_reference(_Tp); }; +#else template struct __add_rvalue_reference_helper { using type = _Tp; }; @@ -1164,6 +1169,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template struct __add_rvalue_reference_helper<_Tp, __void_t<_Tp&&>> { using type = _Tp&&; }; +#endif template using __add_rval_ref_t = typename __add_rvalue_reference_helper<_Tp>::type; @@ -1720,9 +1726,15 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION #endif /// add_rvalue_reference +#if _GLIBCXX_USE_BUILTIN_TRAIT(__add_rvalue_reference) + template + struct add_rvalue_reference + { using type = __add_rvalue_reference(_Tp); }; +#else template struct add_rvalue_reference { using type = __add_rval_ref_t<_Tp>; }; +#endif #if __cplusplus > 201103L /// Alias template for remove_reference