From patchwork Thu Feb 15 12:48:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ken Matsui X-Patchwork-Id: 201446 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:b825:b0:106:860b:bbdd with SMTP id da37csp372892dyb; Thu, 15 Feb 2024 04:50:26 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUE2CAZxJx7WtX56v8vQnrecSQpzK4wT6ex6+CAo0JhTt6PLwoSRqgEjUXL8eYm8XgXPBNdh/wF4eQBlx4jbuzjtYlNrg== X-Google-Smtp-Source: AGHT+IHnE74FoP1ziiEIjkZ5/EQVgDKJoqvtOAmQv85sUFVI4VgMdYiR63YtLXO7/kCJDzustglP X-Received: by 2002:a05:6808:6408:b0:3c0:3e52:d145 with SMTP id fg8-20020a056808640800b003c03e52d145mr1694390oib.25.1708001426541; Thu, 15 Feb 2024 04:50:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708001426; cv=pass; d=google.com; s=arc-20160816; b=v8VYykxnZ9oWk4NPbJLUUqUYCY4B9ECnMrTOXRdGLlmjOlXJcGy44Pv4TM2MdgHxKp gHAnkekAfhRtDz3jHALoLivshIlJuVVr/cpdkgqmkmfUss5kuj+BOjdS8nJZs3AYW6Bu 3o4gkZihmp5XvOyjvHgpljUdVrLg4NlXj2F5nL9s3xsPSoypQVaq05RSYqjttNXN4KVV ms810+03u6qBv6N0KX6gjuCSN+FItwJ4YOCYH8kzm6gOEsqBWu6+XVpAt0QmMgA7c17R cCM6RTB4nLNKYdmAhUXddwPUk28Oivv5vkbST73fmbL+t0QUJkpICEgu+ldOuA8/0AAW tYuw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=6yjO2rxQpBvyYdXJQcSBJjI76ovn/UO6OSWCf7wn8nc=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=xdKx0Bj2Z0Urhc3VufUoaOqPO8e+NwbJpb7yf7mtaNbjTu9m26q8Y6aiAnvgW3GeyO jgl92/p6sC6M6TGoq2K5+mkpSAopZKH3rPP9aHU1KuFlugEUOil9zHtHnvQOQX3T+LuP f3hfQYdONuE/0B46HM50D7hOaforzKf1UYyJbcHOfhJ0VYg7zT/0hJnMvwT8t2kB0XV6 SG0ZJuPCUm5ZQLB5uk4p18LSMoTTHyLx688OaKdpNRLW8vMpGaH41iIbAIsJFNSn3lOo LLKGKsOjH+GOco2vqQFWy0Y2jp7qdjcnvQ0bUs4NZNqmTucj4D+nce8TWVoF0e+jX7ES RskQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Wnpwch4q; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id kc7-20020a056214410700b0068ceaf50961si1344695qvb.208.2024.02.15.04.50.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 04:50:26 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Wnpwch4q; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 15902384CBB7 for ; Thu, 15 Feb 2024 12:50:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 15902384CBB7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1708001426; bh=6yjO2rxQpBvyYdXJQcSBJjI76ovn/UO6OSWCf7wn8nc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Wnpwch4qfv2mW+t4baTYyW0eJK2etIiWprSBNfTuO1k0kIkdoYHoP4nT42EcEiY0+ jFlIKiWEHuIWsqgolP9gyNW7dHuh0V8mpNkZCrQWL1t1LqvndpP4V5zqNlB6lSB8Pd rZHLGgD/s5Pwf3pYJ5cn9Kk04plRV9PEAPaZ/4Cs= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-00641c01.pphosted.com (mx0b-00641c01.pphosted.com [205.220.177.146]) by sourceware.org (Postfix) with ESMTPS id 83E63384DED2; Thu, 15 Feb 2024 12:48:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 83E63384DED2 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 83E63384DED2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.177.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708001342; cv=none; b=gSAr+Zg//lC+aMYzsC7dd//KkzAsffx61CDDIOYw1p3FrY2kF8pXc2wT6GS1cE63E5Auv/B7WBg4vI1svqQwrZGealD15U2qJ20jjxrH9U1Dh2HhNY1aas0UezaIBUjN+5vbeH9fXoaxqCFGbii4c0YkXOemk03DFU/SJ1MRFuU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708001342; c=relaxed/simple; bh=Lvl+FT8IvryzLxkGcHzhKpdBdzMobGciTXizVO8O2UQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=hLa26jGU2OXqCj9C4BAWzf9yYMB6Fp8NZFylf99hMmBtMOI+eQVdLeA1YOakQ1aYV/Un97RHBiZ3XwoquFJmOkFqal9MLdBSZaQMC8tbN6sQhZnJ/S5zzMSJvuhYGZySMk82EquAG4By+sXeGrWaoc6l2G2iKCcVYNiNdUBADEo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247479.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41FCdUXE010129; Thu, 15 Feb 2024 12:48:51 GMT Received: from mxout21.s.uw.edu (mxout21.s.uw.edu [140.142.32.139]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3w939jnkth-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 12:48:50 +0000 Received: from smtp.washington.edu (smtp.washington.edu [140.142.234.157]) by mxout21.s.uw.edu (8.14.4+UW20.07/8.14.4+UW24.02) with ESMTP id 41FCmia1022593 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2024 04:48:44 -0800 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.154.74.143]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW24.02) with ESMTPSA id 41FCmbO3021397 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 04:48:44 -0800 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui Subject: [PATCH v4 10/12] libstdc++: Optimize std::add_rvalue_reference compilation performance Date: Thu, 15 Feb 2024 04:48:22 -0800 Message-ID: <20240215124824.310810-10-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215045258.3025806-1-kmatsui@gcc.gnu.org> References: <20240215045258.3025806-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: eDZCL7W09PPsqMn2g9vuR2OEyTyWAKgP X-Proofpoint-GUID: eDZCL7W09PPsqMn2g9vuR2OEyTyWAKgP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-15_12,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 mlxscore=0 adultscore=0 clxscore=1034 malwarescore=0 impostorscore=0 mlxlogscore=765 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402150102 X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790969304001046850 X-GMAIL-MSGID: 1790969304001046850 This patch optimizes the compilation performance of std::add_rvalue_reference by dispatching to the new __add_rvalue_reference built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (add_rvalue_reference): Use __add_rvalue_reference built-in trait. (__add_rvalue_reference_helper): Likewise. Signed-off-by: Ken Matsui --- libstdc++-v3/include/std/type_traits | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 1f4e6db72f4..219d36fabba 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -1157,6 +1157,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION }; /// @cond undocumented +#if _GLIBCXX_USE_BUILTIN_TRAIT(__add_rvalue_reference) + template + struct __add_rvalue_reference_helper + { using type = __add_rvalue_reference(_Tp); }; +#else template struct __add_rvalue_reference_helper { using type = _Tp; }; @@ -1164,6 +1169,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template struct __add_rvalue_reference_helper<_Tp, __void_t<_Tp&&>> { using type = _Tp&&; }; +#endif template using __add_rval_ref_t = typename __add_rvalue_reference_helper<_Tp>::type; @@ -1720,9 +1726,15 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION #endif /// add_rvalue_reference +#if _GLIBCXX_USE_BUILTIN_TRAIT(__add_rvalue_reference) + template + struct add_rvalue_reference + { using type = __add_rvalue_reference(_Tp); }; +#else template struct add_rvalue_reference { using type = __add_rval_ref_t<_Tp>; }; +#endif #if __cplusplus > 201103L /// Alias template for remove_reference