Message ID | 20240215114633.50124-1-jwakely@redhat.com |
---|---|
State | Accepted |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:b825:b0:106:860b:bbdd with SMTP id da37csp339181dyb; Thu, 15 Feb 2024 03:49:46 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXFoUmLrDNpfN1Kj29sVVwHGEZLYhRNjMMz4mcM5fNYk36WOZx8GlghML8VRraS12bB8/f9J6+QBOYwspoT7yKTMURG0Q== X-Google-Smtp-Source: AGHT+IFCpzKNZz8MHpOmYh3NGYqnlTsaEOJ3NCwPUJLqLyGUNtqMFS2SDUNSagZNxZPTCOXO9KFq X-Received: by 2002:a25:910:0:b0:dcd:3172:7271 with SMTP id 16-20020a250910000000b00dcd31727271mr1374388ybj.3.1707997786037; Thu, 15 Feb 2024 03:49:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707997786; cv=pass; d=google.com; s=arc-20160816; b=y53LoZZpEd2WOiPe3zUGMWNgTbsE1aZQxdVyHSxE4mflAMqoRc3hRpoF3sIg/RNnW6 XdRIwPqNXKFXvi0heI6HjvIF3kfixRw+6D5i+wpiBa8JLN8hzkeZYaYBDzHgvv2RC06c hbV8sq1/hvuiyRRNkWyDR15VQQzDFVhPGGoGwwOypmH4YO3RKcLPKvHTPLttIMYI37Sf QX53QIO3Y2AItFZ/R1J4QqKJMdYNWWb4xmhavK5oPDT0TnZWwE36VkfA0mW7j9x3hySl F2inVAzTWSgUwDc2YkqSz1WafmAkAp9v5J88NMIKnfog8KvYLDTnSGfwpbYzuqj3pWXK ukRw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=0TsdmpRSGTvGP2AEmZzOTeo8917I7gcIpT2StV+5BP4=; fh=sJ+2/4g29YdyXkoRrFZSpsL2zxijepB7X/1rB0LDDh8=; b=xN+JzY5gkioC18MYvTIyd32Ye5hJ1ANKTSnEVF9hwn+i33z5qE9cPWxic7w4ycYeXc yDNhTPQvBA2AR+TAWq5jiBgsV4/Bb3/jFpJz1Rw+Tvy5KqcA+JlL1oA05GpvlMKrb5MD mXNUUQBHvTIv4fAMLxQNryjgbgMf+kX5D5yBFKKYcoplDfca4HPIpdt+Jjwe6P8dssdu 1PtT8nJRZxeW8yTZyxNSqmSvZ0l9w3kmDy3hMyl2HnyaT+KfryOQwEcpBIulq2u3iPyQ rN3wUA649NuGbVYVxTOdttTmXm5J1rUoLBu4EutbvBvDP53NCAiBL4cgCAietKKxRvvJ Ewfw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hxkcO+jE; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id t32-20020a05622a182000b0042c5ec08424si1231172qtc.87.2024.02.15.03.49.45 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 03:49:46 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hxkcO+jE; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB284384CBA7 for <ouuuleilei@gmail.com>; Thu, 15 Feb 2024 11:49:45 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 622A33864879 for <gcc-patches@gcc.gnu.org>; Thu, 15 Feb 2024 11:46:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 622A33864879 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 622A33864879 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707997599; cv=none; b=DIpK4qftAnCzRLRDDOIlpeksIgVC8tIFQ2nlA38fiRqjt4JCtN5lnQFJzn8zhzBPAHYn2Rx17Dfg/XFuXVKMHEkrOwtQBEFTKZfdCdEaj6O4AhT4DJI7h/wyzP7S9i2TXXunGKFwgSOw0q+ofOzteAVOqFoz5uXS9bQMGHzgFuM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707997599; c=relaxed/simple; bh=zAMzguvrxSiPftop+kcqEs4liQEOQVDHjMscCZxR3Xo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hKOFnrZ91yZGLhOIp0rHKTMsbkfrnMvf42TqbM4M59MjYJnD2S8U715dP2TI+p5Mj32k1RlkgUrp5HGcVeukFE7NBTgrh24AYFquOAn61fj+MWJBETMR3jABxNwUzAQUOBCvy2LpmOmJwRuZ+8PACcQo94rIQOhtyxwcdrHQvi4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707997596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0TsdmpRSGTvGP2AEmZzOTeo8917I7gcIpT2StV+5BP4=; b=hxkcO+jE6mNByaFNgq4bi7yw3aU1B3mIBjtLkDl0pzqPGxW+ryiDFQJiKLIwzhWE5wr452 /9UdKv5qy6uA3qPLPEdeZL52Yh8lsizv2tHwOAJ3nmeGMyNqCWmUhlXQG+hF5NH2cp1/zT 2o9/44WP+0MPKwCrGpXvfDURHCuhDgs= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-189-G_uPD5C0OVakTjTvd0W28Q-1; Thu, 15 Feb 2024 06:46:34 -0500 X-MC-Unique: G_uPD5C0OVakTjTvd0W28Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A9EAB3C0009D; Thu, 15 Feb 2024 11:46:34 +0000 (UTC) Received: from localhost (unknown [10.42.28.206]) by smtp.corp.redhat.com (Postfix) with ESMTP id 77C442166B36; Thu, 15 Feb 2024 11:46:34 +0000 (UTC) From: Jonathan Wakely <jwakely@redhat.com> To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [committed] libstdc++: Use memset to optimize std::bitset::set() [PR113807] Date: Thu, 15 Feb 2024 11:46:29 +0000 Message-ID: <20240215114633.50124-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790965486401501891 X-GMAIL-MSGID: 1790965486401501891 |
Series |
[committed] libstdc++: Use memset to optimize std::bitset::set() [PR113807]
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | success | Github commit url |
Commit Message
Jonathan Wakely
Feb. 15, 2024, 11:46 a.m. UTC
Tested aarch64-linux and x86_64-linux. Pushed to trunk. -- >8 -- As pointed out in the PR we already do this for reset(). libstdc++-v3/ChangeLog: PR libstdc++/113807 * include/std/bitset (bitset::set()): Use memset instead of a loop over the individual words. --- libstdc++-v3/include/std/bitset | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/libstdc++-v3/include/std/bitset b/libstdc++-v3/include/std/bitset index 3243c649731..16c4040f532 100644 --- a/libstdc++-v3/include/std/bitset +++ b/libstdc++-v3/include/std/bitset @@ -177,8 +177,15 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER _GLIBCXX14_CONSTEXPR void _M_do_set() _GLIBCXX_NOEXCEPT { - for (size_t __i = 0; __i < _Nw; __i++) - _M_w[__i] = ~static_cast<_WordT>(0); +#if __cplusplus >= 201402L + if (__builtin_is_constant_evaluated()) + { + for (_WordT& __w : _M_w) + __w = ~static_cast<_WordT>(0);; + return; + } +#endif + __builtin_memset(_M_w, 0xFF, _Nw * sizeof(_WordT)); } _GLIBCXX14_CONSTEXPR void