From patchwork Thu Feb 15 10:00:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 201327 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:b825:b0:106:860b:bbdd with SMTP id da37csp287425dyb; Thu, 15 Feb 2024 02:01:30 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU7fqrSRahaQRvQHmczlkiVzUDtF41Nx/mJlunRncwGPWRuR020iQ3MAnAxTZC5kXz+VW8wkv6zgT8bpzIn7V2F3h+c9g== X-Google-Smtp-Source: AGHT+IHuPYFYRVa8tHZYvXAYmBR7Os88sH5SxQJxeUnSxc0K9Xv8vM3oUAYk/Do7dSmKK0CoY53I X-Received: by 2002:a05:6102:cd2:b0:46f:dff1:5df7 with SMTP id g18-20020a0561020cd200b0046fdff15df7mr1824523vst.0.1707991289857; Thu, 15 Feb 2024 02:01:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707991289; cv=pass; d=google.com; s=arc-20160816; b=AXxYt+TXZoX7NCNA2X0gJKqCrZC1+6RWA46wKvl0LajNeEcZYIG1OxJPAFJYrENXGE 5IrE8dh/ct/7V6uMZlTGBDvRXmIZ+AM1jU0qON2xHAIDgJvXndHdVY+1JIvyasaIeVhL 1CazzXiOqeU0xsgbYkbo0XCdtXWxwyfxxkGG3FOt1sTQttiBVgPDo18RN83LHYvULLPs 9Tv2foRM+otEN/FPayqvQMg3/9XuApZK7Vgl6zHG83hzFcX4Vj4UHGe0ABpys4cg/bAm XNUX1ZXlscQaNTepCwCYEsDQ8FlRaPppDdjowKbPwQL9CPdlEMeCzrU2OjDdprr4FBiY mCTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:errors-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :subject:to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=QFtyjuRfJfDGGbc/GP3Bj4Y/ziDPFsKs108/36ge85w=; fh=hPrbWPhweUx4V0GV9uXJqbyAzg2ABmTz7kczrAQqMmM=; b=sj97+3cvWJK39OEmePeRm8eHQca3BddYJunM2wbMVRjbuhxv2TBzWdsAm1I0WuSjzO DoLRqAkR8FwvnRokmC7L9rQkAPSEShQLdT7rSEqY8OS00tH1AXFXTGLJTGUWAwStiyFS +Edj3ftbqxBWBU8vs9Ii4apEfS+1/f4mhIJuVq/1bS9xKM12qNawP5hh5g5ID3hByYlg erp8NetrL7Bnn/Jv9/++LX6KT9OEK5WADu1jTAHpoTHPyCCRrmTUQGnnI5R5mxAIW77B /CG9Ue28rvA+mPYPNJ32VAYIb+c8t+YY8DoECzhllT3xQm3Xa/cWHRhsD/yBtriOY402 Sumg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=HOjXb9WW; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=aXhQ77PS; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id b13-20020a05622a020d00b0042dad3b7feasi1035594qtx.689.2024.02.15.02.01.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 02:01:29 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=HOjXb9WW; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=aXhQ77PS; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8EB723861861 for ; Thu, 15 Feb 2024 10:01:29 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 42C2538618A3 for ; Thu, 15 Feb 2024 10:00:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 42C2538618A3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 42C2538618A3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707991233; cv=none; b=sSJGc9R32RWDFspo1IwbGSt0BK2iFLC854A6o5W2JbAZ3GkTxFjfOdRSeM9l8p2ljnqa92BfyZseEfZWy3u1FV80a5VqGkJiW/doHfnKX0pgtlIC+Eovb/SIGStCxN/Mu6yfd+TiCjP/LNpc9RHtVVXkqZ+eRPAda3dPyEigdQQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707991233; c=relaxed/simple; bh=WW950/+PodOpp8nd/gHW4EjhnU7xzSb0tvOzB1EjC7s=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=eOfVE25f0FbMCGvxWRckdS23v8td08FdP4GEKTojHbZjPU0RgrwQXGqc5g8iMLfX1xYPnZEAXd38eBNuCyflgT8dMdwVx71GooKA05/LFrIuzsuAO31FXjuMOfbeR2Px/szXbFhp9JIwDkLBA7j4ovj14keXy2urkjZq6zt9VUA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F36AA1F88A for ; Thu, 15 Feb 2024 10:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707991231; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=QFtyjuRfJfDGGbc/GP3Bj4Y/ziDPFsKs108/36ge85w=; b=HOjXb9WW+H6GcUV1FuEjMG5wYgvj4mK+QnJTfnqTn+S725exGXDdu11q2R5oZTSPFelkHX B8TSyOMM3VHH/o2rCq9jRcHSGw9nBmGzJN53RTGCGlp72YpaTa7lSIXf0F+QZOpGwV+T1U Ia0NH+Mzj0O2uHK06pdUjyL92UhdXpY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707991231; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=QFtyjuRfJfDGGbc/GP3Bj4Y/ziDPFsKs108/36ge85w=; b=oh6s2l3Ms+WMUHkmmcVULGQoeJmF4VvuPBwEKDhTfusDZcWxwDdf0Dg4i8aFMciJenkQhu DDl0aCvhKbOUHtAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707991230; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=QFtyjuRfJfDGGbc/GP3Bj4Y/ziDPFsKs108/36ge85w=; b=aXhQ77PSsx5jV37MawlHh1Wu04At1f2ls1Ok36/XfoKFU5SmW6DT1VWlI0Y1j+yKLkUDy4 dnpEZAgmfhIj7QKfa4L39C19emBm+Z5zB/HypRJeYTcCSd/Eq+UiGZvyeCGDJLVGJ0+z3h 1AZXCXpWVFcNgBaFYzD2DsyMvSHl/og= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707991230; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=QFtyjuRfJfDGGbc/GP3Bj4Y/ziDPFsKs108/36ge85w=; b=r/e256zeM1Az1VkSr32PNP+dxopunRmGj+Qv30IgnqfjHRyD9S1FwnF/n+cUgn7vUbSHR8 ff9bwednHDKqViBA== Date: Thu, 15 Feb 2024 11:00:29 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Do not record dependences from debug stmts in tail merging MIME-Version: 1.0 Authentication-Results: smtp-out2.suse.de; none X-Spam-Score: 5.42 X-Spamd-Result: default: False [5.42 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(2.81)[0.937]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_SPAM_LONG(0.41)[0.117]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.20)[71.45%] X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Message-Id: <20240215100129.8EB723861861@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790958674679080470 X-GMAIL-MSGID: 1790958674679080470 The following avoids recording BB dependences for debug stmt uses. Bootstrap and regtest running on x86_64-unknown-linux-gnu. It's unlikely a dependence is just because of debug stmts so actual compare-debug issues are very unlikely. Still spotted while investigating a CI regression mail (for an obsolete broken patch ...) * tree-ssa-tail-merge.cc (same_succ_hash): Skip debug stmts. --- gcc/tree-ssa-tail-merge.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gcc/tree-ssa-tail-merge.cc b/gcc/tree-ssa-tail-merge.cc index f4e6ae6e8a2..c8b4a79294d 100644 --- a/gcc/tree-ssa-tail-merge.cc +++ b/gcc/tree-ssa-tail-merge.cc @@ -474,6 +474,9 @@ same_succ_hash (const same_succ *e) !gsi_end_p (gsi); gsi_next_nondebug (&gsi)) { stmt = gsi_stmt (gsi); + if (is_gimple_debug (stmt)) + continue; + stmt_update_dep_bb (stmt); if (stmt_local_def (stmt)) continue;