From patchwork Wed Feb 14 13:52:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ken Matsui X-Patchwork-Id: 200962 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp1225586dyb; Wed, 14 Feb 2024 05:54:56 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWm23ufgBHGpB+l4Gx1vgCKDM18xtii6+Mfmsa+9uEB24pmi3B+vj28qJ1ExQ8pCapvZKGxRf1djVU+HGE9+zoSYXYmuQ== X-Google-Smtp-Source: AGHT+IEzXemd91ZeLaWcbaGdUKbj4G9F9amEJ3gNSjtGlS4SEl4lboiDWMeVuvHEFnWxc+Az5UaU X-Received: by 2002:a05:6214:29e5:b0:68c:3d2a:47e7 with SMTP id jv5-20020a05621429e500b0068c3d2a47e7mr2466603qvb.27.1707918896245; Wed, 14 Feb 2024 05:54:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707918896; cv=pass; d=google.com; s=arc-20160816; b=mgLU4tV9fNggljFqFwzS1YxZTnZ0KmUS3BDGS9klzcXWwf3FY3v0ldXnwQvW+ybmdd 9ZjRsg1UYt1OlyD2d6KRD4kqi8iP/5fEng0PLYL8ei+mkJrV0G8JfOY0ZywQtJxQ/JUt KnvpcyMn0hakGs0g+aAIdApiEWUVOH0RRohAo211icZ7Xtx9sTZvw+U1qC167bw4kLO2 SysoVIFS38mpTcPH7B/wPjX/KVIbWIovut6vTaRqaLNrO1I7KhWQB3QNxvdkO7EJbTzf nxXyHw/HLCJjkw/8f/KAxGucymx8hiRYoH97jOh2wZnkpILs1iC2UDV8dKpCXuzxj0gl aKIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=piDE3AgxzrW0dXa2e3uQh2wEapv7CFxKuS7kgH2unj0=; fh=joQNJ7FBrQgNH06wDBZ3MwdRCwFRnTNQOl47UY4qokA=; b=V4+sKCpzFslIAfAEhKc5PKnLGEZyCSYeb6nPQ6xwMdFhOP4/uW9R1ih7bWJPbiuJNf 2MqF9lBGZ+LXsXWvabgChXc6ChVb5nRWLJcSDaOyJpqHhP4mFfabhD0JNPG0cUnIDEVo XTGzgFeKejuskv2x9GHy1Rmi6L67nthIlYv4Md/kx6WgzugUB/8mzMGltbYaYsrg74RI /DTexFYLdJN4yWR8AO3nuKBEw3h2Uj2o+M/4lcSEvFXwJBUBW+1zRR18z/ArIHsrE8x4 M3ne48/7qDQYdIH2uZiLolzgdk99SeJblCwaU3ydHYd0wtc8KISNd05jaZaiOlYghzpt usnQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Domt5SPK; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org X-Forwarded-Encrypted: i=2; AJvYcCXXjQ12Psz1qiWNwup+eJ2AQFM0foMG44XFzj5dXrz4tXA5jojm88vevA4buzAE9/wuM1DbZLLrdM/ZNZ2YrRsdE2TioQ== Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id ke12-20020a056214300c00b0068c9dbf3af9si5140750qvb.384.2024.02.14.05.54.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 05:54:56 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Domt5SPK; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E4538385E45E for ; Wed, 14 Feb 2024 13:54:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E4538385E45E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1707918895; bh=piDE3AgxzrW0dXa2e3uQh2wEapv7CFxKuS7kgH2unj0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Domt5SPKFnO/3j0v5HUJy66U4vy+BKvrsZ1xlgx2RbDdDZcpURVCCSoh6yuTDsZ80 ZKe9AH91zPRnRBYnoUwXysHsuFbV3ee/wDGHOxDd2n+u4nbudXN9Ba3teUG0vZo1u4 VJgmgZqNy6Rx5Cb/364teeOP0rJzFa/C4w3WOaZ4= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-00641c01.pphosted.com (mx0a-00641c01.pphosted.com [205.220.165.146]) by sourceware.org (Postfix) with ESMTPS id D97B9385E020; Wed, 14 Feb 2024 13:53:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D97B9385E020 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D97B9385E020 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.165.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707918813; cv=none; b=E2aF5J4OI58+PqViN7RUvxjyTxc+S6J7Qxw8xAA8oA9hOl6yVIQzEDaIpNefbO04cvJOQ/qfktjSNtLv5Zl6wCdzhgnqbhXCn9azdb0RvmpwPJgp6VbOmD9zkDd7kL14hEAWmiqp+NsDpmUet/v8oZYsvJsKe5HKVtJnHPCBC8Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707918813; c=relaxed/simple; bh=mgSd9TEezsOin328Daikj7GhRV0O1ne8sDSsrKJn60A=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=K0+Xay02Q5WJ6m+5uAgzSLfMiBMMIzIvYaJZAIbZInN2B2FLy1D0pwaVXN1ae8HM6+crpWJ2tSEFQb2gvHjsINlb5KsjhvW2XEtubpHzDQFn5RpkWJv+clSZFi+Bf1zgkYE89JirU4dzG9EWTXlm0eKUQN9gkXDlBrfs/1Y8lzo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247472.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41EDbV8X017612; Wed, 14 Feb 2024 13:53:26 GMT Received: from mxout25.s.uw.edu (mxout25.s.uw.edu [140.142.234.175]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3w8kqqtr10-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Feb 2024 13:53:25 +0000 Received: from smtp.washington.edu (smtp.washington.edu [128.208.60.132]) by mxout25.s.uw.edu (8.14.4+UW20.07/8.14.4+UW24.02) with ESMTP id 41EDr2wo026085 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Feb 2024 05:53:02 -0800 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.154.74.143]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW24.02) with ESMTPSA id 41EDqxIo024820 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Feb 2024 05:53:02 -0800 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui Subject: [PATCH v2 2/4] libstdc++: Optimize std::add_pointer compilation performance Date: Wed, 14 Feb 2024 05:52:50 -0800 Message-ID: <20240214135252.1416047-2-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214135252.1416047-1-kmatsui@gcc.gnu.org> References: <20240214114448.847646-1-kmatsui@gcc.gnu.org> <20240214135252.1416047-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: cZYzWqIHHZVqP2dsGciPh9F1-lr1fC0v X-Proofpoint-GUID: cZYzWqIHHZVqP2dsGciPh9F1-lr1fC0v X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-14_06,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 mlxlogscore=623 suspectscore=0 clxscore=1034 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402140107 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790874693289672919 X-GMAIL-MSGID: 1790882764666964966 This patch optimizes the compilation performance of std::add_pointer by dispatching to the new __add_pointer built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (add_pointer): Use __add_pointer built-in trait. Signed-off-by: Ken Matsui --- libstdc++-v3/include/std/type_traits | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 21402fd8c13..3bde7cb8ba3 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -2121,6 +2121,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION { }; #endif + /// add_pointer +#if _GLIBCXX_USE_BUILTIN_TRAIT(__add_pointer) + template + struct add_pointer + { using type = __add_pointer(_Tp); }; +#else template struct __add_pointer_helper { using type = _Tp; }; @@ -2129,7 +2135,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION struct __add_pointer_helper<_Tp, __void_t<_Tp*>> { using type = _Tp*; }; - /// add_pointer template struct add_pointer : public __add_pointer_helper<_Tp> @@ -2142,6 +2147,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template struct add_pointer<_Tp&&> { using type = _Tp*; }; +#endif #if __cplusplus > 201103L /// Alias template for remove_pointer