Message ID | 20240214063651.3012733-1-maskray@google.com |
---|---|
State | Accepted |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp1024848dyb; Tue, 13 Feb 2024 22:37:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCURjEWmWhkJxcsVOX8/lv3P7NW5jVwDRiOYuSqZhmYkbLRGgOqG7tb72O6NAVx/HPMRlV02OqDZqdwZhWvpAnNCPXIHjA== X-Google-Smtp-Source: AGHT+IHgta9EMVW3iBPu2mDK8DAh82SIPj3dB8CJieM/2v5EiltICe7PaFIZNZsixiK7PSNjiV2m X-Received: by 2002:a37:e304:0:b0:785:af2f:1da1 with SMTP id y4-20020a37e304000000b00785af2f1da1mr1948979qki.57.1707892654332; Tue, 13 Feb 2024 22:37:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707892654; cv=pass; d=google.com; s=arc-20160816; b=c+MMqobOm68pTV9mAATQF5GAPOaiFW6Dx4kAAh2VHfrncXredh9lKaPSrAd4JBJ3Ek 5oIvi7nyDHx9WeqjsCxVGBrXJyujWS3cQ7PD9H7r7XYEF5IDwZ+q2r2HeE3N8E5Q9k1j TT9uFpRQ5TdovfaCAAIlBt5eK0nWuFCUZXhoAGOHgDHv6MK+Xwhgg2CnY91GavGDr5l1 V5803EFzXklW8S0E9YkftIHgCrAScSfnsuGXddQM0EuQIIOTpeeIcgyYMFh/h2vNxi9x goOdE4zjqQNrzNXUtS/Z1Wf4mpoAKETxpp6kyWq7w80LHR9nAcUXxjpA4kVpsAkAR/Rw xzdA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:from:subject:message-id :mime-version:date:dkim-signature:arc-filter:dmarc-filter :delivered-to; bh=NS0ucWrNUSvEZFEBt0zUYWkpDuKKP+p8omB0Q3Uy6mQ=; fh=JsinRYcAAKmcKqaSD/FPsnWkmi8VTLC6KB8MMbA9VKA=; b=SJy5TARQ35AXrAnNi2FPBK84qVz7ha3bfpgh3daVD4pgt7gx2cSD4IhWg8Nt1C05gO RK/1Bcyp5ba3fU6FOoQX+nB9k5YicZ+G5KWzQUownDAnP9ZZAAX8IACk19PF46pOnAiU F39FFxI5lrBmNC3AWjS8baUE/VGk6gaiSS4Fk9dEkW/w9sKmbL9WNKxxYSY9ZwUWtekH wVYxNjDA6T+hEroF+2UKh4JHZLNBc7gBy1izShJHXdi1kvyJ0szlERcjgFXFxSX7TQN4 V8gnNOBdFX4CgzbcgQB7l6fd+ButXdvNzXXVvexkhb2jG5MUkB8ZHKJsjTPsoct8l+ya olAA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=qxECzRdB; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com X-Forwarded-Encrypted: i=2; AJvYcCVKrMhF2LbA22QxUM3mPx0MSWbacPdlT4TNcliRq2L+yzp1ZtDZdR+WSHgfDOQ+I8OtWQ6d39tpnG6Z5Ln+xXlTG4p/mQ== Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id bj28-20020a05620a191c00b00785d44938b3si7638115qkb.9.2024.02.13.22.37.34 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 22:37:34 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=qxECzRdB; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0FF713857732 for <ouuuleilei@gmail.com>; Wed, 14 Feb 2024 06:37:34 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by sourceware.org (Postfix) with ESMTPS id 24B87385782C for <gcc-patches@gcc.gnu.org>; Wed, 14 Feb 2024 06:36:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 24B87385782C Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=flex--maskray.bounces.google.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 24B87385782C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b4a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707892616; cv=none; b=k4XnFF1tcsAE/lwSA1K4ZQDfKrkSb8YFs1QNiR/RdFYxbmjK9byrMJc6LI+UywSncjtrf744+4vpHrHYo9nFHolsBT3BQdoehrG/7G8cFnhgWFimla9O3+wg2WCv5onc/tJDb94K+IXf7ogO4yvCDeF37LXpPfC6t0Ljm8nzlcA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707892616; c=relaxed/simple; bh=HlFVINsyBcEiyC6s1Eb/lsPxw3xLLfvzMv+OIBwjFK0=; h=DKIM-Signature:Date:Mime-Version:Message-ID:Subject:From:To; b=T+VSJ6mRGupMbbnmLX6aCh8GfSB09LEA/TY6jlFxy4jWS/sqLZ+//Xv/BAwKmXrQ5vZtRqOdJ87/Fl3gZSOc1S/n8UXQ8fewFcOzPzcrHLqxGxxZYewfkpAoYut9UosQnZjyc08Jr0O/1D7EtAMDYP+magT2YroBaftRuO/7RTg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-dc64b659a9cso8951149276.3 for <gcc-patches@gcc.gnu.org>; Tue, 13 Feb 2024 22:36:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707892614; x=1708497414; darn=gcc.gnu.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=NS0ucWrNUSvEZFEBt0zUYWkpDuKKP+p8omB0Q3Uy6mQ=; b=qxECzRdBKTefJytcyz4TTAXeR2aeJUJx/EsjrA+DFuBhEnmKwjaoz0GvQmNBfs1ZQF yPwtr1vyKPAhvvFLyWpxhFuka9gjKYQxOazaEoj3feNZUQwU1O7K19hwKd1nI8b5ae5J /lQnGv2k1q3Q2Qs3NMescIydqVGt4T8+t53W24wZFrwB4G9iImPYRakV/+DfwGO+bcwe Thm0Vpb+OyknNw8NNuq3ak9axqzTsqMYTbLiGQA90q1yq8WDtLMk+Qe/yb9426IvwYj/ O7CxAOpKz3q3nieJrJ8oj0K4VWK437mxau/NmY/rl7G5fzrAXTiclg2Vx99+JvxZC+hw x0bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707892614; x=1708497414; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NS0ucWrNUSvEZFEBt0zUYWkpDuKKP+p8omB0Q3Uy6mQ=; b=YooV5F9GvzeL04haY78+Og8tYwZEutheqnvzztSgSnI2nZnz70RfDEVVnvDAerGBNh GSoQlyJ4DTkRy0hOru4Xh2+QIyBfPJS2b/ds9KWM4tu7LxPKq7w9j8bByOymin2fdAe3 1B+694tpsrzOekZYHuhmTwxjMgC2q+vPE67mVmDdzVRme9Op8ip43UBZHXYO1RtlYV/E QntF6Fyllh+2UPicyIK56GNL/6TbChno26BfiS5seKYqzNCFGskQWhwBPAJJFYbqaAmU HSOmlWFYYwF+xaAf3r4H5oY2JG42S7YYHJOoc4oRGUe2olpmA9z0WG/5NxP+2Lyukfff JIXg== X-Forwarded-Encrypted: i=1; AJvYcCVZZixjfAwyIeC+aOxc1PzaWG8Fr0B7iSYWfSg+k3kW7zTcjUv9xiJmkuB+2nB5f5HwZZSxFRy7Zyx3ypYGoQdQgxJ786Md3Q== X-Gm-Message-State: AOJu0YxsSLFszctbWmTP5POpg5/haza6CvsZJP/Z/4Ayn/bzYmr3mzVH xtDQRuiVuslT9hEFVj/2K39lpxU+XTxw+ACmdLGopERocZ1Mv1MyyFNnkNVfU66Pf+3qq1GkQf6 h8NU9aQ== X-Received: from maskray.svl.corp.google.com ([2620:15c:2d3:205:448b:aa1a:69fe:22b6]) (user=maskray job=sendgmr) by 2002:a05:6902:1082:b0:dc6:f877:ea7b with SMTP id v2-20020a056902108200b00dc6f877ea7bmr396567ybu.9.1707892614569; Tue, 13 Feb 2024 22:36:54 -0800 (PST) Date: Tue, 13 Feb 2024 22:36:51 -0800 Mime-Version: 1.0 Message-ID: <20240214063651.3012733-1-maskray@google.com> Subject: [PATCH] RISC-V: Add tests for constraints "i" and "s" From: Fangrui Song <maskray@google.com> To: kito.cheng@gmail.com, gcc-patches@gcc.gnu.org Cc: Fangrui Song <maskray@google.com> Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-19.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790855248084638261 X-GMAIL-MSGID: 1790855248084638261 |
Series |
RISC-V: Add tests for constraints "i" and "s"
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | success | Github commit url |
Commit Message
Fangrui Song
Feb. 14, 2024, 6:36 a.m. UTC
The constraints "i" and "s" can be used with a symbol that binds externally, e.g. ``` namespace ns { extern int var, a[4]; } void foo() { asm(".pushsection .xxx,\"aw\"; .dc.a %0; .popsection" :: "s"(&ns::var)); asm(".reloc ., BFD_RELOC_NONE, %0" :: "s"(&ns::a[3])); } ``` gcc/testsuite/ChangeLog: * gcc.target/riscv/asm-raw-symbol.c: New test. --- gcc/doc/md.texi | 2 +- gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c
Comments
On Tue, Feb 13, 2024 at 10:36 PM Fangrui Song <maskray@google.com> wrote: > > The constraints "i" and "s" can be used with a symbol that binds > externally, e.g. > ``` > namespace ns { extern int var, a[4]; } > void foo() { > asm(".pushsection .xxx,\"aw\"; .dc.a %0; .popsection" :: "s"(&ns::var)); > asm(".reloc ., BFD_RELOC_NONE, %0" :: "s"(&ns::a[3])); > } > ``` > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/asm-raw-symbol.c: New test. > --- > gcc/doc/md.texi | 2 +- > gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c | 14 ++++++++++++++ > 2 files changed, 15 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c > > diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi > index b0c61925120..c75e5bf259d 100644 > --- a/gcc/doc/md.texi > +++ b/gcc/doc/md.texi > @@ -1947,7 +1947,7 @@ Integer constant that is valid as an immediate operand in a 64-bit @code{MOV} > pseudo instruction > > @item S > -An absolute symbolic address or a label reference > +A symbolic reference or label reference. > > @item Y > Floating point constant zero > diff --git a/gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c b/gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c > new file mode 100644 > index 00000000000..28305a8b1f0 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c > @@ -0,0 +1,14 @@ > +/* { dg-do compile } */ > +/* { dg-options "-fpic" } */ > + > +extern int var, arr[2][2]; > + > +void > +test (void) > +{ > + __asm__ ("@ %0" : : "i"(&var)); > + __asm__ ("@ %0 %1 %2" : : "s"(&var), "s"(&arr[1][1]), "s"(test)); > +} > + > +/* { dg-final { scan-assembler "@ var arr\\+12 test" } } */ > +/* { dg-final { scan-assembler "@ var" } } */ > -- > 2.43.0.687.g38aa6559b0-goog > Ping:)
LGTM, but I am OoO today, will commit that once I have laptop :p Fangrui Song <maskray@google.com> 於 2024年2月22日 週四 05:54 寫道: > On Tue, Feb 13, 2024 at 10:36 PM Fangrui Song <maskray@google.com> wrote: > > > > The constraints "i" and "s" can be used with a symbol that binds > > externally, e.g. > > ``` > > namespace ns { extern int var, a[4]; } > > void foo() { > > asm(".pushsection .xxx,\"aw\"; .dc.a %0; .popsection" :: > "s"(&ns::var)); > > asm(".reloc ., BFD_RELOC_NONE, %0" :: "s"(&ns::a[3])); > > } > > ``` > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/riscv/asm-raw-symbol.c: New test. > > --- > > gcc/doc/md.texi | 2 +- > > gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c | 14 ++++++++++++++ > > 2 files changed, 15 insertions(+), 1 deletion(-) > > create mode 100644 gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c > > > > diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi > > index b0c61925120..c75e5bf259d 100644 > > --- a/gcc/doc/md.texi > > +++ b/gcc/doc/md.texi > > @@ -1947,7 +1947,7 @@ Integer constant that is valid as an immediate > operand in a 64-bit @code{MOV} > > pseudo instruction > > > > @item S > > -An absolute symbolic address or a label reference > > +A symbolic reference or label reference. > > > > @item Y > > Floating point constant zero > > diff --git a/gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c > b/gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c > > new file mode 100644 > > index 00000000000..28305a8b1f0 > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c > > @@ -0,0 +1,14 @@ > > +/* { dg-do compile } */ > > +/* { dg-options "-fpic" } */ > > + > > +extern int var, arr[2][2]; > > + > > +void > > +test (void) > > +{ > > + __asm__ ("@ %0" : : "i"(&var)); > > + __asm__ ("@ %0 %1 %2" : : "s"(&var), "s"(&arr[1][1]), "s"(test)); > > +} > > + > > +/* { dg-final { scan-assembler "@ var arr\\+12 test" } } */ > > +/* { dg-final { scan-assembler "@ var" } } */ > > -- > > 2.43.0.687.g38aa6559b0-goog > > > > Ping:) > > > -- > 宋方睿 >
On Wed, Feb 21, 2024 at 4:07 PM Kito Cheng <kito.cheng@gmail.com> wrote: > > LGTM, but I am OoO today, will commit that once I have laptop :p Thanks! Dropped the gcc/doc/md.texi change and pushed as commit 9ca4c1bf082a4691482ca9f4814fea68f04e2cb3 (I have write-after-approval now:) ) > Fangrui Song <maskray@google.com> 於 2024年2月22日 週四 05:54 寫道: >> >> On Tue, Feb 13, 2024 at 10:36 PM Fangrui Song <maskray@google.com> wrote: >> > >> > The constraints "i" and "s" can be used with a symbol that binds >> > externally, e.g. >> > ``` >> > namespace ns { extern int var, a[4]; } >> > void foo() { >> > asm(".pushsection .xxx,\"aw\"; .dc.a %0; .popsection" :: "s"(&ns::var)); >> > asm(".reloc ., BFD_RELOC_NONE, %0" :: "s"(&ns::a[3])); >> > } >> > ``` >> > >> > gcc/testsuite/ChangeLog: >> > >> > * gcc.target/riscv/asm-raw-symbol.c: New test. >> > --- >> > gcc/doc/md.texi | 2 +- >> > gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c | 14 ++++++++++++++ >> > 2 files changed, 15 insertions(+), 1 deletion(-) >> > create mode 100644 gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c >> > >> > diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi >> > index b0c61925120..c75e5bf259d 100644 >> > --- a/gcc/doc/md.texi >> > +++ b/gcc/doc/md.texi >> > @@ -1947,7 +1947,7 @@ Integer constant that is valid as an immediate operand in a 64-bit @code{MOV} >> > pseudo instruction >> > >> > @item S >> > -An absolute symbolic address or a label reference >> > +A symbolic reference or label reference. >> > >> > @item Y >> > Floating point constant zero >> > diff --git a/gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c b/gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c >> > new file mode 100644 >> > index 00000000000..28305a8b1f0 >> > --- /dev/null >> > +++ b/gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c >> > @@ -0,0 +1,14 @@ >> > +/* { dg-do compile } */ >> > +/* { dg-options "-fpic" } */ >> > + >> > +extern int var, arr[2][2]; >> > + >> > +void >> > +test (void) >> > +{ >> > + __asm__ ("@ %0" : : "i"(&var)); >> > + __asm__ ("@ %0 %1 %2" : : "s"(&var), "s"(&arr[1][1]), "s"(test)); >> > +} >> > + >> > +/* { dg-final { scan-assembler "@ var arr\\+12 test" } } */ >> > +/* { dg-final { scan-assembler "@ var" } } */ >> > -- >> > 2.43.0.687.g38aa6559b0-goog >> > >> >> Ping:) >> >> >> -- >> 宋方睿
diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi index b0c61925120..c75e5bf259d 100644 --- a/gcc/doc/md.texi +++ b/gcc/doc/md.texi @@ -1947,7 +1947,7 @@ Integer constant that is valid as an immediate operand in a 64-bit @code{MOV} pseudo instruction @item S -An absolute symbolic address or a label reference +A symbolic reference or label reference. @item Y Floating point constant zero diff --git a/gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c b/gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c new file mode 100644 index 00000000000..28305a8b1f0 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/asm-raw-symbol.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ +/* { dg-options "-fpic" } */ + +extern int var, arr[2][2]; + +void +test (void) +{ + __asm__ ("@ %0" : : "i"(&var)); + __asm__ ("@ %0 %1 %2" : : "s"(&var), "s"(&arr[1][1]), "s"(test)); +} + +/* { dg-final { scan-assembler "@ var arr\\+12 test" } } */ +/* { dg-final { scan-assembler "@ var" } } */