Message ID | 20240213104408.1925198-1-torbjorn.svensson@foss.st.com |
---|---|
State | Accepted |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp453467dyb; Tue, 13 Feb 2024 02:50:48 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV7EtX4cedI89yBv6rRji0Eu9XoyTX7JaIgug2RELNbkvXteAC5A8BEFN6Hv7eqpV2B6UefMov1uPJDgPdRDThX3asv0Q== X-Google-Smtp-Source: AGHT+IHMPJ4436A1uANSP3c6P5dJrwhSUs2yM+GZhamoz+ksiuadeh1H9UMMnk3B5N1/0YI0Nx+U X-Received: by 2002:ac8:4e8c:0:b0:42c:85f0:43d4 with SMTP id 12-20020ac84e8c000000b0042c85f043d4mr4367232qtp.8.1707821448273; Tue, 13 Feb 2024 02:50:48 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707821448; cv=pass; d=google.com; s=arc-20160816; b=0AV92DTsLYPG2RVaPz806AfKN6pk+b0I/K69sbyqKjPCM/ZFwtCdKZFU9ZRffph4Ga rRHOi/eo5dCV0WuphiS7QNrFpJZ4TKbiQyVegubV4Lh6Ag8s1ni3ZB1qcnbrsn5ix6fP Ugr56+CF3n47Rm+QSLckL3b39sBBFC/LB2X4yRk8SJ59g1Ym3IazlHY76ks1m1FhFM/E U5l5jkFWKEtRb8ZUvUYoPEEMDUevIbQH+Pk4XwK3TKhA3v5pouFS4bxo1nEhjn1QH9ij +DvWa6eA5JtAnze6qe5rSUc1nzoQk+E2HjMWJeUD6T2niJNep+4/g3uCwJ4o3tRsGMab DrvA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=N6rMWe3b0yXBwNZ1hq2oKA2sdlnhMrG0t5mttfTz5S0=; fh=fBTx3s7uN6aYYe8mUDKRlpI0/F0Ch4ZkjEWJl0Plg0s=; b=oUPJtlMgrDaQbtrstgy47vY5c2+4UTu545f/ujLp9EPoXu4svFwLrkxLnpQvNK4LmN yxmbUSLCV3bY0aJZ+MwluV6dJ8kYPwvBtlu0jdeiSLEgB7Ghu1ze2q2KurS8S7N5dyBq CBuZfyDeNagCNUwNmgYW4/g1yvh5TK3+oyMBFljpToo0wnClvXwblFwHYCE132/8aVRB AjVkuay2Ft0+wRO6P+50XJJSGa5Obfjdp2LyLE5IW1+2S60Fy+zw6NNwY7uyF/vtAgRf IPlr/w+bwldEWo+UYf4+WZbtQ24kYArqaO0zi52zJq6m1x+VFvNaJDzDxOBj3hjyTw8X A0pw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=mfxTTo9R; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com X-Forwarded-Encrypted: i=2; AJvYcCX8FzSNIwz9CUE0AVd9GmTceQqpOY3MzSlv64nvHtC/48LscccO3yjb+NccY/bRB0kSYDLO7w7RMCIrUmHTWUiR45prYA== Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id k7-20020ac84747000000b0042c3986d756si2445174qtp.129.2024.02.13.02.50.48 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 02:50:48 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=mfxTTo9R; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F2BEC3858284 for <ouuuleilei@gmail.com>; Tue, 13 Feb 2024 10:50:47 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by sourceware.org (Postfix) with ESMTPS id 125BA3858410 for <gcc-patches@gcc.gnu.org>; Tue, 13 Feb 2024 10:48:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 125BA3858410 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=foss.st.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 125BA3858410 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=185.132.182.106 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707821339; cv=none; b=bleU07y7nnWE+H0jmcdvgxhlcBZs5TrRlx97dC9+hZzD1DQk86D1r/1Pw0Opxus/LGKchm4lvEd6DsC+AzkGLRPOalNBh1pjcbfAxrwgaVCVvadaDxUWYHY3Eb7PYfiUAaMTdB2okaVESI1bB8QxH0zehhPG5foR78F587Hc4cY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707821339; c=relaxed/simple; bh=m6E7CfN/T6r/m2jmUILXOO+XP9s+KohL7+YUY7c5Vik=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=SBTGbHQXDCPU3wM/d980gt1HMQV9gI8ivKr+6wasRRdw7lKBAVDCGtk6zk79AmfYeIZ7RX1dnabCg7ZQKtNL9KmSqv5HNHssdySIgJ/TLgYEOU32InhaObi/ORosgT1Klg48wb9JE0G1TCRfHZ00T7uullJkEWEZIwsucXcdi1g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41D57Efm001636; Tue, 13 Feb 2024 11:48:54 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=selector1; bh=N6rMWe3b0yXBwNZ1hq2o KA2sdlnhMrG0t5mttfTz5S0=; b=mfxTTo9RwgTR3BTTJxQ6PQXUobAlyJyl0ufV jMF7PwpUk2classtNNfib4vwusQNGiMMhJp7nZv3c6Lw/dAawly+kICYjfwRiMaN 3EyL8F598XBlO4LNP7ZE37UzolbLSRiOOCAERfEma+BFZzyjsHTexZInEQWyuUox 5wlhS1KZFk+Iz6/Hd4EzhUIvh8YLz0N03nyKFG7JK2NOMCOl+QNRqA/K4jPee3gb I1gyye6TdfmhjydvSCmQEcDtbc/coJt0tRM0Vld9EpBUxC3NS+P6dg2DjBR/PrpI tDgoJB1wZw6Gp/IoC1pX4nvuzafBWwMv8hj5sYT2abF9xIoXbQ== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3w62jsaes1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Feb 2024 11:48:53 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 860FA40044; Tue, 13 Feb 2024 11:48:50 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 5CDB522AFF2; Tue, 13 Feb 2024 11:48:38 +0100 (CET) Received: from jkgcxl0004.jkg.st.com (10.74.22.255) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 13 Feb 2024 11:48:37 +0100 From: =?utf-8?q?Torbj=C3=B6rn_SVENSSON?= <torbjorn.svensson@foss.st.com> To: <gcc-patches@gcc.gnu.org> CC: <mikestump@comcast.net>, <rearnsha@arm.com>, =?utf-8?q?Torbj=C3=B6rn_SVE?= =?utf-8?q?NSSON?= <torbjorn.svensson@foss.st.com> Subject: [PATCH] testsuite: Disable test for incompatible Arm targets Date: Tue, 13 Feb 2024 11:44:09 +0100 Message-ID: <20240213104408.1925198-1-torbjorn.svensson@foss.st.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.74.22.255] X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-13_05,2024-02-12_03,2023-05-22_02 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790780583154004285 X-GMAIL-MSGID: 1790780583154004285 |
Series |
testsuite: Disable test for incompatible Arm targets
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | success | Github commit url |
Commit Message
Torbjorn SVENSSON
Feb. 13, 2024, 10:44 a.m. UTC
Ok for trunk and releases/gcc-13?
The alternative approach (that is changing the result a bit) is to drop
the special treatment for arm*-*-*. I'm not sure if this is prefered or
just disable the test for incompatible flags for arm*-*-*.
--
The test assumes it's okay to supply -march=armv7-a+simd, but it depends
on what target you are running the tests for. For example, running the
GCC testsuite for Cortex-M0 produces the follwing entry in the logs:
Testing gcc.dg/pr41574.c
doing compile
Executing on host: arm-none-eabi-gcc .../pr41574.c -mthumb -march=armv6s-m -mcpu=cortex-m0 -mfloat-abi=soft -fdiagnostics-plain-output -O2 -march=armv7-a -mfloat-abi=softfp -mfpu=neon -fno-unsafe-math-optimizations -fdump-rtl-combine -ffat-lto-objects -S -o pr41574.s (timeout = 800)
spawn -ignore SIGHUP arm-none-eabi-gcc .../pr41574.c -mthumb -march=armv6s-m -mcpu=cortex-m0 -mfloat-abi=soft -fdiagnostics-plain-output -O2 -march=armv7-a -mfloat-abi=softfp -mfpu=neon -fno-unsafe-math-optimizations -fdump-rtl-combine -ffat-lto-objects -S -o pr41574.s
pid is 9799 -9799
cc1: warning: switch '-mcpu=cortex-m0' conflicts with switch '-march=armv7-a+simd'
pid is -1
output is cc1: warning: switch '-mcpu=cortex-m0' conflicts with switch '-march=armv7-a+simd'
status 0
FAIL: gcc.dg/pr41574.c (test for excess errors)
Excess errors:
cc1: warning: switch '-mcpu=cortex-m0' conflicts with switch '-march=armv7-a+simd'
PASS: gcc.dg/pr41574.c scan-rtl-dump-not combine "\\(plus:DF \\(mult:DF"
Patch has been verified on Linux.
gcc/testsuite/ChangeLog:
* gcc.dg/pr41574.c: Disable test for Arm targets incompatible
with -march=armv7-a+simd.
Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
---
gcc/testsuite/gcc.dg/pr41574.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Comments
On 13/02/2024 10:44, Torbjörn SVENSSON wrote: > Ok for trunk and releases/gcc-13? > > The alternative approach (that is changing the result a bit) is to drop > the special treatment for arm*-*-*. I'm not sure if this is prefered or > just disable the test for incompatible flags for arm*-*-*. > > -- > > The test assumes it's okay to supply -march=armv7-a+simd, but it depends > on what target you are running the tests for. For example, running the > GCC testsuite for Cortex-M0 produces the follwing entry in the logs: Running the testsuite with -mcpu= in runtest/site.exp flags will uncover a whole host of problems with tests that try to specify an architecture. It's essentially broken/unsupported at present. I have some ideas for how to fix this properly, but they will have to wait for gcc-15 now. In the mean time, I'd rather we didn't try to paper over the problem by putting random changes into the tests right now. R. > > Testing gcc.dg/pr41574.c > doing compile > Executing on host: arm-none-eabi-gcc .../pr41574.c -mthumb -march=armv6s-m -mcpu=cortex-m0 -mfloat-abi=soft -fdiagnostics-plain-output -O2 -march=armv7-a -mfloat-abi=softfp -mfpu=neon -fno-unsafe-math-optimizations -fdump-rtl-combine -ffat-lto-objects -S -o pr41574.s (timeout = 800) > spawn -ignore SIGHUP arm-none-eabi-gcc .../pr41574.c -mthumb -march=armv6s-m -mcpu=cortex-m0 -mfloat-abi=soft -fdiagnostics-plain-output -O2 -march=armv7-a -mfloat-abi=softfp -mfpu=neon -fno-unsafe-math-optimizations -fdump-rtl-combine -ffat-lto-objects -S -o pr41574.s > pid is 9799 -9799 > cc1: warning: switch '-mcpu=cortex-m0' conflicts with switch '-march=armv7-a+simd' > pid is -1 > output is cc1: warning: switch '-mcpu=cortex-m0' conflicts with switch '-march=armv7-a+simd' > status 0 > FAIL: gcc.dg/pr41574.c (test for excess errors) > Excess errors: > cc1: warning: switch '-mcpu=cortex-m0' conflicts with switch '-march=armv7-a+simd' > PASS: gcc.dg/pr41574.c scan-rtl-dump-not combine "\\(plus:DF \\(mult:DF" > > Patch has been verified on Linux. > > gcc/testsuite/ChangeLog: > > * gcc.dg/pr41574.c: Disable test for Arm targets incompatible > with -march=armv7-a+simd. > > Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> > --- > gcc/testsuite/gcc.dg/pr41574.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gcc/testsuite/gcc.dg/pr41574.c b/gcc/testsuite/gcc.dg/pr41574.c > index 062c0044532..f6af0c34273 100644 > --- a/gcc/testsuite/gcc.dg/pr41574.c > +++ b/gcc/testsuite/gcc.dg/pr41574.c > @@ -1,6 +1,7 @@ > /* { dg-do compile } */ > -/* { dg-options "-O2 -march=armv7-a -mfloat-abi=softfp -mfpu=neon -fno-unsafe-math-optimizations -fdump-rtl-combine" { target { arm*-*-* } } } */ > -/* { dg-options "-O2 -fno-unsafe-math-optimizations -fdump-rtl-combine" { target { ! arm*-*-* } } } */ > +/* { dg-options "-O2 -fno-unsafe-math-optimizations -fdump-rtl-combine" } */ > +/* { dg-require-effective-target arm_arch_v7a_neon_multilib { target { arm*-*-* } } } */ > +/* { dg-additional-options "-march=armv7-a -mfloat-abi=softfp -mfpu=neon" { target { arm*-*-* } } } */ > > > static const double one=1.0;
diff --git a/gcc/testsuite/gcc.dg/pr41574.c b/gcc/testsuite/gcc.dg/pr41574.c index 062c0044532..f6af0c34273 100644 --- a/gcc/testsuite/gcc.dg/pr41574.c +++ b/gcc/testsuite/gcc.dg/pr41574.c @@ -1,6 +1,7 @@ /* { dg-do compile } */ -/* { dg-options "-O2 -march=armv7-a -mfloat-abi=softfp -mfpu=neon -fno-unsafe-math-optimizations -fdump-rtl-combine" { target { arm*-*-* } } } */ -/* { dg-options "-O2 -fno-unsafe-math-optimizations -fdump-rtl-combine" { target { ! arm*-*-* } } } */ +/* { dg-options "-O2 -fno-unsafe-math-optimizations -fdump-rtl-combine" } */ +/* { dg-require-effective-target arm_arch_v7a_neon_multilib { target { arm*-*-* } } } */ +/* { dg-additional-options "-march=armv7-a -mfloat-abi=softfp -mfpu=neon" { target { arm*-*-* } } } */ static const double one=1.0;