From patchwork Thu Feb 8 10:40:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 198285 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp76577dyd; Thu, 8 Feb 2024 02:41:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IF05UAWk4z8D9kOg9zBnTiyBw20J+qagRflzcB/9l7IbY68+ikIxik6gkEHcMu91xp9mjBG X-Received: by 2002:ae9:e641:0:b0:785:9ed3:3d92 with SMTP id x1-20020ae9e641000000b007859ed33d92mr3821247qkl.27.1707388894777; Thu, 08 Feb 2024 02:41:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707388894; cv=pass; d=google.com; s=arc-20160816; b=Sj0yHz30tefLYfiPiB0jSwe3DHlcgm64lUlJ6p5SvyCHrAakzcXaGSHL2cW8m36wTn BjmRc55JxRPmIvQBLT/CLdNjMiXa3wtuvNjH6vEKX7xTtx80TtIZ720bcnfVJAPE+Oiu TpfIGPbbNseH1w5TPFTqEoMZSChjQ5SlKTCL0A4DKkdbqYIOhiLEBkYGWN4G5nX+nJdh WIY3KeoOSF4n5DEjqBxHSpiqlPRbHeDXhm6m20NpepMIEkA33OJdTpiqX2Ohn1ifGdwi QqKsw/RGAGHm+abM3BUOhkKS3YAifjyM3RnVZGzzOMP0AqO1MRb+6aur/RpYXjnv1QYP FGwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:errors-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :subject:to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=W5DIYRN/Uju/S8pAfnavaTuKCdccj/Ql4nOvHI9swiU=; fh=HUCROen5A4JEwKpprOI7Yg7h63TVimvi12Y9eCWvbAg=; b=wqtdV5MC3tyz2bzIHq8GoS4P0seMp8RMmCbPWc7sijioW4eja8Ndh/XTsqMQO8Fmjr tQ00xznWtFzKbNuqDU9XVOyNjyMEg9xgZRKeot8695emTG2oKLZQl+Vq49aOmySXqa8n wNY1OBga5gHHsX0f3lIgsnHXkeByzlN4QH0/oZ1DMXy0rOp19L2OuxEIwwy7lKXNtZgW EvRCt7KvihqqcP6czpuj+W+YWbdjgcIO/tVCcYyMAgU/5bpgYDPwJOI49qOK9t/I9O4/ fJyX/rOQWK11PC9w6tjQbVxDfSnP/I30zhwTdMw8teJDhl2ESYSkXXYptfe2YVcVDsZ3 2UYw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=jI4KaXin; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=jI4KaXin; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=drlZXHtv; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de X-Forwarded-Encrypted: i=2; AJvYcCWXKq39zZK4TVRzeyD7KKy+n9mrazf3ovfp+VGbgVS+D39tQd+gbmOodWMetrNN1gTL04Y9huz/PT081t/siWPFv5w1wA== Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id vy6-20020a05620a490600b00783b630ea71si2887084qkn.365.2024.02.08.02.41.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 02:41:34 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=jI4KaXin; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=jI4KaXin; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=drlZXHtv; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 773F938582A4 for ; Thu, 8 Feb 2024 10:41:34 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 45B5D385840F for ; Thu, 8 Feb 2024 10:40:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 45B5D385840F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 45B5D385840F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707388844; cv=none; b=RLm54lTcytBi9RNjE86EHEi2GGyCNs2WdSHrLad4VKfK4HLm4eual3/HcGAKhuxgAEIcnQGOYWej0XXSnDMo0S6/B90HKhGhA525EVQaJVSjUg2cxzQZi7n10bRhZkzT0UbeVdgtWlMDVmlOHsB7TONolcKciuzkNYbOJDAgh+w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707388844; c=relaxed/simple; bh=CoJ7Kq2lp0fELG+PM3cN5+NSRDFR436NiI6s0pehyiM=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=bHZplQxgkNRkrZEFKSzI0+/YLLFLMRqai9v0QLJNzrA/qvJEdM/s8PFfXJSS0UfvGHSm3Pz2U75zE3b+aWGwZWZtuFWIVJTiBWxRJkrkLoZXSQlda5hzlE8xHUVN/KBHscElwqaevktEpFyXrrvMzfQFYlyPmxXc3/ZYpisBjoc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3E35321F56 for ; Thu, 8 Feb 2024 10:40:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707388842; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=W5DIYRN/Uju/S8pAfnavaTuKCdccj/Ql4nOvHI9swiU=; b=jI4KaXinskgjy206+F/DGteSsSsvbK0VaJlRJI2G2ndWwK4ixdznesqUpwTH4oFIH1w0Lp SZ5ZcrUoSPPxvHy5stvuGvRk7CIlqzBvN7baJG3TzCIU44ABVu3juQXqNpxb7yPDLOkPo6 g7oOVVtrW02+B1hp0xByggwhKj+hb6k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707388842; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=W5DIYRN/Uju/S8pAfnavaTuKCdccj/Ql4nOvHI9swiU=; b=drlZXHtvUHDZZNRkiKEtEYKeBhIHTPYy3inQa2pN/YV9FVI5zooaRPXdl4A1q3+P4P1uYz fwKaSVPDnPv//RAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707388842; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=W5DIYRN/Uju/S8pAfnavaTuKCdccj/Ql4nOvHI9swiU=; b=jI4KaXinskgjy206+F/DGteSsSsvbK0VaJlRJI2G2ndWwK4ixdznesqUpwTH4oFIH1w0Lp SZ5ZcrUoSPPxvHy5stvuGvRk7CIlqzBvN7baJG3TzCIU44ABVu3juQXqNpxb7yPDLOkPo6 g7oOVVtrW02+B1hp0xByggwhKj+hb6k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707388842; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=W5DIYRN/Uju/S8pAfnavaTuKCdccj/Ql4nOvHI9swiU=; b=drlZXHtvUHDZZNRkiKEtEYKeBhIHTPYy3inQa2pN/YV9FVI5zooaRPXdl4A1q3+P4P1uYz fwKaSVPDnPv//RAQ== Date: Thu, 8 Feb 2024 11:40:42 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Revert part of vect_analyze_early_break_dependences changes MIME-Version: 1.0 Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [1.46 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.94)[86.47%] X-Spam-Score: 1.46 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Message-Id: <20240208104134.773F938582A4@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790327017962399375 X-GMAIL-MSGID: 1790327017962399375 I've reconsidered my last change to dr_may_alias_p and decided it was correct before. The following reverts that change. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. * tree-vect-data-refs.cc (vect_analyze_early_break_dependences): Revert last change to dr_may_alias_p. --- gcc/tree-vect-data-refs.cc | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/gcc/tree-vect-data-refs.cc b/gcc/tree-vect-data-refs.cc index e16796323b3..2170d17e839 100644 --- a/gcc/tree-vect-data-refs.cc +++ b/gcc/tree-vect-data-refs.cc @@ -772,11 +772,7 @@ vect_analyze_early_break_dependences (loop_vec_info loop_vinfo) the store. */ for (auto dr_read : bases) - /* Note we're not passing the DRs in stmt order here - since the DR dependence checking routine does not - envision we're moving stores down. The read-write - order tricks it to avoid applying TBAA. */ - if (dr_may_alias_p (dr_read, dr_ref, loop_nest)) + if (dr_may_alias_p (dr_ref, dr_read, loop_nest)) { if (dump_enabled_p ()) dump_printf_loc (MSG_MISSED_OPTIMIZATION,