From patchwork Sat Feb 3 15:14:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Polacek X-Patchwork-Id: 196319 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:9bc1:b0:106:209c:c626 with SMTP id op1csp1065753dyc; Sat, 3 Feb 2024 07:15:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IE7DYClnb649JDjRCjKJ3U8edupelKnEC5mDMWlxyboK0JEmuLQBLXNgzBoBJCqNhl/16NL X-Received: by 2002:ac8:7f09:0:b0:42a:9a58:bf9e with SMTP id f9-20020ac87f09000000b0042a9a58bf9emr1558031qtk.47.1706973355643; Sat, 03 Feb 2024 07:15:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706973355; cv=pass; d=google.com; s=arc-20160816; b=Sbq9pi06EKaDSDjD9lAXh9WPcQWe+l6F+1vK2KJHMgaiShn49/gWskRcE67bfCDG/v cy+rgl9uQ8zvTeP4mSqNdqImbWc9bZ8t7NIWSkxh1wuh6W9X1ytRmVAFW0sqSjsGi/Zv qFVtKCGCPQSYvO1fwtDMV9nB94BJ/0y3ZGE5Wiyxq+A7ZzudxQxDSh1PfuTxOub1J+CY 7aw+xOESnZPG1ITcPgOxxt/ZkshRHmEQcD4pi9r5jGaXoRzLiTjZFzJBNIIiWJ/e9zGi q8qpcR/lzPYtDEPPkX2qBSWmChvv50M5VA8CiKF6P72XOreSps5z/rDuLZLHkYOYGVoX m+yQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=p9qIBGHDyIJXVGqLjpR6XkZiZe7q2bYuUBq7ShXk8fA=; fh=KcFIl3cGyuDpMKP/rQjdjh6TKASZ2/pm5USJ3emCo/E=; b=aI+n1Y+3VNmyO5MfTKAnkMfWLKnEHm+ypIhbE6Uuv52+w28fo+vNN8ZVzkjN2cZg12 CQIMWd1OgVfwQhsuaX0XHpkvOyplPOEeIGK3OtFJtGg/5+1Rw7dCXpElk52JnuJSAiDK Xac0i0btb4eR4cLvk3qU55CRPzDfqQIy6A0w65lOhPoqrKwEXa6uDH8jBaqbZaMMy5DJ bnUCignse3V71pSybbc+pUXi37txBn31j28iUQTv/1nsHGnQlrcakHUkXD6be5lotpY+ fUpo43WTPHCPx/AWRdKTzfRKm4jHh/B8Xc6b+kyqyQvxqoQXnsEN6BVbxIUMC7SeHd6A gOiA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aJcGAXJ5; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Forwarded-Encrypted: i=1; AJvYcCXwBuZnQduz8vScxsiRymxk9AgGCnK8Gd4/T2hL8yBATaUsGXOFMr9HpmDosMgdr247FfIrr/2xKZe4yds43UhkvHkdCA== Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id s35-20020a05622a1aa300b0042c0b95588fsi2446437qtc.708.2024.02.03.07.15.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 07:15:55 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aJcGAXJ5; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5B5923858289 for ; Sat, 3 Feb 2024 15:15:55 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D4B203858404 for ; Sat, 3 Feb 2024 15:15:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D4B203858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D4B203858404 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706973309; cv=none; b=Hzm2U0YOIjMJG2TnvKVQ39tX0POsg27lbQzErD2zawsLtnQs+ogRCNkZRQHqGvvvnTqJv1zuuCyQhk+2K0byKByqyeBinjli7vnpkqAFnjX+AyJq4WA9aXetuu5muPy9mG7ZG/Hi3NufrkU7+kGDDsmqKY4kJyyJQkySS3gcTxw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706973309; c=relaxed/simple; bh=WSXE0VzSu469kPfskQ4VP9DWXfcR8ERzMpO7H2WaMwo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=sfW7Rb96izTeulTaiIuo/2qPjiHAlVoX8JsuGpRtLO35yz4fqzjPKhLFIAou/5E8jxo9fh//rhp3KEs/hRu4lbaTvWUxPtd9p7AvNr/7eNbysxqc47LPSkYNfRuJWXjes5ZWL/dqjtFI3sXy2T0UXXNtYd2RpxeDl++mJpYrANQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706973307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p9qIBGHDyIJXVGqLjpR6XkZiZe7q2bYuUBq7ShXk8fA=; b=aJcGAXJ5tNvAWXoFPVmXdqMkSok8CffoIWVacHiFYKOWmxTMY+P36YPB8w1YifOTQ8SadF M+cqSWvn1UC9OzKvjjsa2X250ClgEDFU53iw5r3k/0tpTd8h1An02NNUOtfghGYmsmRlX2 g3u9gqQVCwwZkYtFuqH+VhqQ2HOUq/w= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-52-maGSpnl2MFusVEglcW7zVQ-1; Sat, 03 Feb 2024 10:15:06 -0500 X-MC-Unique: maGSpnl2MFusVEglcW7zVQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D3C061064DA3 for ; Sat, 3 Feb 2024 15:15:05 +0000 (UTC) Received: from pdp-11.lan (unknown [10.22.9.204]) by smtp.corp.redhat.com (Postfix) with ESMTP id 61492492BE2; Sat, 3 Feb 2024 15:15:05 +0000 (UTC) From: Marek Polacek To: GCC Patches Cc: Jason Merrill Subject: [PATCH] libitm: small update for C++20 Date: Sat, 3 Feb 2024 10:14:59 -0500 Message-ID: <20240203151459.1198772-1-polacek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789891293379744987 X-GMAIL-MSGID: 1789891293379744987 Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- C++20 DR 2237 disallows simple-template-id in cdtors, so you can't write template struct S { S(); // should be S(); }; This hasn't been a problem until now but I'm adding a warning about it to -Wc++20-compat which libitm apparently uses. libitm/ChangeLog: * containers.h (vector): Remove the template-id in constructors. --- libitm/containers.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) base-commit: 78005c648921899a674d1e561b49b05ccabedfe0 diff --git a/libitm/containers.h b/libitm/containers.h index 2842fa038ed..4160b16d569 100644 --- a/libitm/containers.h +++ b/libitm/containers.h @@ -48,7 +48,7 @@ class vector static const size_t default_resize_min = 32; // Don't try to copy this vector. - vector(const vector& x); + vector(const vector& x); public: typedef T datatype; @@ -59,7 +59,7 @@ class vector T& operator[] (size_t pos) { return entries[pos]; } const T& operator[] (size_t pos) const { return entries[pos]; } - vector(size_t initial_size = default_initial_capacity) + vector(size_t initial_size = default_initial_capacity) : m_capacity(initial_size), m_size(0) { @@ -68,7 +68,7 @@ class vector else entries = 0; } - ~vector() { if (m_capacity) free(entries); } + ~vector() { if (m_capacity) free(entries); } void resize(size_t additional_capacity) {