From patchwork Fri Feb 2 22:47:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 196067 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:9bc1:b0:106:209c:c626 with SMTP id op1csp738853dyc; Fri, 2 Feb 2024 14:48:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IHuNpSFqdxTs5EC0LMU7vhKgBxrd1mUDFiFWHePk3K7371aDIPm9kL022JC5FRxlD42J64e X-Received: by 2002:a5b:a:0:b0:dbc:c93f:aed1 with SMTP id a10-20020a5b000a000000b00dbcc93faed1mr6164723ybp.62.1706914086815; Fri, 02 Feb 2024 14:48:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706914086; cv=pass; d=google.com; s=arc-20160816; b=J20dKSjx4aSIRegD4WQxNRgiJ8GngO6z6wWJdgXS9kL5ehpHf8Wr2WWDl1nbCzhLzU +xkFsaaV4AwYnalD4IC5L8ojpeYzj7wEPMca1Hxo//7Io2Us8xAT57De7oTCq8rnXdDX D6EOyIc63W5hTLWGJL0eeqoV9x/DJYI/r7vvcjtIswjBTbezK0lsnliyN8S7SG0wkPw3 NYR0OXKJVCkl+i2QV8noYdn1Y7U3mfksLZOzwlBbTMzo2PrdagDwj0O7CR0etsgGIzMj AGtbZYvPgsn4qvAfbrmJhSrFI7K2QMu+p7nLbv6vBTdfORM9K81zcXBn5i26BVtSg/4C tEpg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=xW2dyKnJ+vEqCrlWgdPRB24B4CAVh6BK8XNnmbdmW0U=; fh=/S+YJHhD9aVgCX+ynDCfqKNxotI0h2demRyJ0bwmRCA=; b=dwxuI3GDU7ZAeI/QilvnXbyNQwuedMEESy3pE1+A0cjdzfJN2sBY4u1AykH4y2nXz1 Hfn7lyTs3OazmZTnm+UjnTVo+XZjoi5R3oepgcOg2azcD0acc0ooP0J7bx0TJXKTOdtO +4B2DRVse+1trmnC8eiTLZo7bkYin4YgFFEZb65fBiRGhhAki6m55XVGz9MnW2sHQMQx 05RkHaq9d2mD8cZ9iB6bpRzGCucdbeBPuS7ROvV1tmGBy0lCPKQDHFY/QKsrX97U8gkF XrTwkIsNjkfVwdB5mazQnchvU1Iv2H9K6eGtYuLHB60E2sd3P9Nja2OXlO/oIb5LE6fE ld5Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=mDoz7c99; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com X-Forwarded-Encrypted: i=1; AJvYcCX6IQzewMNeXUWWm/NadVBXIQ7QPe+bmZNzn0b1uJWixWpK9NlGIJtn3Qi1HGirZutdICc1gqSA4dicd1P+Lp8as7O0aA== Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id ep2-20020a05621418e200b0068c3e1625b4si2906863qvb.587.2024.02.02.14.48.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 14:48:06 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=mDoz7c99; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 81BB5385842F for ; Fri, 2 Feb 2024 22:48:06 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 52E603858C33 for ; Fri, 2 Feb 2024 22:47:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 52E603858C33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 52E603858C33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706914037; cv=none; b=dyDxUgnYUadatnswei8aUzpSHFq0UE0LrK1e8596TteNQpqLCXNclHYbQJBqyDaUblC9HcW9N7nGskJwKFMb9lRbd/jPVjDIPqUTkxRLOtkhu+ggNv0FHgA4mFfUjjGEui0bpEZY6uEzxH3RAg/jhoeMsJMSX5AgkSnKmhPWYD0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706914037; c=relaxed/simple; bh=bD/X797XlAGbALulf3zaqaxOeOEna4koyh7BI/mzyHs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AVCfqNcG7SFpkxtKL3vHy9M0tu7bhCZRbE5U0rGb1ieAogSBKBvuSvQYorxrmel7zD9gu/QJ+jtrOZ0iqnLjuMyFtrMfjrVrZ1Id8SRBiRQTptLx5nUKBc5iPfeTtCDq53ip+jqnsJyf8jPVPTqW+FqzExHcU18vwKiqMggW80s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6df60be4a1dso1932238b3a.3 for ; Fri, 02 Feb 2024 14:47:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706914031; x=1707518831; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xW2dyKnJ+vEqCrlWgdPRB24B4CAVh6BK8XNnmbdmW0U=; b=mDoz7c99Km4zXzqKt0022/bp0Ou1s5mUj7AMQjTGhUSo4DmdVk9BG0K7FAz7/OKqtr O+Di7zg/CpT+v2+f6WnAk284XJKD+FuuaIxLYrvPOFlMP3YJh3bXNRdKSSd3eXQdO9tJ wxd8LqOSW/wnx3A7JKV3BE7hn72Fc3ugOJlxeSqnNYXAr3ccv6LhdxpipyMgfeXzkcUt XQIm95AD6UmPzf2O/Pqhwegzm27CWMZObTwgBb7TX00rHg+5YuQPqe+AWixqwq2X7T63 qPBCSbYk8iD2qJLbDierWoH9fMjztF8Do4KFYJUo4irC9G0XfJjyEtttZW7cj9vr/G3Y YOzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706914031; x=1707518831; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xW2dyKnJ+vEqCrlWgdPRB24B4CAVh6BK8XNnmbdmW0U=; b=IIC15l78SQiT1i/fgVjia9lzweF92g/Awoh44lCB24EMbFMPTh7SVq53yv/vActmUT ZgPuexF9bAR7y7/LMCZkEmieCqHvcs+O+roiV2I0DSVJ5CXFen7+ZZCf9r3Xeex15XvM TC21K8kRE5b4m2LYLpeyJJRA2tMc4jzu9Ms//fJQ7AgATxdPGZc3Q0HBMOTclfkgizUV vYwBYNulujnzYW3/GBx6mV52V6tEZ5KeGDj1NoD0q/loYIJqY9DaoFH+L2t3peDXMdnb 8Hx/STtkCJxLxhYChnjti90L+Ty3DcwjaHLyitBRI/on55C+PUtW+nIPwplmmQ3myY0j Utgw== X-Gm-Message-State: AOJu0Ywxc28CgVthnQbWno7qGkSpHUvNbovS95hOiIGZ6ITCzxloWfOo r4QdojBvZJkcVqASlyYqG2MlU+uTCRSb4U45b9crbXbxwquMuHYFIV5r4HZ4 X-Received: by 2002:a05:6a00:2719:b0:6dd:a004:c193 with SMTP id x25-20020a056a00271900b006dda004c193mr5968793pfv.12.1706914030724; Fri, 02 Feb 2024 14:47:10 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUTMXrMHB+sv9inOy7ULeqW6Kfzd3sNV7r70iDFXp0CVahggpY7YLZXr0CIU5mBeZ+BKQ/eQuEknbn48qKjFVijEjasjYg+Nrv8RfPlseXDhhHodQ== Received: from gnu-cfl-3.localdomain ([172.56.169.51]) by smtp.gmail.com with ESMTPSA id x9-20020aa784c9000000b006dde35245d8sm2162621pfn.58.2024.02.02.14.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 14:47:10 -0800 (PST) Received: from gnu-cfl-3.. (localhost [IPv6:::1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id 0AD06740172; Fri, 2 Feb 2024 14:47:09 -0800 (PST) From: "H.J. Lu" To: gcc-patches@gcc.gnu.org Cc: rep.dot.nop@gmail.com, jakub@redhat.com, ubizjak@gmail.com Subject: [PATCH v5] x86-64: Find a scratch register for large model profiling Date: Fri, 2 Feb 2024 14:47:08 -0800 Message-ID: <20240202224708.343462-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3023.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789802394587310514 X-GMAIL-MSGID: 1789829145438155691 Changes in v5: 1. Add pr113689-3.c. 2. Use %r10 if ix86_profile_before_prologue () return true. 3. Try a callee-saved register which has been saved on stack in the prologue. Changes in v4: 1. Remove pr113689-3.c. 2. Use df_get_live_out. Changes in v3: 1. Remove r10_ok. Changes in v2: 1. Add int_parameter_registers to machine_function to track integer registers used for parameter passing. 2. Update x86_64_select_profile_regnum to try %r10 first and use an caller-saved register, which isn't used for parameter passing. --- 2 scratch registers, %r10 and %r11, are available at function entry for large model profiling. But %r10 may be used by stack realignment and we can't use %r10 in this case. Add x86_64_select_profile_regnum to find a caller-saved register which isn't live or a callee-saved register which has been saved on stack in the prologue at entry for large model profiling and sorry if we can't find one. gcc/ PR target/113689 * config/i386/i386.cc (set_saved_int_registers_bit): New. (test_saved_int_registers_bit): Likewise. (ix86_emit_save_regs): Call set_saved_int_registers_bit on saved register. (ix86_emit_save_regs_using_mov): Likewise. (x86_64_select_profile_regnum): New. (x86_function_profiler): Call x86_64_select_profile_regnum to get a scratch register for large model profiling. * config/i386/i386.h (machine_function): Add saved_int_registers. gcc/testsuite/ PR target/113689 * gcc.target/i386/pr113689-1.c: New file. * gcc.target/i386/pr113689-2.c: Likewise. * gcc.target/i386/pr113689-3.c: Likewise. --- gcc/config/i386/i386.cc | 119 ++++++++++++++++++--- gcc/config/i386/i386.h | 5 + gcc/testsuite/gcc.target/i386/pr113689-1.c | 49 +++++++++ gcc/testsuite/gcc.target/i386/pr113689-2.c | 41 +++++++ gcc/testsuite/gcc.target/i386/pr113689-3.c | 48 +++++++++ 5 files changed, 247 insertions(+), 15 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr113689-1.c create mode 100644 gcc/testsuite/gcc.target/i386/pr113689-2.c create mode 100644 gcc/testsuite/gcc.target/i386/pr113689-3.c diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc index b3e7c74846e..1c7aaa4535e 100644 --- a/gcc/config/i386/i386.cc +++ b/gcc/config/i386/i386.cc @@ -7387,6 +7387,32 @@ choose_baseaddr (HOST_WIDE_INT cfa_offset, unsigned int *align, return plus_constant (Pmode, base_reg, base_offset); } +/* Set the integer register REGNO bit in saved_int_registers. */ + +static void +set_saved_int_registers_bit (int regno) +{ + if (LEGACY_INT_REGNO_P (regno)) + cfun->machine->saved_int_registers |= 1 << regno; + else + cfun->machine->saved_int_registers + |= 1 << (regno - FIRST_REX_INT_REG + 8); +} + +/* Return true if the integer register REGNO bit in saved_int_registers + is set. */ + +static bool +test_saved_int_registers_bit (int regno) +{ + if (LEGACY_INT_REGNO_P (regno)) + return (cfun->machine->saved_int_registers + & (1 << regno)) != 0; + else + return (cfun->machine->saved_int_registers + & (1 << (regno - FIRST_REX_INT_REG + 8))) != 0; +} + /* Emit code to save registers in the prologue. */ static void @@ -7403,6 +7429,7 @@ ix86_emit_save_regs (void) insn = emit_insn (gen_push (gen_rtx_REG (word_mode, regno), TARGET_APX_PPX)); RTX_FRAME_RELATED_P (insn) = 1; + set_saved_int_registers_bit (regno); } } else @@ -7415,6 +7442,7 @@ ix86_emit_save_regs (void) for (regno = FIRST_PSEUDO_REGISTER - 1; regno >= 0; regno--) if (GENERAL_REGNO_P (regno) && ix86_save_reg (regno, true, true)) { + set_saved_int_registers_bit (regno); if (aligned) { regno_list[loaded_regnum++] = regno; @@ -7567,6 +7595,7 @@ ix86_emit_save_regs_using_mov (HOST_WIDE_INT cfa_offset) { ix86_emit_save_reg_using_mov (word_mode, regno, cfa_offset); cfa_offset -= UNITS_PER_WORD; + set_saved_int_registers_bit (regno); } } @@ -22749,6 +22778,48 @@ current_fentry_section (const char **name) return true; } +/* Return a caller-saved register which isn't live or a callee-saved + register which has been saved on stack in the prologue at entry for + profile. */ + +static int +x86_64_select_profile_regnum (bool r11_ok ATTRIBUTE_UNUSED) +{ + /* Use %r10 if the profiler is emitted before the prologue or it isn't + used by DRAP. */ + if (ix86_profile_before_prologue () + || !crtl->drap_reg + || REGNO (crtl->drap_reg) != R10_REG) + return R10_REG; + + /* The profiler is emitted after the prologue. If there is a + caller-saved register which isn't live or a callee-saved + register saved on stack in the prologue, use it. */ + + bitmap reg_live = df_get_live_out (ENTRY_BLOCK_PTR_FOR_FN (cfun)); + + int i; + for (i = 0; i < FIRST_PSEUDO_REGISTER; i++) + if (GENERAL_REGNO_P (i) + && i != R10_REG +#ifdef NO_PROFILE_COUNTERS + && (r11_ok || i != R11_REG) +#else + && i != R11_REG +#endif + && (!REX2_INT_REGNO_P (i) || TARGET_APX_EGPR) + && !fixed_regs[i] + && (test_saved_int_registers_bit (i) + || (call_used_regs[i] + && !REGNO_REG_SET_P (reg_live, i)))) + return i; + + sorry ("no register available for profiling %<-mcmodel=large%s%>", + ix86_cmodel == CM_LARGE_PIC ? " -fPIC" : ""); + + return INVALID_REGNUM; +} + /* Output assembler code to FILE to increment profiler label # LABELNO for profiling a function entry. */ void @@ -22783,42 +22854,60 @@ x86_function_profiler (FILE *file, int labelno ATTRIBUTE_UNUSED) fprintf (file, "\tleaq\t%sP%d(%%rip), %%r11\n", LPREFIX, labelno); #endif + int scratch; + const char *reg_prefix; + const char *reg; + if (!TARGET_PECOFF) { switch (ix86_cmodel) { case CM_LARGE: - /* NB: R10 is caller-saved. Although it can be used as a - static chain register, it is preserved when calling - mcount for nested functions. */ + scratch = x86_64_select_profile_regnum (true); + reg = hi_reg_name[scratch]; + reg_prefix = LEGACY_INT_REGNO_P (scratch) ? "r" : ""; if (ASSEMBLER_DIALECT == ASM_INTEL) - fprintf (file, "1:\tmovabs\tr10, OFFSET FLAT:%s\n" - "\tcall\tr10\n", mcount_name); + fprintf (file, + "1:\tmovabs\t%s%s, OFFSET FLAT:%s\n" + "\tcall\t%s%s\n", + reg_prefix, reg, mcount_name, reg_prefix, reg); else - fprintf (file, "1:\tmovabsq\t$%s, %%r10\n\tcall\t*%%r10\n", - mcount_name); + fprintf (file, + "1:\tmovabsq\t$%s, %%%s%s\n\tcall\t*%%%s%s\n", + mcount_name, reg_prefix, reg, reg_prefix, reg); break; case CM_LARGE_PIC: #ifdef NO_PROFILE_COUNTERS + scratch = x86_64_select_profile_regnum (false); + reg = hi_reg_name[scratch]; + reg_prefix = LEGACY_INT_REGNO_P (scratch) ? "r" : ""; if (ASSEMBLER_DIALECT == ASM_INTEL) { fprintf (file, "1:movabs\tr11, " "OFFSET FLAT:_GLOBAL_OFFSET_TABLE_-1b\n"); - fprintf (file, "\tlea\tr10, 1b[rip]\n"); - fprintf (file, "\tadd\tr10, r11\n"); + fprintf (file, "\tlea\t%s%s, 1b[rip]\n", + reg_prefix, reg); + fprintf (file, "\tadd\t%s%s, r11\n", + reg_prefix, reg); fprintf (file, "\tmovabs\tr11, OFFSET FLAT:%s@PLTOFF\n", mcount_name); - fprintf (file, "\tadd\tr10, r11\n"); - fprintf (file, "\tcall\tr10\n"); + fprintf (file, "\tadd\t%s%s, r11\n", + reg_prefix, reg); + fprintf (file, "\tcall\t%s%s\n", + reg_prefix, reg); break; } fprintf (file, "1:\tmovabsq\t$_GLOBAL_OFFSET_TABLE_-1b, %%r11\n"); - fprintf (file, "\tleaq\t1b(%%rip), %%r10\n"); - fprintf (file, "\taddq\t%%r11, %%r10\n"); + fprintf (file, "\tleaq\t1b(%%rip), %%%s%s\n", + reg_prefix, reg); + fprintf (file, "\taddq\t%%r11, %%%s%s\n", + reg_prefix, reg); fprintf (file, "\tmovabsq\t$%s@PLTOFF, %%r11\n", mcount_name); - fprintf (file, "\taddq\t%%r11, %%r10\n"); - fprintf (file, "\tcall\t*%%r10\n"); + fprintf (file, "\taddq\t%%r11, %%%s%s\n", + reg_prefix, reg); + fprintf (file, "\tcall\t*%%%s%s\n", + reg_prefix, reg); #else sorry ("profiling %<-mcmodel=large%> with PIC is not supported"); #endif diff --git a/gcc/config/i386/i386.h b/gcc/config/i386/i386.h index 35ce8b00d36..33821a04074 100644 --- a/gcc/config/i386/i386.h +++ b/gcc/config/i386/i386.h @@ -2847,6 +2847,11 @@ struct GTY(()) machine_function { /* True if red zone is used. */ BOOL_BITFIELD red_zone_used : 1; + /* Bit mask for integer registers saved on stack in prologue. The + lower 8 bits are for legacy registers and the upper 8 bits are + for r8-r15. */ + unsigned int saved_int_registers : 16; + /* The largest alignment, in bytes, of stack slot actually used. */ unsigned int max_used_stack_alignment; diff --git a/gcc/testsuite/gcc.target/i386/pr113689-1.c b/gcc/testsuite/gcc.target/i386/pr113689-1.c new file mode 100644 index 00000000000..8285c0a07b7 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr113689-1.c @@ -0,0 +1,49 @@ +/* { dg-do run { target { lp64 && fpic } } } */ +/* { dg-options "-O2 -fno-pic -fprofile -mcmodel=large" } */ + +#include + +__attribute__((noipa)) +void +bar (int a1, int a2, int a3, int a4, int a5, int a6, + char *x, char *y, int *z) +{ + if (a1 != 1) + __builtin_abort (); + if (a2 != 2) + __builtin_abort (); + if (a3 != 3) + __builtin_abort (); + if (a4 != 4) + __builtin_abort (); + if (a5 != 5) + __builtin_abort (); + if (a6 != 6) + __builtin_abort (); + x[0] = 42; + y[0] = 42; + if (z[0] != 16) + __builtin_abort (); +} + +__attribute__((noipa)) +void +foo (int c, int d, int e, int f, int g, int h, int z, ...) +{ + typedef char B[32]; + B b __attribute__((aligned (32))); + va_list ap; + va_start (ap, z); + double x = va_arg (ap, double); + if (x > 40.0) + __builtin_abort (); + bar (c, d, e, f, g, h, &b[0], __builtin_alloca (z), &z); + va_end (ap); +} + +int +main () +{ + foo (1, 2, 3, 4, 5, 6, 16, 38.0); + return 0; +} diff --git a/gcc/testsuite/gcc.target/i386/pr113689-2.c b/gcc/testsuite/gcc.target/i386/pr113689-2.c new file mode 100644 index 00000000000..2e5579ac546 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr113689-2.c @@ -0,0 +1,41 @@ +/* { dg-do run { target { lp64 && fpic } } } */ +/* { dg-options "-O2 -fpic -fprofile -mcmodel=large" } */ + +__attribute__((noipa)) +void +bar (int a1, int a2, int a3, int a4, int a5, int a6, + char *x, char *y, int *z) +{ + if (a1 != 1) + __builtin_abort (); + if (a2 != 2) + __builtin_abort (); + if (a3 != 3) + __builtin_abort (); + if (a4 != 4) + __builtin_abort (); + if (a5 != 5) + __builtin_abort (); + if (a6 != 6) + __builtin_abort (); + x[0] = 42; + y[0] = 42; + if (z[0] != 16) + __builtin_abort (); +} + +__attribute__((noipa)) +void +foo (int c, int d, int e, int f, int g, int h, int z) +{ + typedef char B[32]; + B b __attribute__((aligned (32))); + bar (c, d, e, f, g, h, &b[0], __builtin_alloca (z), &z); +} + +int +main () +{ + foo (1, 2, 3, 4, 5, 6, 16); + return 0; +} diff --git a/gcc/testsuite/gcc.target/i386/pr113689-3.c b/gcc/testsuite/gcc.target/i386/pr113689-3.c new file mode 100644 index 00000000000..dab75190635 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr113689-3.c @@ -0,0 +1,48 @@ +/* { dg-do run { target { lp64 && fpic } } } */ +/* { dg-options "-O2 -fpic -fprofile -mcmodel=large" } */ + +#include + +__attribute__((noipa)) +void +bar (char *x, char *y, int *z) +{ + x[0] = 42; + y[0] = 42; + if (z[0] != 16) + __builtin_abort (); +} + +__attribute__((noipa)) +void +foo (int a1, int a2, int a3, int a4, int a5, int a6, int z, ...) +{ + typedef char B[32]; + B b __attribute__((aligned (32))); + va_list ap; + va_start (ap, z); + double x = va_arg (ap, double); + if (x > 40.0) + __builtin_abort (); + if (a1 != 1) + __builtin_abort (); + if (a2 != 2) + __builtin_abort (); + if (a3 != 3) + __builtin_abort (); + if (a4 != 4) + __builtin_abort (); + if (a5 != 5) + __builtin_abort (); + if (a6 != 6) + __builtin_abort (); + bar (&b[0], __builtin_alloca (z), &z); + va_end (ap); +} + +int +main () +{ + foo (1, 2, 3, 4, 5, 6, 16, 38.0); + return 0; +}