From patchwork Fri Feb 2 10:24:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 195779 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:9bc1:b0:106:209c:c626 with SMTP id op1csp331827dyc; Fri, 2 Feb 2024 02:26:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IES2VCs6FQaSZlgyna4TavcJ6kNXKp0vqEG6FrlMCD2oVfE+lTaDKLHgs6HbpwFbqOVcYiR X-Received: by 2002:a67:cd93:0:b0:46d:949:414 with SMTP id r19-20020a67cd93000000b0046d09490414mr129799vsl.18.1706869598114; Fri, 02 Feb 2024 02:26:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706869598; cv=pass; d=google.com; s=arc-20160816; b=MGPMbH4j0kpFN+lxOP8FirClhp6u2W/ykG8gcU7Q+O7iBobT6KsI4SUOyFU6idRPXi PWVvnOpJAjUYv/JzD7V3rvNX95AyXBE4tGgVG/62C5JFcrw4u+wmMnCNERIHrNPBFIlq lebt821IbFgCBa669zVPCfEtWIfuINCLNDGCmkPcxHsL7RIl05/ZrROZsdUy4I53qcls Sz4izGGClrt62kNfZwGHrkZnOjI+GHT7MHAr1WjSgGRNSmSwJqdQomAs+2ZbaZltI7wM o8vV0ZWLM32Y+fGTbeOUYA6VxQsEQItsMAPduX5ch382CJMmSPivV+oz1HmTFKd5olbN fBPQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=7N3QhBbUxVAsYFcVa48+gUhenc0bM506vxpWTBN4G/s=; fh=o7EM90rfE1mVUCLFd2X7WV/7raqMpOfI4KeHStgyXu0=; b=QEtoqbHzxjiS2CKDnWzOs0IVUY+a4cbPbt2wp+9qiFWHs+/IUWZu3Qgzfxfnr/FVw0 THYCwag1FwhpMZSGnf7uXaawCeGURx4sTYgvJtCmVD7Cv5wOoTmctUrcDqPXLoh6Etxy O0zK5jdK7kSZBapo4r1ngKMi49WATANsblRAmmrCkI8NTjTnh0KxIIlgGH1xRBEBFBG4 ZbIl1srp/0GCtXgrThKPcrTACeap3iEoRwyulBR142aE1x/uX8gIOtrw51QrAdpoO+Jc X6C4nopJgaDKNVlqyhg37YrPoBVwd7442VN9Ws6geR8x8ncfKSeU/5y6z0JEQjXMVnE9 8s4A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ideG52Kd; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Forwarded-Encrypted: i=1; AJvYcCX78KOxj/jjlgxmFPrEZaIDjEyrAiSYPhE4XEZ46moXzB1QxR+3WBDRfEILhqw9nO7eoCO0B4Nf2dXw85m5xdXxQurHaA== Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id d4-20020a0cfe84000000b0068c405115dbsi1701730qvs.169.2024.02.02.02.26.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 02:26:38 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ideG52Kd; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CAA9C3857C65 for ; Fri, 2 Feb 2024 10:26:37 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 00470385802B for ; Fri, 2 Feb 2024 10:25:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00470385802B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 00470385802B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706869507; cv=none; b=ij/D+j6qveccRGJwVrOSE3MCDGRs72xh/P2ZUr6fOvf4bHlGSjuJ4ucIHllVeUncKGT7mAm2K5m9KvzjTMzzgIZNg1zMdhAUjZBfP3lX73FCj5stb7irfbsdxTpV7xtZ2e5IUMAKR56jKX1F0no98o5G/nozS5cU9nBeRlXy2Lk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706869507; c=relaxed/simple; bh=plcDgRnsYZU3PD9pFobTGOvLSeI++oekAiL+sBWCvKc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=H6zIo8M6lzN4gPmOEr2CSqPlxlKd/BKROKVngi4TPzzXGqlc5O3pZJ5yzBpeMkeqjhOaFjW0W5weTJBrd9TpDledcoJKWXojd/FqNuAQQ/0/ftNepFDf92hhKXy8kAix6PUeHo/Eb+YAxRzwqtAhDYevqSFEqQP5A1BUUxz3rO8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706869505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7N3QhBbUxVAsYFcVa48+gUhenc0bM506vxpWTBN4G/s=; b=ideG52Kda+W9hj4FnJQFRt/ijCjGOgqw0JUY4bOICZtyrAIB0gWtFJkoVi3DXFAlhXUFMS acps812oqujmrloIyM7g0svkCn6ovBVEOH59Of1b0xUN3s+uy7XmmFsqRtnKgP3JfYOrBT QI8F5zB2sINnKp8IjHoKUvJq1VsU0Hw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-sQm_wZxgNYm0EHO_4yVf6A-1; Fri, 02 Feb 2024 05:25:04 -0500 X-MC-Unique: sQm_wZxgNYm0EHO_4yVf6A-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 07EA885A58C; Fri, 2 Feb 2024 10:25:04 +0000 (UTC) Received: from localhost (unknown [10.42.28.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9A4E492BE2; Fri, 2 Feb 2024 10:25:03 +0000 (UTC) From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [committed] libstdc++: Remove noexcept from std::osyncstream::operator= Date: Fri, 2 Feb 2024 10:24:42 +0000 Message-ID: <20240202102459.2239841-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789782495530676336 X-GMAIL-MSGID: 1789782495530676336 Tested aarch64-linux. Pushed to trunk. -- >8 -- This should not be noexcept because its _M_syncbuf member has a potentially-throwing move assignment operator. The noexcept was removed by LWG 3867. libstdc++-v3/ChangeLog: * include/std/syncstream (basic_osyncstream::operator=): Remove noexcept, as per LWG 3867. --- libstdc++-v3/include/std/syncstream | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libstdc++-v3/include/std/syncstream b/libstdc++-v3/include/std/syncstream index a84c93a61ee..08a901b62fd 100644 --- a/libstdc++-v3/include/std/syncstream +++ b/libstdc++-v3/include/std/syncstream @@ -285,7 +285,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION ~basic_osyncstream() = default; - basic_osyncstream& operator=(basic_osyncstream&&) noexcept = default; + basic_osyncstream& operator=(basic_osyncstream&&) = default; syncbuf_type* rdbuf() const noexcept { return const_cast(&_M_syncbuf); }