From patchwork Wed Jan 31 09:07:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 194628 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp1764067dyb; Wed, 31 Jan 2024 01:14:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IFRXU/EA8jfsF8wwCKcsl0nAdxgMyKIP20AIFUQ2R6H0oTNGzXB3NDIvcaDNVKY87VVicK5 X-Received: by 2002:a05:622a:13d2:b0:42a:8462:29f2 with SMTP id p18-20020a05622a13d200b0042a846229f2mr1362216qtk.49.1706692452983; Wed, 31 Jan 2024 01:14:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706692452; cv=pass; d=google.com; s=arc-20160816; b=Cj7BjcWms6IiZY3/udn7nwPHO0jSX8gnMYLu2DQsx4TFH9vcpQrsYK9tDj4a2yKtJm RY7zTgMTEkcae62XmR1/w8uS8CGyTvuwwgICXljsVQw/h/9s/AXKEZik40ipTjqczn0v ROaAs3n7AvWPhegzgI7yRag2ecIeed6IZ7PoJxTCgGQkANArzdrpuuJvVaSp6Iy1EdHo FwEwT8tQQH5modpokZgQF4QoBpNt1fSiYUY5UBN0dj82G1LZbba1usaxc+7HUStyiBd6 9CrcuVxQmdF5segmVYAduVsq6AYC0QhRgwvdtbXNb34lGMg286yUdOvLsaJ//S+QsqYK o3YA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:errors-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :subject:to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=FvoGiK7nLrclSGzYIe+Sk7NQ7PGX79zho9OT0tCoKJ0=; fh=LSLdjVlOi8mTk62JyqBhadJCmkF2RFps/XPvVIwBNkY=; b=SFoEFL3Yzjoa0OuUz36PQSBhZD/FY0kZBHKwsqxV3vaLOwPUndCRpah9Vp7rPP4byH GLXRAul0GjW81vGOg0VrD6p1yAnCrKpKkN0nakelB5ckhegVUKmhstJfm+r3NP6BHaqn KVwjaKb6b4IHLaJbNRj7n9CDWfp++JMaSqBl/bE3LF15hN0WrHh4BWvpyV3GZ7nSNMWl zcHw3kNTfTGEzbrZE245i4vNyEwJ3+H5kDb6TAhx6Ofbn7Xc92aAOfnSOlcJgFo0WCUI g3CaOJQarBpe/OI2LtYFrFrQ5AtAvxH5odlGKvFg2gbiWZk/BhJDs0UGbZ7Pmv9MPrk3 xpgg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=P1UmGYGw; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=P1UmGYGw; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de X-Forwarded-Encrypted: i=1; AJvYcCX7QTc5EAfueQN4NxTueJnpMa2KL9AEM9y1ZCn8CVo3hkHFTyMEWXZM9ZcpCL2EPPWMxNQ+ukCWHbdOyRFh3h+JafiYow== Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id a15-20020a05622a064f00b0042bebf7d7acsi336180qtb.730.2024.01.31.01.14.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 01:14:12 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=P1UmGYGw; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=P1UmGYGw; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A32233858D32 for ; Wed, 31 Jan 2024 09:14:12 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id CCF563858D32 for ; Wed, 31 Jan 2024 09:13:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CCF563858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CCF563858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706692398; cv=none; b=tDFnOKPq9GnBKY8pvNvmM8TjuT+mn0ccuWEenILE1FHQwpwsbBfPBOGMLyjrVVGnDagvF/68oKBZkQnLcgtaGs2oOTbqoAyHeTZmJNNCW37RZEM7gfdg6caw8HQRCa9Jk1yP6ycI7hVhzkJY2Z5ywGE7nTYau3Le5CdwTSr2cyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706692398; c=relaxed/simple; bh=bW3BKWRyPImOL7Wt/tCnlgG3ii7xljFAwBMvJ50E52U=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=nDcAAPuPm1g0xRDJEYlKdvVpd+/MvKgU/olwCc9rrb2Ny4BKpkNDpjZALOhpVd7KN3lyvsTyWb6wuuYnr+HlHZlUQJpSZutN20TJmvTgMPu67jArdzBbhogh0fLZmZeXYMIzuzEDpBEJKHXM7NPWiOCNK+pTatXKaaqNn1y6wis= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 923EB21FFD for ; Wed, 31 Jan 2024 09:13:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706692395; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=FvoGiK7nLrclSGzYIe+Sk7NQ7PGX79zho9OT0tCoKJ0=; b=P1UmGYGwiSUGS4xo6EzYzdh9c4Yhwqt/jszB0gfqQdXd4u1fjlpFBkMKZf9ZWaYfGNrgk3 81WLhoQWMVRWIrbWEx1sERvRS4aMXLWDkcFoCbqGx56Xgw9YvP9W1tBwhFK1eRMZkqI55d n8uFz8cJhJKGHgom9GDL8SIW9lfc9mI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706692395; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=FvoGiK7nLrclSGzYIe+Sk7NQ7PGX79zho9OT0tCoKJ0=; b=yEFf1tOo8AML3Pa3szFPu7v6k77D3aVg2234N4Ho40DfBwrfuyYUVarPeK74oweA292kAC x3enpuWlpV3UJeCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706692395; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=FvoGiK7nLrclSGzYIe+Sk7NQ7PGX79zho9OT0tCoKJ0=; b=P1UmGYGwiSUGS4xo6EzYzdh9c4Yhwqt/jszB0gfqQdXd4u1fjlpFBkMKZf9ZWaYfGNrgk3 81WLhoQWMVRWIrbWEx1sERvRS4aMXLWDkcFoCbqGx56Xgw9YvP9W1tBwhFK1eRMZkqI55d n8uFz8cJhJKGHgom9GDL8SIW9lfc9mI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706692395; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=FvoGiK7nLrclSGzYIe+Sk7NQ7PGX79zho9OT0tCoKJ0=; b=yEFf1tOo8AML3Pa3szFPu7v6k77D3aVg2234N4Ho40DfBwrfuyYUVarPeK74oweA292kAC x3enpuWlpV3UJeCg== Date: Wed, 31 Jan 2024 10:07:38 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/113670 - gather/scatter to/from hard registers MIME-Version: 1.0 Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -1.64 X-Spamd-Result: default: False [-1.64 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.85)[-0.850]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.19)[-0.930]; DBL_BLOCKED_OPENRESOLVER(0.00)[gcc.target:url]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%] X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Message-Id: <20240131091412.A32233858D32@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789596745859261423 X-GMAIL-MSGID: 1789596745859261423 The following makes sure we're not taking the address of hard registers when vectorizing appearant gathers or scatters to/from them. Bootstrapped and tested on x86_64-unkown-linux-gnu, pushed. PR tree-optimization/113670 * tree-vect-data-refs.cc (vect_check_gather_scatter): Make sure we can take the address of the reference base. * gcc.target/i386/pr113670.c: New testcase. --- gcc/testsuite/gcc.target/i386/pr113670.c | 16 ++++++++++++++++ gcc/tree-vect-data-refs.cc | 5 +++++ 2 files changed, 21 insertions(+) create mode 100644 gcc/testsuite/gcc.target/i386/pr113670.c diff --git a/gcc/testsuite/gcc.target/i386/pr113670.c b/gcc/testsuite/gcc.target/i386/pr113670.c new file mode 100644 index 00000000000..8b9d3744fe2 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr113670.c @@ -0,0 +1,16 @@ +/* { dg-do compile } */ +/* { dg-options "-msse2 -O2 -fno-vect-cost-model" } */ + +typedef float __attribute__ ((vector_size (16))) vec; +typedef int __attribute__ ((vector_size (16))) ivec; +ivec x; + +void +test (void) +{ + register vec a asm("xmm3"), b asm("xmm4"); + register ivec c asm("xmm5"); + for (int i = 0; i < 4; i++) + c[i] = a[i] < b[i] ? -1 : 1; + x = c; +} diff --git a/gcc/tree-vect-data-refs.cc b/gcc/tree-vect-data-refs.cc index f592aeb8028..e6a3035064b 100644 --- a/gcc/tree-vect-data-refs.cc +++ b/gcc/tree-vect-data-refs.cc @@ -4325,6 +4325,11 @@ vect_check_gather_scatter (stmt_vec_info stmt_info, loop_vec_info loop_vinfo, if (!multiple_p (pbitpos, BITS_PER_UNIT)) return false; + /* We need to be able to form an address to the base which for example + isn't possible for hard registers. */ + if (may_be_nonaddressable_p (base)) + return false; + poly_int64 pbytepos = exact_div (pbitpos, BITS_PER_UNIT); if (TREE_CODE (base) == MEM_REF)