Message ID | 20240130121026.807464-77-arthur.cohen@embecosm.com |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp1193576dyb; Tue, 30 Jan 2024 04:48:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFeHaCcv2/Q1yNaPCFlgignrexjOImFv1XvGap2Lu0Wu4B4ExZqQJuD2fv5UD7e+0HQ0MuF X-Received: by 2002:a05:6214:27ca:b0:68c:61af:49e9 with SMTP id ge10-20020a05621427ca00b0068c61af49e9mr1128041qvb.61.1706618886805; Tue, 30 Jan 2024 04:48:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706618886; cv=pass; d=google.com; s=arc-20160816; b=Wln1QilgBUvDTutOXWv4NN0+8GqTXIfO0zofyvnTEIvxiVhg5kqD+eQTy+Zq8WihBm n9SBq/OTQlfMugOoctyfNU4p1KMI9HJNBc/Qpd8jDBlwn751NsWtjcQXWSb16my5QV4U dhAS1FQP+/wcZMcSj6R3NxveMpWrYQwo5jgh8rYPr3iFYSXOGKFf4JMweHSLuqSAByPW TS6r/tyZ1Vfe0SzV3G4ELVsekH7S+XRq4xfxFOqLVzw6lhKTRJy4eCT5JKyi+a05oKHb 7Etf8gw4WpPxHDWjHrcTjxAE8SnGfenRwfQquNDrlB4kQ6r5NbYAirBQZh9CAlYnX+Tk i3rg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:reply-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=nHOOgBmNlsLC5XTuJaLvTqwZfi6D0yvLIM3UiV9Oo4Q=; fh=tF/FjG7igJhcOEGq79wqr3ldeoZUVk5V7TNEGxaLUD4=; b=hkitGgy8JUlnEowMeUHP5tUtE5ICoxEzgBj6HbuWTBQPfBSHUz7v4CNLG6hrP7fJSa YqBgoK3xYATi5IYN62v5Yd1EX8BUdESDtor/gpiH5wTQfxLnd4L3mMTca2ZvxA57kloe kS8ufTh+ABGNmUX2Rz6u1kibvfxXTdhJpN6EcKPS8k73v3wlff+aQVflhFe01unDiItR SocP9u7zCoBIJn5Tgzq2CXMzEGn8TnSnlQZutrGSfF4xomY2VtMTrJ5Wrp0vdp4r0pe+ YfKZG/UqoRHHoIOGMf6N+dK9y1NsZKDRZ1QM3C/NwVXExpOgGAQJdnO2u0xf1IuZOFTa QbBg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@embecosm.com header.s=google header.b=Lj725FSA; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id r11-20020a0562140c4b00b006858baa6086si10213584qvj.542.2024.01.30.04.48.06 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 04:48:06 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@embecosm.com header.s=google header.b=Lj725FSA; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 802CA385E45D for <ouuuleilei@gmail.com>; Tue, 30 Jan 2024 12:48:06 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 47DB3385771D for <gcc-patches@gcc.gnu.org>; Tue, 30 Jan 2024 12:11:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47DB3385771D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 47DB3385771D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::335 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616749; cv=none; b=DG1CyWU1FyRHt/6FLA8yigC7fBmSaAVz5AUlibKxjflf5jPHmAyFYReX5fVlDMu5KZjwCSz6okiocCT6yM/59ygY6dOFsnsDfBXU67TrwgXuLbRSv3gmT6U622QPw3S0dMlHkZk/KvukLq9njNgN2/zjU1Kc2mwSalDINDvkML8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616749; c=relaxed/simple; bh=RGk69GUgqWBGj6naMDjZCTGTN3doxnH6LyRz1tyB8e8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=teDjAbFbGHue7V891ez1VY4QILc2Tx2RoNbtM76UUvrSVQ+LJCAQjoO4mKmwiGd55qaDoPiOnAfuKM2+jW2dX9l57lYGwTJrgxqEb9TCyKua9kLAO3Y4McNpw0ova2NR2BihGpttKY8ndtq9wjXy6Dws44UZHCbXFOtja/Fw+xY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40fafced243so1225155e9.0 for <gcc-patches@gcc.gnu.org>; Tue, 30 Jan 2024 04:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1706616704; x=1707221504; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=nHOOgBmNlsLC5XTuJaLvTqwZfi6D0yvLIM3UiV9Oo4Q=; b=Lj725FSALJVYH29DtYdMxB6bbY5XVxj71eBpT8Y8olanV3OpYIV1Lvakuu1WagpbBj t/gckKW44I7xEnYOPYlVnbHfpoLsjDtORdMPT7MyxPKt+fBmArNsO5PvHHx4Ejy+6uLS d4LPYZ/LJGhjCV6wX4NNtOaeIRbUISgPpc67Ge+zzYfwJczPdiGy3FaaAy72jcLY5hQ1 kMjo3xl0D+Ut1hRHXER40OJIPfDZLTLm+h7OVh44d1HtpVrm5J4Dwcqfz6aaOi1n+/UN MCfHYPl4y+Of8olBLCFp2tPuWhhmg73PNZ4G1ZB2R6nmx1VmSt9RITiWOJew5CtB4kAs SsSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706616704; x=1707221504; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nHOOgBmNlsLC5XTuJaLvTqwZfi6D0yvLIM3UiV9Oo4Q=; b=wgyPR1n0ACFDwYpJSFZ0ufN9+IlTzaRb5Z+o9+ib6I9Nc/HLGgGHStZAxyCh+bxQKd xKb5csGzWBGIrfs7A5B+TH1hYcgR0JcPM48gMtlnpqaMvdCz5co0Xtktx4XY/20WYhg2 ZdoLQqI4ioybv31HnM2hsJbiYBuJ5+JAqQAUPjTg8JcE7+9gipAggUJAcDLNvje5ZEcS kD6oYaR/19nKLrmpYCBNoBtyGIojV7b/eXJChqtt15fDKeLMtjkVhSez+7iKhPlLlAcU 5SHGpGmRE1MK+i1kI90Pk+64h/rbFSBru6BeCrvIq/IJMiAJjU1sUNXubnpYihKWdkB+ rDRg== X-Gm-Message-State: AOJu0YzI/sWOnT9IYSBVS9eyPFE3CJS1PSylxAuA+fs4FPJzhYAyTSqd 5sv+JbwthuABs13r+SDg8pqmQxFV0o7F/BJCcfrTtmyib8XPeGfpZEKyuQLJv8Y44JL+wS2xIj5 5UQ== X-Received: by 2002:a05:6000:184d:b0:33a:f27d:c05 with SMTP id c13-20020a056000184d00b0033af27d0c05mr4037486wri.15.1706616704668; Tue, 30 Jan 2024 04:11:44 -0800 (PST) Received: from platypus.localdomain ([62.23.166.218]) by smtp.gmail.com with ESMTPSA id f9-20020a056000036900b00339307d9d31sm10569894wrf.112.2024.01.30.04.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 04:11:43 -0800 (PST) From: arthur.cohen@embecosm.com To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Jakub Dupak <dev@jakubdupak.com> Subject: [COMMITTED 074/101] gccrs: BIR: Fix missed nodiscard Date: Tue, 30 Jan 2024 13:07:30 +0100 Message-ID: <20240130121026.807464-77-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240130121026.807464-2-arthur.cohen@embecosm.com> References: <20240130121026.807464-2-arthur.cohen@embecosm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Reply-To: arthur.cohen@embecosm.com Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789519606199415489 X-GMAIL-MSGID: 1789519606199415489 |
Series |
[COMMITTED,001/101] gccrs: Add visibility to trait item
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
Arthur Cohen
Jan. 30, 2024, 12:07 p.m. UTC
From: Jakub Dupak <dev@jakubdupak.com> gcc/rust/ChangeLog: * checks/errors/borrowck/rust-bir-builder-internal.h: Replace nodiscard. * checks/errors/borrowck/rust-bir-place.h: Replace nodiscard. Signed-off-by: Jakub Dupak <dev@jakubdupak.com> --- gcc/rust/checks/errors/borrowck/rust-bir-builder-internal.h | 4 ++-- gcc/rust/checks/errors/borrowck/rust-bir-place.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/gcc/rust/checks/errors/borrowck/rust-bir-builder-internal.h b/gcc/rust/checks/errors/borrowck/rust-bir-builder-internal.h index f33eb075244..cd611514776 100644 --- a/gcc/rust/checks/errors/borrowck/rust-bir-builder-internal.h +++ b/gcc/rust/checks/errors/borrowck/rust-bir-builder-internal.h @@ -261,12 +261,12 @@ protected: // CFG helpers protected: // HIR resolution helpers template <typename T> - [[nodiscard]] TyTy::BaseType *lookup_type (T &hir_node) const + WARN_UNUSED_RESULT TyTy::BaseType *lookup_type (T &hir_node) const { return lookup_type (hir_node.get_mappings ().get_hirid ()); } - [[nodiscard]] TyTy::BaseType *lookup_type (HirId hirid) const + WARN_UNUSED_RESULT TyTy::BaseType *lookup_type (HirId hirid) const { TyTy::BaseType *type = nullptr; bool ok = ctx.tyctx.lookup_type (hirid, &type); diff --git a/gcc/rust/checks/errors/borrowck/rust-bir-place.h b/gcc/rust/checks/errors/borrowck/rust-bir-place.h index 66b131dee1a..8c2df47c11d 100644 --- a/gcc/rust/checks/errors/borrowck/rust-bir-place.h +++ b/gcc/rust/checks/errors/borrowck/rust-bir-place.h @@ -148,9 +148,9 @@ public: 0); } - [[nodiscard]] PlaceId lookup_or_add_path (Place::Kind kind, - TyTy::BaseType *tyty, - PlaceId parent, size_t id = 0) + WARN_UNUSED_RESULT PlaceId lookup_or_add_path (Place::Kind kind, + TyTy::BaseType *tyty, + PlaceId parent, size_t id = 0) { PlaceId current = 0; if (parent < places.size ())