Message ID | 20240130121026.807464-75-arthur.cohen@embecosm.com |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp1192728dyb; Tue, 30 Jan 2024 04:46:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IE9UN7okApTmOWscXE7Q6sFeW4iRDaxlCYkZMmct+gefkedELUWCAtHX2HrDOjCaKNCUsxm X-Received: by 2002:a05:620a:15b9:b0:783:bcdc:e2d1 with SMTP id f25-20020a05620a15b900b00783bcdce2d1mr7429047qkk.70.1706618779052; Tue, 30 Jan 2024 04:46:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706618779; cv=pass; d=google.com; s=arc-20160816; b=KFlqoGasAmg9E2/6uprhaM1/S1dErrN/x/y3Jve2SzjzGoA9Nuomo3ForGQjZmhKT3 oFVY0ho+67VrcBjUSQKp4spjrqKltw+3XfoY5MJ9Xhd/j6WDffQzmKoyNr4tI8BDwQAP 5IX7ZMo2X/eFip+rs4s8hIDwt4K42dlntpMjUFDPjiHJaSXp8OCcDqHbeFNITMtcc/Ov YV8ddI+pj7MDOwR6oD0lGKhQz/1sLGncJvD711MDehSe1Gxqhpzh0Bzm12vyNF6fhUlF YQBAxeGPJb+DzwUR9k7Ec7+9vtS122uSIrNPdrTtrxtioQc+7j/GDsdlnms/Ze15MIIH 2dyw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:reply-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=xRFapfmaqT8Fwfh6VKPWHVph7SfMdQ5TBMshjeLpkmw=; fh=tF/FjG7igJhcOEGq79wqr3ldeoZUVk5V7TNEGxaLUD4=; b=HjN3Dk5NFl6YnftBPG3t38GFYGVCixAePkUPgrWUgHQjY2PRPJbJvO1/f76baHX5Ha RS4nH/IIJwMjvGhpLiz7j/MzEqiFVHXCUFWRaAxdZMxTaOMBdHTRrks+/Bx3Az4OkYbk q1hw0PnxLxSgNgOu7j7RpevMCgT7kz3av87joGvOCGetZehaM4OBaIdwbGEN/jU/lFi+ OOQTLlyr1qDEyu3JdQLe20WF6CrxF9gGz/YF2tRjKEkoeAaUoez2Up4vWrPJzThFYXxL 3yuObR6892s37/D2KwsA1xCYSNbjI4kvAz3xcaOaz4DCYmKaJ/E/HEbkBnHd8qlQcUgx gy8A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@embecosm.com header.s=google header.b=PANJxFjn; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id u11-20020a05620a120b00b00783d9e90923si9050947qkj.519.2024.01.30.04.46.18 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 04:46:19 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@embecosm.com header.s=google header.b=PANJxFjn; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B91963831E22 for <ouuuleilei@gmail.com>; Tue, 30 Jan 2024 12:46:00 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id 3A3433857B9D for <gcc-patches@gcc.gnu.org>; Tue, 30 Jan 2024 12:11:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A3433857B9D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A3433857B9D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616743; cv=none; b=XttSexENEj6DK3XgUqWl7VpmutrEHo71DZIpnQy8eXf7sRfYn7jxurCbEvA92izF/Iz1IDiKwcQ83RQBRlRaZzeug/7b+21kBY00MB6V2t1+TJk39svCMtigL+dAqNYeR1CsfXtwS2F11Cko/mkIEGKn2LvQnLHuSEERQ3VueZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616743; c=relaxed/simple; bh=AlrBgbIzwOz/dsUBJ9lGWp/ivNJicnFjb05dFDdxKBk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=fjVqKgG0FWH/EzMwq2T0f1gDe6TcTBhWwydDW789685dReE19j4gIgf6ycwiaOkfu9rMZl7709LXtS0MaZETziOSR4Y+TxBPA4MYB1hLEh1eXhrtmVjQMKSr9PIRHkusn4JkZwv4zI7Q35VQEMCojdGrno8KZA6G2dSFUpYgULw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-51117bfd452so1693479e87.3 for <gcc-patches@gcc.gnu.org>; Tue, 30 Jan 2024 04:11:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1706616703; x=1707221503; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=xRFapfmaqT8Fwfh6VKPWHVph7SfMdQ5TBMshjeLpkmw=; b=PANJxFjnio1d6MRZ1JbLgPA0Ps1z/oC0pS3opnI2WBCadT9qctAOj/Ka4QaCGrvP+n IpIZrP5j60hgX8Yq6KssdFudZ7v4aNvqW+ye0Je27PcJVyDS/N2AfugmsAw0H0aAuJy7 5p6nEQcDvnTbKwd1shc66jmJjWQalTqRI6vZHUgyJpnt9nZ0z9boo6HQ2LeM/0GtlIdr UeGtOP4w/1YBB6060O//HOXCVM1cyWML/zGvyZrdTEaQSjufWIzYcV4FJGW7tOSUmKjA dxrGRPIibBmu8TzfJx++DJhleuZjTQMREFaf2buOWEWnwXLjE0+DHu0DDbhX95akja6j ZLyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706616703; x=1707221503; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xRFapfmaqT8Fwfh6VKPWHVph7SfMdQ5TBMshjeLpkmw=; b=qwXD83YdmgkM+c2dBvj4LJIr9c/6ZpKEG0vm95tyIAEcTXgLzMrICfzoqD1I2lguJ7 j41t7DCRnu0M5hFNawGQYzbPzb1BIJRsAtbF4KCL8MZZL41ZbaLtzA9LRnasDLiuw0ef jjILhZpzKFQWrrqVKQX/8vy5Zlb9A8zwPlldq3K1IiKGgVthA8KCgnphetX3p0RQ0jHY //gO+U5lMQricB7q5FplI0BZP/UiUOAKHuIKP7M1pyV3fXrwZMp/p5zxl95nEXR/2Kmb MIuFjEKWzED203Vz6ZNbQsA5/2j8uFRsZojWRHsn2Z/iqeaFmerzjHjsBBfGrtjrkxxw ZatA== X-Gm-Message-State: AOJu0Yz1FyNiL+ODISaKoqp1riYc41peqjTxpDn8v9Rwn5klvYxGb3wR /0O36igWzAKetDJf/TZMTA5hMNce8pDFHSPzL9Oc1wmKkkdT7qAFIUzHYU8ouDClCCbfAt5KgDy Z9g== X-Received: by 2002:ac2:562e:0:b0:50e:cbf3:8f73 with SMTP id b14-20020ac2562e000000b0050ecbf38f73mr6863890lff.52.1706616702978; Tue, 30 Jan 2024 04:11:42 -0800 (PST) Received: from platypus.localdomain ([62.23.166.218]) by smtp.gmail.com with ESMTPSA id f9-20020a056000036900b00339307d9d31sm10569894wrf.112.2024.01.30.04.11.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 04:11:42 -0800 (PST) From: arthur.cohen@embecosm.com To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Jakub Dupak <dev@jakubdupak.com> Subject: [COMMITTED 072/101] gccrs: HIR: add missing getters Date: Tue, 30 Jan 2024 13:07:28 +0100 Message-ID: <20240130121026.807464-75-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240130121026.807464-2-arthur.cohen@embecosm.com> References: <20240130121026.807464-2-arthur.cohen@embecosm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Reply-To: arthur.cohen@embecosm.com Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789519492647354942 X-GMAIL-MSGID: 1789519492647354942 |
Series |
[COMMITTED,001/101] gccrs: Add visibility to trait item
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
Arthur Cohen
Jan. 30, 2024, 12:07 p.m. UTC
From: Jakub Dupak <dev@jakubdupak.com> gcc/rust/ChangeLog: * hir/tree/rust-hir-item.h: Ad lifetime getter. * hir/tree/rust-hir-path.h: Make getter const ref. * hir/tree/rust-hir.h: Const ref and new getter. Signed-off-by: Jakub Dupak <dev@jakubdupak.com> --- gcc/rust/hir/tree/rust-hir-item.h | 2 ++ gcc/rust/hir/tree/rust-hir-path.h | 4 ++++ gcc/rust/hir/tree/rust-hir.h | 7 ++++++- 3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/gcc/rust/hir/tree/rust-hir-item.h b/gcc/rust/hir/tree/rust-hir-item.h index f72d8c8b050..74450786e89 100644 --- a/gcc/rust/hir/tree/rust-hir-item.h +++ b/gcc/rust/hir/tree/rust-hir-item.h @@ -443,6 +443,8 @@ public: // Returns whether the self-param has a valid lifetime. bool has_lifetime () const { return !lifetime.is_error (); } + const Lifetime &get_lifetime () const { return lifetime; } + // Returns whether the self-param is in an error state. bool is_error () const { return self_kind == ImplicitSelfKind::NONE; } diff --git a/gcc/rust/hir/tree/rust-hir-path.h b/gcc/rust/hir/tree/rust-hir-path.h index 9fe126a56a8..0566e2e2a1c 100644 --- a/gcc/rust/hir/tree/rust-hir-path.h +++ b/gcc/rust/hir/tree/rust-hir-path.h @@ -218,6 +218,10 @@ public: std::string as_string () const; std::vector<Lifetime> &get_lifetime_args () { return lifetime_args; } + const std::vector<Lifetime> &get_lifetime_args () const + { + return lifetime_args; + } std::vector<std::unique_ptr<Type> > &get_type_args () { return type_args; } diff --git a/gcc/rust/hir/tree/rust-hir.h b/gcc/rust/hir/tree/rust-hir.h index 0f2d52256d2..f66f53fbd20 100644 --- a/gcc/rust/hir/tree/rust-hir.h +++ b/gcc/rust/hir/tree/rust-hir.h @@ -572,7 +572,10 @@ public: void accept_vis (HIRFullVisitor &vis) override; - std::string get_name () const { return lifetime_name; } + WARN_UNUSED_RESULT const std::string &get_name () const + { + return lifetime_name; + } AST::Lifetime::LifetimeType get_lifetime_type () const { @@ -662,6 +665,8 @@ public: // Returns whether the lifetime param has any lifetime bounds. bool has_lifetime_bounds () const { return !lifetime_bounds.empty (); } + std::vector<Lifetime> &get_lifetime_bounds () { return lifetime_bounds; } + // Returns whether the lifetime param has an outer attribute. bool has_outer_attribute () const { return !outer_attr.is_empty (); }