From patchwork Fri Jan 26 14:16:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 192613 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:e09d:b0:103:945f:af90 with SMTP id gm29csp687680dyb; Fri, 26 Jan 2024 06:17:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IHs4OZOXPDu2nSPYV1Jn3cjQgOGscmAQ1rU7OJ3KiBe96xUz7A+ePm8EsUzOFvaIlbl4huz X-Received: by 2002:a05:622a:818b:b0:42a:74f7:3c2e with SMTP id jy11-20020a05622a818b00b0042a74f73c2emr1327288qtb.49.1706278621730; Fri, 26 Jan 2024 06:17:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706278621; cv=pass; d=google.com; s=arc-20160816; b=b243eeQYIUuqfHJVn0Ps918JsZCq6uXap4s6rml9vTbWFQ3zV6PojHut+cymq5zUth Bd8FIm0oUk+kdtwBhlsUEbvBxIX3xozhivfrOT0JuYwpVaXAiLCMOTs3htGDuF5g+3Pr nQPBmolJIcnexWfjqwIYbfcLhHHcon23O7ZXBp2sJckbg5JY0qFY6/4Iv64cd+J2w2yN HsY66z6x8p6JXQHsAo2ig3s4QGpLqd1MobNmY+x/xToiRjdBrt4mSWfEQfZ4CGXDv5N5 Bzj+c0G7E20utT6KmzE1tv5q3iZn7sKgA70TKT69i6UbEwpLHmA9Pl+ZZCFrcFabDlLK 48Mw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:message-id:mime-version:subject :cc:to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=pL1H8tjYnnSCBl0yyEACySw1WnoRTa09JdWPkx41ojQ=; fh=Hz/QWAL2vMAbrm3W16QrnQrLktFWGNewssxaKtdN1w4=; b=HBsYg3nivowHQYc/KAe3oRLk8VO2ayvWZrNrVUlen+O+InRWmUuPxxVPgJmhylxvcj vvgOezlKxMX/qCmYaGahNjyGrFKfwx6pGtVZxyddTGJ1bnd2trFMUQcmcs+iGnPrjmPA AhMcGSex81kvk+X+RL36QVHJ2UtasbVvqcUrONRdpKBEb/6Z0g9+ZppTQZ6zKeBsEa9p PBQwL8c7UXETakPTekAXaK2F7/lcvGoMx3Hgxv/d0ZBRBXYx9Xcefo1o6aInF/v3K7MY MEy8qMyGzuMSkd6G6QfLtpuDk11+JVpTj0dlJqzJbA7bpCYzgBYigowTXt+9NYcDWKYM 06OQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=xWYFhVJZ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=xWYFhVJZ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id g10-20020ac8580a000000b0042a62a4ae9fsi1303438qtg.178.2024.01.26.06.17.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 06:17:01 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=xWYFhVJZ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=xWYFhVJZ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6E5543858C20 for ; Fri, 26 Jan 2024 14:17:01 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 501063858D39 for ; Fri, 26 Jan 2024 14:16:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 501063858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 501063858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706278579; cv=none; b=SIXd1r7OtIeyaIoRBTQzlXINd1mB82LtyVaWx6DSWjkzqFJ2o78Be8upysKKFCtnSTWwWOeW1yXJSI6k6EdejCBXdDPcn3LSWGNN2LnC1oSi6uBC80PHpxnRygW29BnXDq2nbxq4Y56vYMabXagxof/4QGhjjbERxHg46kf0YNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706278579; c=relaxed/simple; bh=wBHjZu0IWPPcAaKCTwS/2yc3LJ32uDHnRjSdQ0qX83s=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=YckQABHoy8tEo7fSZgRuxRML99QIQvhAoaNO6nkomoTRsEYneVNlOaViHJEr5mAth9C0OlP8H326V8cws65ojjnZq4tJ+/YhVutFssokhHB6SXPObnQiUOg2v8QjdLvHNV38+Hi6sAWbqgayhjOjXkJZDfRk5Q+gPdHe71ChATU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AF83F21EC2; Fri, 26 Jan 2024 14:16:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706278576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=pL1H8tjYnnSCBl0yyEACySw1WnoRTa09JdWPkx41ojQ=; b=xWYFhVJZ4uJBDmhek24bABF1ck+E1veLkS3Un2IQ6gWUq6rtQGLut1Hk8P5FqX8xvxeAfH xdJysfZN5iYPB3qKW2neh4pegw57jb6ijTkFHHtRTFJ2MdfI5SYnIu9Zsj7l1kbc6Itgdg e+r62oGoKXuzDt98pENzMVHbeEZZ2zI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706278576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=pL1H8tjYnnSCBl0yyEACySw1WnoRTa09JdWPkx41ojQ=; b=o0SwxBzxHzrfWTzDXgz5TLX8cb/W82scUR95xGmzC0H8ZIOL4p9fS8IOXnQPQNOIAOy774 nXY+HxVjyhKdsfAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706278576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=pL1H8tjYnnSCBl0yyEACySw1WnoRTa09JdWPkx41ojQ=; b=xWYFhVJZ4uJBDmhek24bABF1ck+E1veLkS3Un2IQ6gWUq6rtQGLut1Hk8P5FqX8xvxeAfH xdJysfZN5iYPB3qKW2neh4pegw57jb6ijTkFHHtRTFJ2MdfI5SYnIu9Zsj7l1kbc6Itgdg e+r62oGoKXuzDt98pENzMVHbeEZZ2zI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706278576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=pL1H8tjYnnSCBl0yyEACySw1WnoRTa09JdWPkx41ojQ=; b=o0SwxBzxHzrfWTzDXgz5TLX8cb/W82scUR95xGmzC0H8ZIOL4p9fS8IOXnQPQNOIAOy774 nXY+HxVjyhKdsfAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8307A13A22; Fri, 26 Jan 2024 14:16:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id F0BhHbC+s2UGbQAAD6G6ig (envelope-from ); Fri, 26 Jan 2024 14:16:16 +0000 Date: Fri, 26 Jan 2024 15:16:15 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: Jakub Jelinek Subject: [PATCH] debug/103047 - argument order of inlined functions MIME-Version: 1.0 Message-Id: <20240126141616.8307A13A22@imap1.dmz-prg2.suse.org> X-Spam-Level: Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xWYFhVJZ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=o0SwxBzx X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-1.52 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.01)[47.87%] X-Spam-Score: -1.52 X-Rspamd-Queue-Id: AF83F21EC2 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789162812455184572 X-GMAIL-MSGID: 1789162812455184572 The inliner puts variables for parameters of the inlined functions in the inline scope in reverse order. The following reverses them again so that we get consistent ordering between the DW_TAG_subprogram DW_TAG_formal_parameter and the DW_TAG_inlined_subroutine DW_TAG_formal_parameter set. I failed to create a testcase with regexps since the inline instances have just abstract origins and so I can't match them up. Bootstrap & regtest running on x86_64-unknown-linux-gnu. OK if that succeeds? Thanks, Richard. PR debug/103047 * tree-inline.cc (initialize_inlined_parameters): Reverse the decl chain of inlined parameters. --- gcc/tree-inline.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gcc/tree-inline.cc b/gcc/tree-inline.cc index 1a2541ad952..75c10eb7dfc 100644 --- a/gcc/tree-inline.cc +++ b/gcc/tree-inline.cc @@ -3684,6 +3684,10 @@ initialize_inlined_parameters (copy_body_data *id, gimple *stmt, setup_one_parameter (id, p, static_chain, fn, bb, &vars); } + /* Reverse so the variables appear in the correct order in DWARF + debug info. */ + vars = nreverse (vars); + declare_inline_vars (id->block, vars); }