diff mbox series

debug/103047 - argument order of inlined functions

Message ID 20240126141616.8307A13A22@imap1.dmz-prg2.suse.org
State Accepted
Headers
Series debug/103047 - argument order of inlined functions |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Richard Biener Jan. 26, 2024, 2:16 p.m. UTC 
  The inliner puts variables for parameters of the inlined functions
in the inline scope in reverse order.  The following reverses them
again so that we get consistent ordering between the
DW_TAG_subprogram DW_TAG_formal_parameter and the
DW_TAG_inlined_subroutine DW_TAG_formal_parameter set.

I failed to create a testcase with regexps since the inline
instances have just abstract origins and so I can't match them up.

Bootstrap & regtest running on x86_64-unknown-linux-gnu.

OK if that succeeds?

Thanks,
Richard.

	PR debug/103047
	* tree-inline.cc (initialize_inlined_parameters): Reverse
	the decl chain of inlined parameters.
---
 gcc/tree-inline.cc | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jakub Jelinek Jan. 26, 2024, 2:18 p.m. UTC | #1 
On Fri, Jan 26, 2024 at 03:16:15PM +0100, Richard Biener wrote:
> The inliner puts variables for parameters of the inlined functions
> in the inline scope in reverse order.  The following reverses them
> again so that we get consistent ordering between the
> DW_TAG_subprogram DW_TAG_formal_parameter and the
> DW_TAG_inlined_subroutine DW_TAG_formal_parameter set.
> 
> I failed to create a testcase with regexps since the inline
> instances have just abstract origins and so I can't match them up.
> 
> Bootstrap & regtest running on x86_64-unknown-linux-gnu.
> 
> OK if that succeeds?
> 
> Thanks,
> Richard.
> 
> 	PR debug/103047
> 	* tree-inline.cc (initialize_inlined_parameters): Reverse
> 	the decl chain of inlined parameters.

LGTM.

	Jakub
diff mbox series

Patch

diff --git a/gcc/tree-inline.cc b/gcc/tree-inline.cc
index 1a2541ad952..75c10eb7dfc 100644
--- a/gcc/tree-inline.cc
+++ b/gcc/tree-inline.cc
@@ -3684,6 +3684,10 @@  initialize_inlined_parameters (copy_body_data *id, gimple *stmt,
       setup_one_parameter (id, p, static_chain, fn, bb, &vars);
     }
 
+  /* Reverse so the variables appear in the correct order in DWARF
+     debug info.  */
+  vars = nreverse (vars);
+
   declare_inline_vars (id->block, vars);
 }