From patchwork Fri Jan 26 10:22:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 192504 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:e09d:b0:103:945f:af90 with SMTP id gm29csp565068dyb; Fri, 26 Jan 2024 02:23:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IGtWt7grq0aysGN5oDlpp+w5/49tXOre2LV3uFCD5OXmarjWIkpNWO6vYzkqy1LJeTvAGdj X-Received: by 2002:a05:620a:951:b0:783:8261:30b with SMTP id w17-20020a05620a095100b007838261030bmr1075491qkw.151.1706264636730; Fri, 26 Jan 2024 02:23:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706264636; cv=pass; d=google.com; s=arc-20160816; b=GpM41hMIDn8SDq0tpdUOI85cjW1Er9MAHXbTWa88hecubzENVzGkTHh7vfdXWAFznq H79CqR0JYseg6eFU2QBSQTcWJYSn52TCXOxj6vA5kW9x/DAoMZv/A7ED/7CrrS+O11L+ ZxxulOJy/CH0sGGz/7x0pKp4Ej1j0+DuEJPka4/YQ4x9ieohWSU6wqPlXhgDNJyRQl0V pGDp8hGhARf82Q9dzexizrT86dCZGs4uGDlD1GaVJGEk6TPUaLERSCJvW5AOoxWcNjy/ tFboE/M3U1GLASW+1DT+4OQk9qzf/hQJtTHTwP/7dtJJZvRkJ+OfSCzUGDH46DpgPsPX cf1A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:message-id:mime-version:subject :to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=U8YTWPi9Y7uxsy6UBQHDLlwKloUgnXE3rSQn1+8pjUc=; fh=hPrbWPhweUx4V0GV9uXJqbyAzg2ABmTz7kczrAQqMmM=; b=CmLbGCVdMlvR4QOgwlNe0pQoSO95piakji93MTJnyJf0C56bBVL4M8B/3s/jCl/D05 lKz5wqr35Ydn1NFCTSpFgGN/YOhdV0b5s3Yaa73ghigdOuNBQWmv3UzpcF87jy+DetGC fxwaa3zQAln2Ge6RuBYrYcpi7xMX+ZfGJNlzqRsQBSh+t4/q64UFmrbSlNXjNZFMli9O wAfXNWwu8P8N1j+KRpz/HHFWS/ooySicFS7MPk0Ws9kdFIOwybhC7mvkupQuV/RHY8/f qTH+di6ncOzS/Yyf9WjkBDEc1rWLP5xLylMTmEG3gZxJPEg0R5Uttyc2kzqo8smNMxPS +YQA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=oYMwzFly; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=oYMwzFly; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id o17-20020a05620a229100b00783d074bb1asi752108qkh.238.2024.01.26.02.23.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 02:23:56 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=oYMwzFly; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=oYMwzFly; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 700773857C6B for ; Fri, 26 Jan 2024 10:23:56 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 697EC3858010 for ; Fri, 26 Jan 2024 10:23:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 697EC3858010 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 697EC3858010 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706264584; cv=none; b=a567qzxovLuLUbsoUErWTjC3ZOuHfEzu8ACp6N/taLgx5VSIyb02dOZUgFlctSxuMmzZHQhRCXRfOK1vgLXz0rd6D9yXWKI7TksNqNRXtIhpYKeXgJBq5GwqD+YwSO+YYPI/ngTy9FlkiQbMkx1m9lIGL4dzi5ldZPKce5Z7VlA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706264584; c=relaxed/simple; bh=n/MNxhS10rDggIjYkuTmLMm2//oHNGxl19rBnhgeFP8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=C//alIlzuyyIsR+fBEsHIDkJkDudAMprT3h97+5OURnU/NF35wzEX0voI731Ow0uMPUcfVK8E7seYb8lcJqNMAEDOoISMQsGEognN2Pjxruj0S+h0DbpoFyRHN0YUi1TB+ppKW9kqDeWjK3B1EeI90V69qEcifnjqICQja/Z1c4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 40F1D21D77 for ; Fri, 26 Jan 2024 10:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706264580; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=U8YTWPi9Y7uxsy6UBQHDLlwKloUgnXE3rSQn1+8pjUc=; b=oYMwzFlywF+axq+H0JLYUBZRFM/MCBny1oONSl4oXU+Mx6EnTgjKU2f0YLA52A5DMvtwIg fXZkHk2ERnORHE+tDL5jcA8q+O0vaXOzu5y+12Tn/Y0Z2pFg39NEKzeaRNeLQJdfM4MURL eAK0F01LTHCALlQML4XJDFpRlqu7kr8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706264580; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=U8YTWPi9Y7uxsy6UBQHDLlwKloUgnXE3rSQn1+8pjUc=; b=bj6rAe79grHdCpfw3cxcXlCUYQGFSB05fCisUD4A13+7/Y2DIOsKyGgLcvVH3SAm8hKGiQ BXZIktXoOAZnzoDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706264580; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=U8YTWPi9Y7uxsy6UBQHDLlwKloUgnXE3rSQn1+8pjUc=; b=oYMwzFlywF+axq+H0JLYUBZRFM/MCBny1oONSl4oXU+Mx6EnTgjKU2f0YLA52A5DMvtwIg fXZkHk2ERnORHE+tDL5jcA8q+O0vaXOzu5y+12Tn/Y0Z2pFg39NEKzeaRNeLQJdfM4MURL eAK0F01LTHCALlQML4XJDFpRlqu7kr8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706264580; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=U8YTWPi9Y7uxsy6UBQHDLlwKloUgnXE3rSQn1+8pjUc=; b=bj6rAe79grHdCpfw3cxcXlCUYQGFSB05fCisUD4A13+7/Y2DIOsKyGgLcvVH3SAm8hKGiQ BXZIktXoOAZnzoDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2442113A22 for ; Fri, 26 Jan 2024 10:23:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VH3iBgSIs2VwHwAAD6G6ig (envelope-from ) for ; Fri, 26 Jan 2024 10:23:00 +0000 Date: Fri, 26 Jan 2024 11:22:58 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/113602 - datarefs of non-addressables MIME-Version: 1.0 Message-Id: <20240126102300.2442113A22@imap1.dmz-prg2.suse.org> X-Spam-Level: Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oYMwzFly; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bj6rAe79 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gcc-patches@gcc.gnu.org]; RCPT_COUNT_ONE(0.00)[1]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] X-Spam-Score: -4.51 X-Rspamd-Queue-Id: 40F1D21D77 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789148147780955362 X-GMAIL-MSGID: 1789148147780955362 We can end up creating ADDR_EXPRs of non-addressable entities during for example vectorization. The following plugs this in data-ref analysis when that would create such invalid ADDR_EXPR as part of analyzing the ref structure. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/113602 * tree-vect-data-ref.cc (dr_analyze_innermost): Fail when the base object isn't addressable. * gcc.dg/pr113602.c: New testcase. --- gcc/testsuite/gcc.dg/pr113602.c | 10 ++++++++++ gcc/tree-data-ref.cc | 7 ++++++- 2 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/pr113602.c diff --git a/gcc/testsuite/gcc.dg/pr113602.c b/gcc/testsuite/gcc.dg/pr113602.c new file mode 100644 index 00000000000..94bfbc91b5f --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr113602.c @@ -0,0 +1,10 @@ +/* { dg-do compile } */ +/* { dg-require-effective-target bitint575 } */ +/* { dg-options "-O2 -fno-tree-loop-optimize" } */ + +_BitInt(503) +f(void) +{ + register _BitInt(503) r asm(""); /* { dg-error "invalid" } */ + return r; +} diff --git a/gcc/tree-data-ref.cc b/gcc/tree-data-ref.cc index ae55bf6aa48..f37734b5340 100644 --- a/gcc/tree-data-ref.cc +++ b/gcc/tree-data-ref.cc @@ -1182,7 +1182,12 @@ dr_analyze_innermost (innermost_loop_behavior *drb, tree ref, base = TREE_OPERAND (base, 0); } else - base = build_fold_addr_expr (base); + { + if (may_be_nonaddressable_p (base)) + return opt_result::failure_at (stmt, + "failed: base not addressable.\n"); + base = build_fold_addr_expr (base); + } if (in_loop) {