LoongArch: Assign the '/u' attribute to the mem to which the global offset table belongs.

Message ID 20240113063709.19072-1-chenglulu@loongson.cn
State Accepted
Headers
Series LoongArch: Assign the '/u' attribute to the mem to which the global offset table belongs. |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

chenglulu Jan. 13, 2024, 6:37 a.m. UTC
  gcc/ChangeLog:

	* config/loongarch/loongarch.cc (loongarch_split_symbol):
	Assign the '/u' attribute to the mem.

gcc/testsuite/ChangeLog:

	* g++.target/loongarch/got-load.C: New test.
---
 gcc/config/loongarch/loongarch.cc             |  5 +++++
 gcc/testsuite/g++.target/loongarch/got-load.C | 19 +++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 gcc/testsuite/g++.target/loongarch/got-load.C
  

Comments

chenglulu Jan. 18, 2024, 7:25 a.m. UTC | #1
Pushed to r14-8203.

在 2024/1/13 下午2:37, Lulu Cheng 写道:
> gcc/ChangeLog:
>
> 	* config/loongarch/loongarch.cc (loongarch_split_symbol):
> 	Assign the '/u' attribute to the mem.
>
> gcc/testsuite/ChangeLog:
>
> 	* g++.target/loongarch/got-load.C: New test.
> ---
>   gcc/config/loongarch/loongarch.cc             |  5 +++++
>   gcc/testsuite/g++.target/loongarch/got-load.C | 19 +++++++++++++++++++
>   2 files changed, 24 insertions(+)
>   create mode 100644 gcc/testsuite/g++.target/loongarch/got-load.C
>
> diff --git a/gcc/config/loongarch/loongarch.cc b/gcc/config/loongarch/loongarch.cc
> index 3b8559bfdc8..82467474288 100644
> --- a/gcc/config/loongarch/loongarch.cc
> +++ b/gcc/config/loongarch/loongarch.cc
> @@ -3202,6 +3202,11 @@ loongarch_split_symbol (rtx temp, rtx addr, machine_mode mode, rtx *low_out)
>   	      rtx mem = gen_rtx_MEM (Pmode, low);
>   	      *low_out = gen_rtx_UNSPEC (Pmode, gen_rtvec (1, mem),
>   					 UNSPEC_LOAD_FROM_GOT);
> +
> +	      /* Nonzero in a mem, if the memory is statically allocated and
> +		 read-only.  A common example of the later is a shared library’s
> +		 global offset table.  */
> +	      MEM_READONLY_P (mem) = 1;
>   	    }
>   
>   	  break;
> diff --git a/gcc/testsuite/g++.target/loongarch/got-load.C b/gcc/testsuite/g++.target/loongarch/got-load.C
> new file mode 100644
> index 00000000000..20924c73942
> --- /dev/null
> +++ b/gcc/testsuite/g++.target/loongarch/got-load.C
> @@ -0,0 +1,19 @@
> +/* { dg-do compile } */
> +/* { dg-options "-mabi=lp64d -O2 -mexplicit-relocs -mcmodel=normal -fdump-rtl-expand" } */
> +/* { dg-final { scan-rtl-dump-times "mem/u" 2 "expand" } } */
> +
> +#include <bits/stdc++.h>
> +
> +using namespace std;
> +
> +int lr[100005][2];
> +
> +void
> +test(void)
> +{
> +  int n;
> +
> +  cin >> n;
> +  for (int i = 0; i < n; ++i)
> +    cin >> lr[i][0] >> lr[i][1];
> +}
  

Patch

diff --git a/gcc/config/loongarch/loongarch.cc b/gcc/config/loongarch/loongarch.cc
index 3b8559bfdc8..82467474288 100644
--- a/gcc/config/loongarch/loongarch.cc
+++ b/gcc/config/loongarch/loongarch.cc
@@ -3202,6 +3202,11 @@  loongarch_split_symbol (rtx temp, rtx addr, machine_mode mode, rtx *low_out)
 	      rtx mem = gen_rtx_MEM (Pmode, low);
 	      *low_out = gen_rtx_UNSPEC (Pmode, gen_rtvec (1, mem),
 					 UNSPEC_LOAD_FROM_GOT);
+
+	      /* Nonzero in a mem, if the memory is statically allocated and
+		 read-only.  A common example of the later is a shared library’s
+		 global offset table.  */
+	      MEM_READONLY_P (mem) = 1;
 	    }
 
 	  break;
diff --git a/gcc/testsuite/g++.target/loongarch/got-load.C b/gcc/testsuite/g++.target/loongarch/got-load.C
new file mode 100644
index 00000000000..20924c73942
--- /dev/null
+++ b/gcc/testsuite/g++.target/loongarch/got-load.C
@@ -0,0 +1,19 @@ 
+/* { dg-do compile } */
+/* { dg-options "-mabi=lp64d -O2 -mexplicit-relocs -mcmodel=normal -fdump-rtl-expand" } */
+/* { dg-final { scan-rtl-dump-times "mem/u" 2 "expand" } } */
+
+#include <bits/stdc++.h>
+
+using namespace std;
+
+int lr[100005][2];
+
+void
+test(void)
+{
+  int n;
+
+  cin >> n;
+  for (int i = 0; i < n; ++i)
+    cin >> lr[i][0] >> lr[i][1];
+}