Message ID | 20240110194031.2384005-5-kmatsui@gcc.gnu.org |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp1014967dyi; Wed, 10 Jan 2024 11:42:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3kC6+mPdHzA9bMvihT9oG6lVJMVieu80UrVV44xJ5anw40bwe+cYx8uQ1gZ2ZPEd/HN/w X-Received: by 2002:a05:622a:204:b0:429:b595:fe28 with SMTP id b4-20020a05622a020400b00429b595fe28mr82479qtx.37.1704915775080; Wed, 10 Jan 2024 11:42:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1704915775; cv=pass; d=google.com; s=arc-20160816; b=Kztv76b5jv9hSf6eqH8mzmjg0K4TvUR1FTWy6faIUK8Bns/G2DxpwAHtN+wx2PQDhV +ap1is626arWRS4Xra2lIB+9tcGyatMGptlb6xoJk9bu7/ZjwXzv9uo7NkMfZrU7gSrE YAFdhd6EjxABFln7P/lEJScQF0khHvgN8pw9WMiZIMUPS00txQOk0VLa/SUVU8cKMqpD nqq+2K/MZk+vV8RxleBwk8I1rDo3lTa1PziGltDQXGP/lyJRaPQMuSXY3cctyktQrU6B PfxKQJlZaC9d88fcd33o7io91W9f1TP8B4FjcMOLsIvtazHv1P5XEQKaSi+l7m8lBfSO RtXg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=SC1P28lbXGiY05rRjH7hqcBssMd3OMJcIIJzN9X4hHU=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=fgqZ5uBTWG1E/ue7H52jb3R+Jz3wjsuSBeP8+YSAYquCnUvcRySlfDY5MkuxUbyd4i 1PU33jmUx4SzMpuVf9ECmZzqCD4LhSsGpXOL6ejIQ/9k3x5+Hcy8GoVE0xIp1vYQCEn0 3qO08BSF7fburUJdNSnb/v89yqCSQf08m9zbhDQTSqITIaNaNEGAM/OgpndDR8FEkKVF MXgNU5Zpf1D0yFR5C14k/3ELuk3heQljM70DBfIodyKgTmexkwL1Xg9dq9suRpd6AV4K teKtnalMfNg1TjfafO9EEfsaLgant3puPO3qbiCyHo+ShHcazGPrHw75hDZg6IpgLCjD eNdQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="IaHWR/jT"; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id g22-20020ac87d16000000b004299b15b56csi4642922qtb.716.2024.01.10.11.42.54 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 11:42:55 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="IaHWR/jT"; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B8DEB385801A for <ouuuleilei@gmail.com>; Wed, 10 Jan 2024 19:42:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B8DEB385801A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1704915774; bh=SC1P28lbXGiY05rRjH7hqcBssMd3OMJcIIJzN9X4hHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IaHWR/jTQDz9weZCMjqB+mx5AwDJ2/McLVfrP6gCYMbmDZGIShAtaKLx54VsHTEc5 H4tYWUjRmyXb/5nF/CwEF0+53/OUES9i72oaKNF/+f/dU4A3X2Bzj2DNM8ybhNGTPY OEktv1Rjp9bXoni2VnskCdA+1AuLTuyLd6O/KEmY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-00641c01.pphosted.com (mx0b-00641c01.pphosted.com [205.220.177.146]) by sourceware.org (Postfix) with ESMTPS id 473283857C4C; Wed, 10 Jan 2024 19:41:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 473283857C4C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 473283857C4C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.177.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704915667; cv=none; b=UKvLiB//J0Cgwk4FkOGI3bxnr6VMZALA1uVjzj+Gqc6GBrmmBW5SBluInm5aW/6mv8Nl1wBbAmL015hvU3GPjpq5WG2daSV7ora/YCml5QXJIsVrX+2/mqq/EEyuLuVRbRl6BNmQFizeDGKZQ9tpfg3itCyWXnfc08YwKI8ELRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704915667; c=relaxed/simple; bh=G5TvNgClny7SC087pzKefYvF4ktWz/RFWqk1cThWWmo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=RwDIzlwRBFIF0rK94tuh3NUnASh8wdrYOZQbJiSMH4RjP4ElsUcHtBI7ujJfJEcyEDded97mHqTZyNiCOozFW9+o+h/TczsBI5f6BMhMlztX3DiXsZ84fWX7VABaS7R6p5E47uKjJI7/G4nf7dkgcKILkI/t57L9zuZfT/gGNdE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247481.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40AJbcSs030470; Wed, 10 Jan 2024 19:41:04 GMT Received: from mxout23.cac.washington.edu (mxout23.cac.washington.edu [140.142.32.140]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3vj0fjrsd2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jan 2024 19:41:04 +0000 Received: from smtp.washington.edu (smtp.washington.edu [128.208.60.54]) by mxout23.cac.washington.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 40AJeghl027799 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Jan 2024 11:40:42 -0800 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.154.74.143]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 40AJefnD020412 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jan 2024 11:40:42 -0800 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui <kmatsui@gcc.gnu.org> To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui <kmatsui@gcc.gnu.org> Subject: [PATCH 04/14] libstdc++: Optimize std::is_floating_point compilation performance Date: Wed, 10 Jan 2024 01:22:55 -0800 Message-ID: <20240110194031.2384005-5-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240110194031.2384005-1-kmatsui@gcc.gnu.org> References: <20240110194031.2384005-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: m1-vzlpp1bij5wp0T7LRH7YIfaHfTOwd X-Proofpoint-ORIG-GUID: m1-vzlpp1bij5wp0T7LRH7YIfaHfTOwd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-10_10,2024-01-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 adultscore=0 impostorscore=0 phishscore=0 clxscore=1034 mlxlogscore=380 mlxscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401100156 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DATE_IN_PAST_06_12, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787733763787442359 X-GMAIL-MSGID: 1787733763787442359 |
Series |
Optimize integral-related type traits
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
Ken Matsui
Jan. 10, 2024, 9:22 a.m. UTC
This patch optimizes the compilation performance of
std::is_floating_point by dispatching to the new
__is_floating_point built-in trait.
libstdc++-v3/ChangeLog:
* include/std/type_traits (is_floating_point): Use
__is_floating_point built-in trait.
(is_floating_point_v): Likewise.
Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
---
libstdc++-v3/include/std/type_traits | 13 +++++++++++++
1 file changed, 13 insertions(+)
Comments
On Wed, 10 Jan 2024 at 19:43, Ken Matsui <kmatsui@gcc.gnu.org> wrote: > > This patch optimizes the compilation performance of > std::is_floating_point by dispatching to the new > __is_floating_point built-in trait. OK for trunk (if the new built-in is approved). > > libstdc++-v3/ChangeLog: > > * include/std/type_traits (is_floating_point): Use > __is_floating_point built-in trait. > (is_floating_point_v): Likewise. > > Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org> > --- > libstdc++-v3/include/std/type_traits | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits > index afa281d9cc4..23ea70eca18 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -470,6 +470,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > { }; > #endif > > +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_floating_point) > + /// is_floating_point > + template<typename _Tp> > + struct is_floating_point > + : public __bool_constant<__is_floating_point(_Tp)> > + { }; > +#else > /// @cond undocumented > template<typename> > struct __is_floating_point_helper > @@ -529,6 +536,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > struct is_floating_point > : public __is_floating_point_helper<__remove_cv_t<_Tp>>::type > { }; > +#endif > > /// is_array > #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_array) > @@ -3238,8 +3246,13 @@ template <typename _Tp> > inline constexpr bool is_integral_v = is_integral<_Tp>::value; > #endif > > +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_floating_point) > +template <typename _Tp> > + inline constexpr bool is_floating_point_v = __is_floating_point(_Tp); > +#else > template <typename _Tp> > inline constexpr bool is_floating_point_v = is_floating_point<_Tp>::value; > +#endif > > #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_array) > template <typename _Tp> > -- > 2.43.0 >
diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index afa281d9cc4..23ea70eca18 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -470,6 +470,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION { }; #endif +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_floating_point) + /// is_floating_point + template<typename _Tp> + struct is_floating_point + : public __bool_constant<__is_floating_point(_Tp)> + { }; +#else /// @cond undocumented template<typename> struct __is_floating_point_helper @@ -529,6 +536,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION struct is_floating_point : public __is_floating_point_helper<__remove_cv_t<_Tp>>::type { }; +#endif /// is_array #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_array) @@ -3238,8 +3246,13 @@ template <typename _Tp> inline constexpr bool is_integral_v = is_integral<_Tp>::value; #endif +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_floating_point) +template <typename _Tp> + inline constexpr bool is_floating_point_v = __is_floating_point(_Tp); +#else template <typename _Tp> inline constexpr bool is_floating_point_v = is_floating_point<_Tp>::value; +#endif #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_array) template <typename _Tp>