Message ID | 20240109012453.675353-1-juzhe.zhong@rivai.ai |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp1381660dyq; Mon, 8 Jan 2024 17:25:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IG0WjDeYHuEFW9j9x/de4DTFo//+Fbk8QBskbeYHIgIHDCWdPG1yJUeUjLSbx98yWHmBQIz X-Received: by 2002:a05:6214:2121:b0:67a:27c4:31f9 with SMTP id r1-20020a056214212100b0067a27c431f9mr6543007qvc.11.1704763551026; Mon, 08 Jan 2024 17:25:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1704763551; cv=pass; d=google.com; s=arc-20160816; b=iXpuUc5ZqTCvBi/0+ZmQJRS5MNuxeWU1medd6grON7mMBoM3+3g44dW6yls90via7Q 1XntEiCo0VeamDLc/BxFOzVh31Mepxz8M2lqo/tEOYA9792a+COnKSNYpOW8TDxL6Q/P IiYfCBUwTY+fSIVe0TNHzggJeJARLkHzuR6/ah95XF58s5bLzU294zfs4mYq1D1qy4i6 v4ebxLn+BUmPHQOu7McCM+7oTKVnMoOlaFzTR0LKRAVx1YFJvIg2NF7DO9RdwBvE4xvP eoB+WZfz26CKDH0XmI3qxo0shn4mwOOBqy+pkvfCryrwX3lkdOv3Ypv6R/voMvAc3jEG dY3w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:feedback-id :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:arc-filter:dmarc-filter:delivered-to; bh=ANFJHabavULa2tfuddMMKId47sgrKTa+cYmivALnM6U=; fh=12MRPJmZ1mgDpHqWoogMKqnaGRGM2b7lcuJroqfjJiw=; b=qai1PSLYh+serOqpsWkYTCqk3YzXCQ5JXI4CMULwvIYydX5USbgtXbGuw7ulPqA48Z 3edMq6h2PHy/RRK9vbhdH++XHaHVc1qZHXG97Y17ZEShPMaga48vABOOK+4sD8+gosZp ug2MRWT2IQYTPMGjn+ME6LFMOnjAFxyxYWDU8H7RQKSh6ZN3oHohwFJNUqprtvGvqEnQ lQkmsqiXd88o8mAzh+/lvj/mm3eeUr+83TPU0xosefS+jZrL+7fhYEu/HPf9xEo3PTZf ErP4V7IPsTp4BqxUTxEsY1GoYmX84/u0EFabB09hYTUQbngpmwKbIOxnvSWU/uxUhIr6 Jd3Q== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id s28-20020a05620a031c00b007832049e5dasi947834qkm.545.2024.01.08.17.25.50 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 17:25:51 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9B550385841F for <ouuuleilei@gmail.com>; Tue, 9 Jan 2024 01:25:50 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130]) by sourceware.org (Postfix) with ESMTPS id 374613858D38 for <gcc-patches@gcc.gnu.org>; Tue, 9 Jan 2024 01:25:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 374613858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 374613858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=54.204.34.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704763505; cv=none; b=EiLlNxPS3GGtWWMGOGrKukv0aKTgusjJEg/3i8643N2bZBm1Ow6ZHlXRjrEUTrsZEtFC896MTMDm98oZjQsUMxQ0/Gh999kENKuNdiW/ze+6alSFYAU5RdCiQo6NNpSvM4l1Xh7aFjElTRGvYz/EBGw7mD/VjKlkrloUaWya7i8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704763505; c=relaxed/simple; bh=2wuyda8AUJcvEbiw5fH9gDecQPt3jX0/AGQH/770Qlw=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=XdcA0rh7XL2rnfE2FaLkf/s/++qt87BLEHCGKSU54OMPt99e96a6L3a4MJ4EjQvxCe+Iikq06bAesj0XDlccGaaDHM8+MF26DC9sDfGp/cIOTsfbNXcY6l4Ks/58ZRZenHxkQIfuvVi+GDD4EHJQIrj9A6M+f6B3xDsWMkJvqac= ARC-Authentication-Results: i=1; server2.sourceware.org X-QQ-mid: bizesmtp88t1704763495t5vap94x Received: from rios-cad121.hadoop.rioslab.org ( [58.60.1.9]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 09 Jan 2024 09:24:54 +0800 (CST) X-QQ-SSF: 01400000000000G0V000000A0000000 X-QQ-FEAT: mVW5qUmWNiuVUp9dK0WDNH+WjEsm3WpHfIYPE6bKe3ivc2xwnZsy1mII/donQ L99WmTdKCY7s5knVLLkGFAqfhPBSeiOc4g5AlLVXWYYIGep78ceDJyBPkLPwmAY+GPfgeZ7 x14ohd+kkgzH4vKJX4gSmow4UQTSuDQmtxarl+Q9p1QTYwxLggZdILxaw2ouji7iuPXAq4X 5n6AG2K3/NuIegEdJQW1NSVRtP5A8/8IPp7V1UWMfAANcn9B66l3ugdZJre5ug3959DZgJd hCKpEcgjXcwNCKutu1bxCtl7/eAtAjKLcBcoWPZeYmzdULt9rNSCJnSKqFJelGB0VsyuUVg wvJw8MRt0VyvnD9daCDQX53G+CwP4J0AtTFihwKVWPelWin3ruA7+tgJ3NMBg== X-QQ-GoodBg: 2 X-BIZMAIL-ID: 8764608830665861480 From: Juzhe-Zhong <juzhe.zhong@rivai.ai> To: gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, kito.cheng@sifive.com, jeffreyalaw@gmail.com, rdapp.gcc@gmail.com, Juzhe-Zhong <juzhe.zhong@rivai.ai> Subject: [PATCH] RISC-V: Fix loop invariant check Date: Tue, 9 Jan 2024 09:24:53 +0800 Message-Id: <20240109012453.675353-1-juzhe.zhong@rivai.ai> X-Mailer: git-send-email 2.36.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz7a-one-0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787574145075432784 X-GMAIL-MSGID: 1787574145075432784 |
Series |
RISC-V: Fix loop invariant check
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
juzhe.zhong@rivai.ai
Jan. 9, 2024, 1:24 a.m. UTC
As Robin suggested, remove gimple_uid check which is sufficient for our need. Tested on both RV32/RV64 no regression, ok for trunk ? gcc/ChangeLog: * config/riscv/riscv-vector-costs.cc (loop_invariant_op_p): Fix loop invariant check. --- gcc/config/riscv/riscv-vector-costs.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
OK. I'm still a bit unsure about whether SSA_NAME_IS_DEFAULT_DEF can really occur but if it does it's not wrong to treat it as loop invariant. Regards Robin
diff --git a/gcc/config/riscv/riscv-vector-costs.cc b/gcc/config/riscv/riscv-vector-costs.cc index 3bae581d6fd..f4a1a789f23 100644 --- a/gcc/config/riscv/riscv-vector-costs.cc +++ b/gcc/config/riscv/riscv-vector-costs.cc @@ -241,7 +241,7 @@ loop_invariant_op_p (class loop *loop, if (SSA_NAME_IS_DEFAULT_DEF (op) || !flow_bb_inside_loop_p (loop, gimple_bb (SSA_NAME_DEF_STMT (op)))) return true; - return gimple_uid (SSA_NAME_DEF_STMT (op)) & 1; + return false; } /* Return true if the variable should be counted into liveness. */