From patchwork Wed Dec 20 13:43:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 181643 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp2644500dyi; Wed, 20 Dec 2023 05:44:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFl32+BLs6D+kJV5xH7soH1hLCCm02TDw+r2uM7STilsBkCfRfeH4Hc1tH7OC5TVmk4tIlh X-Received: by 2002:ae9:e211:0:b0:781:19b2:e1b with SMTP id c17-20020ae9e211000000b0078119b20e1bmr1008qkc.96.1703079891090; Wed, 20 Dec 2023 05:44:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1703079891; cv=pass; d=google.com; s=arc-20160816; b=Cz7KMHjm5Wqn62ZAmx81aoY091dx9yzLRz4xC9E4qPh3DJ8a11nzewscu6jCBXoXTu x9rSIGiIxUhGCrPKIm2160UrT5Ny8MXJubF0i/9nmQL6nUa/CitBRPI7xfVeIj4WJao7 PVmvquXHVEmuPSQ4knc9NggE/2S6F6c67W9d6bKBxPQ/E9DiraEpTFRTwb5+EU5ZapFs ih8i6UrJ36eUx4iX0mWX3+TPSC402HaUyU22211wn5Ghg+bRsUeA2auwZCWx3SgmJ8Af Bn7K3CsjltjSYzn55jS5fRubb2WjVZWHoiRSyVnhi82y6qbpXuEEYZ6qeBUR0XYac+Gg H5tw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:errors-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :subject:to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=9+RpNOgpHE6Jo7vAYGYw7mTAPcgFAPQL9Njqh2Ub2bU=; fh=hPrbWPhweUx4V0GV9uXJqbyAzg2ABmTz7kczrAQqMmM=; b=s3znOXlY+LJBEjIEmpwn3rBMned6BzPYbSTlxoEVgJSw4Hpj2AspRpLrlTsQNZAIZm zAjaPVEy8cDXva90Y4rnv75dru/j99QugUX6C8/wRWKhj6ffIAg+9oEufdGk269y8jeF DgvbXkygPiqCDE5pT0Vh7zIT89IHdRz0TrbFe4wOGZJnu9R1BlezIpYAU7owCnGCWWh9 8kYany56sp02OXI2YQ0aqL6et/pODZYpxmem/RnT5UNRjhO9k2l9YXqrLpXR39SY6sHv i8WYbtntbBJmaqJkwdwbouiKefrVPlqRcJKh6pFvi7yUGC0l8Ar+2og5JsH7s4YH4mJb io8w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=iqBGgL7F; dkim=neutral (no key) header.i=@suse.de header.b=nBH3Z04Q; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=iqBGgL7F; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=nBH3Z04Q; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id c1-20020a37e101000000b00774165a6970si26941512qkm.488.2023.12.20.05.44.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 05:44:51 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=iqBGgL7F; dkim=neutral (no key) header.i=@suse.de header.b=nBH3Z04Q; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=iqBGgL7F; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=nBH3Z04Q; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CBA93386181E for ; Wed, 20 Dec 2023 13:44:50 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 395A73858D20 for ; Wed, 20 Dec 2023 13:44:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 395A73858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 395A73858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703079868; cv=none; b=Kc6OOBW2kVIpBpOTrMh2sCiVgNTvgGUvYoE5jK4ohxXlxyz0dsGCjybsbh9njqfPKJNk4xLVEs/d9bKs5wNT+HqoIdm+DVFqd0Jn5bjMA+0gzGKXjLotDr9OXmGXzny544MCk0OpNYk3zsKjpuiwN93jBRiJMC9zF1/f6WpB3rs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703079868; c=relaxed/simple; bh=u6hkAb0C+DLEB/V7xRfd2B9KFtWosr4EyXX7+HWkIlM=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=hk2uK9sES3nUcgTBziLxlZeGkimPqw3WwYZv0wksULn+yDj7v5OJGETCzkogUqkVw/xGesPA3MSJpt75k9JCqtrYsWpDJALqUazcQZz7AnC1ljQtEATXwpKCfdD5Ez49gUCbiVkTOP0pMHqnYSxqnUpvHLTk5hnjnURppwIvEhg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 153B31F82E for ; Wed, 20 Dec 2023 13:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1703079866; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=9+RpNOgpHE6Jo7vAYGYw7mTAPcgFAPQL9Njqh2Ub2bU=; b=iqBGgL7FHNTFQj+HBvq8DXpsp+ZGtbanPtsoT5tXifp5k4PYz78WVot0yCnRCmPkbPQk+m 435HnldVYkmDW4DJm/Zn/UH0DWPGyYSdmwsH7KzqobO0aohnUgJzu9VXJgZ24zllQeIE7Q w9+LUPLRRkFL/bagpYWs1tDnf7IZoPY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1703079866; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=9+RpNOgpHE6Jo7vAYGYw7mTAPcgFAPQL9Njqh2Ub2bU=; b=nBH3Z04QxD97VNUs6eWnzJJWR7wONBvCeWaw2UX1pxT1OGoajce6VxmU3GLE6Hv7F2aOrU tHOWyKsyP0k/Y3BQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1703079866; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=9+RpNOgpHE6Jo7vAYGYw7mTAPcgFAPQL9Njqh2Ub2bU=; b=iqBGgL7FHNTFQj+HBvq8DXpsp+ZGtbanPtsoT5tXifp5k4PYz78WVot0yCnRCmPkbPQk+m 435HnldVYkmDW4DJm/Zn/UH0DWPGyYSdmwsH7KzqobO0aohnUgJzu9VXJgZ24zllQeIE7Q w9+LUPLRRkFL/bagpYWs1tDnf7IZoPY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1703079866; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=9+RpNOgpHE6Jo7vAYGYw7mTAPcgFAPQL9Njqh2Ub2bU=; b=nBH3Z04QxD97VNUs6eWnzJJWR7wONBvCeWaw2UX1pxT1OGoajce6VxmU3GLE6Hv7F2aOrU tHOWyKsyP0k/Y3BQ== Date: Wed, 20 Dec 2023 14:43:13 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Improve DCE of dead parts of a permute chain MIME-Version: 1.0 Authentication-Results: smtp-out2.suse.de; none X-Spam-Score: 1.35 X-Spamd-Result: default: False [1.35 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_SPAM_SHORT(2.93)[0.977]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-2.99)[99.94%] X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Message-Id: <20231220134450.CBA93386181E@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785808699787889905 X-GMAIL-MSGID: 1785808699787889905 gcc.dg/vect/bb-slp-pr78205.c is reported to have regressed with the PR113073 change and in the end it's due to the DCE performed by vect_transform_slp_perm_load_1 being imperfect. The following enhances it to also cover the CTOR and VIEW_CONVERT operations that might be involved. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. * tree-vect-slp.cc (vect_transform_slp_perm_load_1): Also handle CTOR and VIEW_CONVERT up to the load when performing chain DCE. --- gcc/tree-vect-slp.cc | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index a82fca45161..1a357cb7549 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -8634,10 +8634,21 @@ vect_transform_slp_perm_load_1 (vec_info *vinfo, slp_tree node, for (unsigned i = 0; i < dr_chain.length (); ++i) if (!bitmap_bit_p (used_defs, i)) { - gimple *stmt = SSA_NAME_DEF_STMT (dr_chain[i]); - gimple_stmt_iterator rgsi = gsi_for_stmt (stmt); - gsi_remove (&rgsi, true); - release_defs (stmt); + tree def = dr_chain[i]; + do + { + gimple *stmt = SSA_NAME_DEF_STMT (def); + if (is_gimple_assign (stmt) + && (gimple_assign_rhs_code (stmt) == VIEW_CONVERT_EXPR + || gimple_assign_rhs_code (stmt) == CONSTRUCTOR)) + def = single_ssa_tree_operand (stmt, SSA_OP_USE); + else + def = NULL; + gimple_stmt_iterator rgsi = gsi_for_stmt (stmt); + gsi_remove (&rgsi, true); + release_defs (stmt); + } + while (def); } return true;