From patchwork Tue Dec 19 14:30:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Marc_Poulhi=C3=A8s?= X-Patchwork-Id: 181011 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp1981322dyi; Tue, 19 Dec 2023 06:36:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IG3gwa6Tgnn+Pn0/e2QKErkv23u2y45Fv7aEvFFqIVqHDj5+onf1pk3I0szF7+zvx0KXWkr X-Received: by 2002:ad4:4ea1:0:b0:67f:4437:df3f with SMTP id ed1-20020ad44ea1000000b0067f4437df3fmr1883090qvb.45.1702996606264; Tue, 19 Dec 2023 06:36:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702996606; cv=pass; d=google.com; s=arc-20160816; b=y6XpzkIXumqFxmKAWkhUSigGddBhm+SASXdbFAe13P2vQhFTSS9tLmgEAjxyE5p2yB 1U+tVFK/UdryI/60eIlRgAmQMdPE9uK55J/5ty6pRE4OBue41g1zTk7FWdk5Prclgb+J VDbJfu3YpGuCug8r5k9W8FD9NhdZkMiAGTW5CAjpcL/WtD6x2YiEJHb1cSg+Cg+9PnnJ YXEaUSpBLTSM5lSUqOeGCybZc57bbstMTvfG8ux9fLcdEgxfhHKYT1tmaVzHWsG8PuD/ ZSQc46Cnc7kBTmvrZ+yfA5dk4y7ifPCf5kkTyLXDlkm/GRtCV4NZ6xHk6+Mgk/w/lMLQ swDA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=B0FPBLig5itptVH6kIfvcdSYnRNUEvwPHf5iXjzqVYc=; fh=NbwF4zAYSd52x6O+6MEbVyBLggGaBjxZHfOUZjnFTMc=; b=nShV0vuKRnlUJ0MzG5ammd7TolnH+OeCN3RzF9WYzHfkx7l0+OuDVFnKPOv65QAKjC yljkz5CEm1KNmcgBWDUmX5jWAbKaNppq56dUl1duW5LGbfh653AJ1IecPkwsb7TgQhjU OBcdxgEwPcatwdtnExiM5RvTLwqwQDdFc2Mn0xO2wbfoXLsHokIqFlBcR4PnrxuyDZXB njA57nXENIh4m3hlriTqnW020wKWFWC2UM0sVy58guIy8yrmJFp/Jjn8H/qYuqzMXcBG Iyo/3fkrWagioXEl8wlrwU1hPFn328ffADDo4G03T0PPhQmaZ6RRM8BQ1xEIswThu1AU fbsQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@adacore.com header.s=google header.b=RVum5dxE; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=adacore.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id w20-20020a05620a0e9400b007810ade4aa2si324470qkm.485.2023.12.19.06.36.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 06:36:46 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@adacore.com header.s=google header.b=RVum5dxE; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=adacore.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 768EE3894C3C for ; Tue, 19 Dec 2023 14:33:31 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 3D13B386101B for ; Tue, 19 Dec 2023 14:30:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D13B386101B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3D13B386101B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::434 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702996257; cv=none; b=NNHujLRbu3URFeHRg5lAavSVhDf5anACGhBsIHEiUeUCGmNLbDrTthY37Bs9s51xQstMSnGvFcLuB6/AnvdfIs7Vzz1sob3XBUoSmWRvxOw6ptAcKyjwLib23VsxcVUS77TABQIwAO8G7TGKT5lMC1qqfpXZUEo56iVP7BYqsnU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702996257; c=relaxed/simple; bh=LFZPk20z2lv7Sq8p7F3EROSDEC/3vgys1zY6s4cRu1c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=sbjTZ5yrgsczzb7KrHqZHaXmvd6xPj2VplMMV0qAO1Huqg3ctspzbnHsNpTk6eSgDHQCgpGHS4dJCh1I7Y5bwceb9DrH+HlkzFztG5to3KCgDWLybDKoogezEPf0MPAfwBrd+7apdwhaTOUQfidqh4zdarT/buDfWUn+C3+yOto= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-336668a5a8dso3117023f8f.1 for ; Tue, 19 Dec 2023 06:30:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1702996254; x=1703601054; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=B0FPBLig5itptVH6kIfvcdSYnRNUEvwPHf5iXjzqVYc=; b=RVum5dxE7w05U4Ul634sDq3jjDV+AyInkszHvoVf7/nw4bU4ZlRT2juyRBylwt8AEN vveGL/roy1NmyxQKESlDQceP0TZywTVk+6X2pky2hA4ONJTZ2bwhLjYdI2CIrR7TGblP GKeMuMlOwku55vZ2RDCwchW8g56s6ncLDW4aeXDkxGVlXp/P8d49ytDw/magB5ZHntL1 dTU3YAKxy/MNsvFNVmVRZsByyLmczzeLruRyNC+lOKdBeJoZjgx89Yt2Ps0XzEN7jB5o FwrKyGfFo0zZuZ3CXQXj799WEyks6eiOLvFRmbvlun5SWAH7/+MgB8kuThPDkAWsrDLy zOtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702996254; x=1703601054; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B0FPBLig5itptVH6kIfvcdSYnRNUEvwPHf5iXjzqVYc=; b=MzUAI5JSqkAGKHxS/TbE00/Ni6C7v3W55w+Z5mrl+XTmoILTJsxW4vftn5sNZniE52 uuzdVlXBYqr28mEG0ZjDSlQO0VvSytLZXvP57EdeWo73YLlOWpxPiXhEtJETBsCCFdyT 78gQVIGAWLXGX2ac88IZX0oBYtUj9CULLM2UHnMLbTjBIm7CryvSloKo+aHdQ76qLOlN 3OOL7iAsZRwLLwNQ7OT3Xk4lh19Wp7SMjgaY2Ie69aM/V4oYzgTLONANyp1UJE1W4Fpq Za4dAYZmiQiTJZLRtxMdKQMl5Bo3yE9oNCVkktQZHnBcD5iAFI3k0FPmzumV4k5n1OdJ 1iWA== X-Gm-Message-State: AOJu0YzWrofn1PC5uzCuXOgK1y/oMcR1qSmhyjBPlmKNmIyUlT0ZiBhP odwufprSbOOFC1LiBPRkqRNjepDT7OwwnPA385A= X-Received: by 2002:a5d:5551:0:b0:336:7142:8c30 with SMTP id g17-20020a5d5551000000b0033671428c30mr722456wrw.123.1702996254004; Tue, 19 Dec 2023 06:30:54 -0800 (PST) Received: from poulhies-Precision-5550.lan ([2001:861:3382:1a90:fe1e:443:c34f:edaa]) by smtp.gmail.com with ESMTPSA id z1-20020a5d4d01000000b003365aa39d30sm10900503wrt.11.2023.12.19.06.30.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 06:30:53 -0800 (PST) From: =?utf-8?q?Marc_Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Vasiliy Fofanov Subject: [COMMITTED] ada: Optimize performance and remove dynamic frame requirement. Date: Tue, 19 Dec 2023 15:30:52 +0100 Message-ID: <20231219143052.455554-1-poulhies@adacore.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785721369608239221 X-GMAIL-MSGID: 1785721369608239221 From: Vasiliy Fofanov gcc/ada/ * libgnat/i-cstrin.adb (Value): Optimize. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/libgnat/i-cstrin.adb | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/gcc/ada/libgnat/i-cstrin.adb b/gcc/ada/libgnat/i-cstrin.adb index 1eb28655004..73a0bc875bd 100644 --- a/gcc/ada/libgnat/i-cstrin.adb +++ b/gcc/ada/libgnat/i-cstrin.adb @@ -346,11 +346,13 @@ is end Value; function Value (Item : chars_ptr; Length : size_t) return String is - Result : char_array (0 .. Length); + Result : String (1 .. Natural (Length)); + C : char; begin pragma Annotate (Gnatcheck, Exempt_On, "Improper_Returns", "early returns for performance"); + -- As per AI-00177, this is equivalent to: -- To_Ada (Value (Item, Length) & nul); @@ -359,16 +361,17 @@ is raise Dereference_Error; end if; - for J in 0 .. Length - 1 loop - Result (J) := Peek (Item + J); + for J in Result'Range loop + C := Peek (Item + size_t (J - 1)); - if Result (J) = nul then - return To_Ada (Result (0 .. J)); + if C = nul then + return Result (1 .. J - 1); + else + Result (J) := To_Ada (C); end if; end loop; - Result (Length) := nul; - return To_Ada (Result); + return Result; pragma Annotate (Gnatcheck, Exempt_Off, "Improper_Returns"); end Value;