From patchwork Wed Dec 13 03:54:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Palmer Dabbelt X-Patchwork-Id: 177769 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp8163717vqy; Tue, 12 Dec 2023 19:55:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IGPtGvhukrGOLGfhmhxRRJNbQYF7A+X/PQgbiC4uicvIlUACkR2SPjolcKE9zkcScVDbnr8 X-Received: by 2002:ad4:5c65:0:b0:67a:a721:b1a9 with SMTP id i5-20020ad45c65000000b0067aa721b1a9mr9074198qvh.100.1702439750625; Tue, 12 Dec 2023 19:55:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702439750; cv=pass; d=google.com; s=arc-20160816; b=UNcDqrv3xjfy8Spe7zEduGyL30EFCGpZ2+39DZprCm3xc1zsOHXWvYdNf4hPthTX2e GWJTiDNcwUO7A5zNtxS5Yt4kQ2hRIuSI+/P0NWBZqsyfFtdnld1spgzQJAONkLKTFjfD qrWhtR9QMeY0IJr9Nu24MextzIFqtk+COTxKLyc0Q2JwmB9Ji4/gAEJ8+9q/kLRypTHU UF3ZItv1TDPzjzoPCb+H/LtSbZC8LH4qs4+Av6rk2ufewEnd9YAZsalwq8gsZ2gQ9BHk x5P9y/ZaMtIYKEvnE6gtyejJhzF5ZIpd0rEo6k3/xyV7G+yoNO/7AVPI2LnXCE5q1J+D g5gg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:to:from:cc :content-transfer-encoding:mime-version:message-id:date:subject :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=jxaLn5SifoVz1c1ZkzpBREjuMRc1qlg6ASUiNTWMs4Y=; fh=sU5DkjW7E2gzNbjuGhkUcPT8kDt9KEmCY/jPBbGVrG4=; b=F6JG1RmI2PrWC5c16wGP/W8s5hRybzzU78KOMy2kgDM0MLVBh2a9N6ugSrSYNcTsgd qkIsgKCSt7cFwKwJb7g7IciMYyOGcr6F5q50/I+OO7YAhp3/j5BqoPFWISpaHtUtHrQQ +xOl8JykEvq53OvzMaDMMyDVqDnpGEIuH50jWnb8gii2Dj0zwIElWppLMZdntxU/SojD ctYAw14NKYgzUCADqxLSIoM/BHw5mWp/CwjR+TwceSFc3h6MDEbgO00+6f/RwhguUoxw NrDNvb1XsDj042B0rhvzzkvNSFGzVwkp7GlDGVTHQiMXSdMROlsj1ici6a4IhXnokll4 qOYw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=sx0Blu2C; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id db7-20020a056214170700b0067a6d0c0b6bsi1198955qvb.81.2023.12.12.19.55.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 19:55:50 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=sx0Blu2C; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4E1D4385AC35 for ; Wed, 13 Dec 2023 03:55:50 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id 157BF3858C2F for ; Wed, 13 Dec 2023 03:55:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 157BF3858C2F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 157BF3858C2F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::235 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702439726; cv=none; b=JkQY1TJCo0Q9SuiVwJ+dRDHSzj4C6T1yqeb4BPEeKNZqm0DdTbXAYuktz/rEGGQtQU6SXrcJ7l5d177gz0gmiDLFOO6STj61w4QdM3h8Yky7J00D+5dlYT6bDl6z8mTJpfD7fQwpUs4eHcFrRMtqcAMZuZEiYG1BUlwlgMcUcHY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702439726; c=relaxed/simple; bh=o2yHOdWPwcccIkD8aNRTibYp2ocv5dRsvyYQtJM4MHA=; h=DKIM-Signature:Subject:Date:Message-ID:MIME-Version:From:To; b=mbCGMs21zgDkB3asOPcRnuuOI2D5s8Ik6i9qjaml2D80ZSAGnXKH4tdm2caK5l6GtIVEQkfYwxmUl6B1P5XQo2kv30BeSjdmzwA5mrOiw7gH/WUJaeAyHfsQFqrwQ2ipCz4cGvaozZob+Paq5v04DI2efGlUxbuffaWSl2hYRRk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-3b9d8bfe845so4956850b6e.0 for ; Tue, 12 Dec 2023 19:55:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1702439724; x=1703044524; darn=gcc.gnu.org; h=to:from:cc:content-transfer-encoding:mime-version:message-id:date :subject:from:to:cc:subject:date:message-id:reply-to; bh=jxaLn5SifoVz1c1ZkzpBREjuMRc1qlg6ASUiNTWMs4Y=; b=sx0Blu2Ckwc76bOCU9MgelLuQCy46fqPedCLNZ/JkeK7MJTsHJRI23TVw8c1tdFynN D9I9DCT0+MqaQmQDaQaYb9RAwzdXYhbCyf3sDPXRZ/JfZln1pNVhbL5LkV22YPhE28rp FvsKwD48KEZ3CZHy8WyaDtK5pugEmFy+9igNJRqlYvFPlvntLjGljY7DIdvJJDl2Cahv Nk5UM5+UvmMQBvDNLBnUW7eLK3b6+tSuv4BOhx9bzuuNZmZ9/fM8+jo95mT5tVOO6a+4 Std+9RKUCeTlWb+2ZiwgKJvBgCEhL5qyHMPNqxV2NYfn70CoGyhvFY6oJ74lWMT95lf/ gguQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702439724; x=1703044524; h=to:from:cc:content-transfer-encoding:mime-version:message-id:date :subject:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jxaLn5SifoVz1c1ZkzpBREjuMRc1qlg6ASUiNTWMs4Y=; b=MKq+Ej2OtqNkHDGTIO54JoFmwfvVvAftYszzDFLZ3pQ9gVjPkkTPCAdYF59+Y8cF0C FyBdI7KDiHJ7LhVJacqxuQDku0W9UVJEcb4wO9CeaKaDzRGypFOyG8+5yU2Si7SSB1mV PqJ7SrJBES6d6LwSAs3s2R5rPCY7l4ElsUfhFlzd4n8oD2tQiwHyH3QIKG4NAFvOG8Ja RhyrlxS+s/RZhgnWF7q8+zEbpNYIeY/uqiQcQpWPE0xxN5N0IPBHg66e/tJR3/6v4sI2 LBQIIS9WsCASOuzkxO9M73A3PhSaBjt+0bnF8qvCvs2dZUtjdWpUEU/GC0VDSpM+jJnM 4OOA== X-Gm-Message-State: AOJu0YxUYdXmGjwx66yRN5Ma8Csf0aWRMjN3YzfkShT06tWXxqH88duK PWy0o45VmSLElT8oa26dogtOfQ== X-Received: by 2002:a05:6808:1a86:b0:3b8:b063:6bc0 with SMTP id bm6-20020a0568081a8600b003b8b0636bc0mr7492422oib.111.1702439724205; Tue, 12 Dec 2023 19:55:24 -0800 (PST) Received: from localhost ([192.184.165.199]) by smtp.gmail.com with ESMTPSA id 18-20020aca0912000000b003b85cc30fe8sm2770183oij.36.2023.12.12.19.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 19:55:23 -0800 (PST) Subject: [PATCH] RISC-V: Don't make Ztso imply A Date: Tue, 12 Dec 2023 19:54:05 -0800 Message-ID: <20231213035405.2118-1-palmer@rivosinc.com> X-Mailer: git-send-email 2.42.1 MIME-Version: 1.0 Cc: Palmer Dabbelt From: Palmer Dabbelt To: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785137463473099901 X-GMAIL-MSGID: 1785137463473099901 I can't actually find anything in the ISA manual that makes Ztso imply A. In theory the memory ordering is just a different thing that the set of availiable instructions (ie, Ztso without A would still imply TSO for loads and stores). It also seems like a configuration that could be sane to build: without A it's all but impossible to write any meaningful multi-core code, and TSO is really cheap for a single core. That said, I think it's kind of reasonable to provide A to users asking for Ztso. So maybe even if this was a mistake it's the right thing to do? gcc/ChangeLog: * common/config/riscv/riscv-common.cc (riscv_implied_info): Remove {"ztso", "a"}. --- gcc/common/config/riscv/riscv-common.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc index f142212f2ed..5f39e5ea462 100644 --- a/gcc/common/config/riscv/riscv-common.cc +++ b/gcc/common/config/riscv/riscv-common.cc @@ -71,8 +71,6 @@ static const riscv_implied_info_t riscv_implied_info[] = {"zks", "zksed"}, {"zks", "zksh"}, - {"ztso", "a"}, - {"v", "zvl128b"}, {"v", "zve64d"},