Message ID | 20231212100132.3006956-1-demin.han@starfivetech.com |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp7617606vqy; Tue, 12 Dec 2023 02:02:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGfbtm81tReo0y2zS8PTj4sSyi/nPWWiCUCK4c4johxNXtusBjYRpnrZ/q5wv6sh05/fUF4 X-Received: by 2002:a05:6808:6508:b0:3b9:e862:111b with SMTP id fm8-20020a056808650800b003b9e862111bmr6567261oib.47.1702375322796; Tue, 12 Dec 2023 02:02:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702375322; cv=pass; d=google.com; s=arc-20160816; b=zPsp7gxRYLUW0cqWzJcN7zP8xAcqJ8T5Xo8sdHCmrqCvECzaIMxRcW5LFMh2PvanJl 7vZ5mPxrc8NGfKGkLsjrlew4S1UlrXSVgnMTqPazjnmURzly7KgwgBw+gKXqy5/+neLY k3KWWlRihd26K/ExN/ebHLovDdQZYd0yUSpRatVGUHPkT7A/xf/gex707j/zR5URlldN 4Rag6RZDkpaIaJRlWr8ahVlGm313z/2Pi/6tpQ1nleZYx+cqOFayYCyJZz1vpSg65PUA 9za7qeGKU3n7nzlPy4FRK5RRZ8VWXA/FL5u9jliqf7uOvs9PhAwlDdgxk+Eg0KxBEGfs QPwg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:arc-filter :dmarc-filter:delivered-to; bh=10rN6a5+LLC5AfcF/Ogof3sCf19MpJh4yybE6xp8ems=; fh=damxhKJ+GrdknhcErj34w/RFbs0Uy0nIZaPvrimAj+I=; b=nzL+5C92vpxqC5upOvFYhdos9GLQvSndVO2gwrZq+NwToLEkevMrin1r3oP8FNiASd sf0LwSjGWxhdP3/ktAnQI9PnLNCI2Df3J1+ckJguj+Vi1Yu0viphgusvlOEhcxZGflHA YN1NJI/4KML5D8c/Y3tiUwgALZSlGQx9wEfUNq5sk0l4+deCW4e7paMvPxMzr0LEhM7j 3Fb7OJ7fyPTmcokfjM0LGtKT/QQUrx9YMEsBBPB+bedLAQkFUBxk4QRMqwQgkET0mt13 tie3VzoS6DPsHFsmoHaKdTlZfAi1nKNlGgoTOpIXeSYatJ1v0CBFTjGUvgedi51G4k9H CJpA== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id m14-20020ad44b6e000000b0067a88ee4217si10113296qvx.517.2023.12.12.02.02.02 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 02:02:02 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 84A383857BAA for <ouuuleilei@gmail.com>; Tue, 12 Dec 2023 10:02:01 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by sourceware.org (Postfix) with ESMTPS id 4142A3858415 for <gcc-patches@gcc.gnu.org>; Tue, 12 Dec 2023 10:01:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4142A3858415 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=starfivetech.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=starfivetech.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4142A3858415 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=61.152.239.71 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702375296; cv=none; b=hOjBEdsLX4FdQ1XNHxXXMWQwEXYXARS4GxCgQwU0Cz+8na94K0RfhK0J8vO75ShasL6JHKRvUiAwQlgNlRpJdkElUW3p4bFgaWp2fXhoWTs7vKCHQR9Bep1igBK0jGr95LjGxHxL9ZeHOv5Zpy3nvSWtFr+VQ7zrDdSlweU6LJk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702375296; c=relaxed/simple; bh=u3ZdetP8/X3bBwGF6bArcVVAD/DqRnPJXnnn9vL6zDU=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=nVV2s1F8llB/evzDRNBLUHWo7Ksf3OKwJ9sme/gSIVQz7FQ+2aS8eVdGdxRx4njtcrUxkkCyagSMwNm9RnyqYh+EHllgo4dWe9gebUMC789JLaQFV4z0hzwRmHHverIT0grAfqMTm/xEuSuhwOLl7lzFcYworiOP6T5WnJo41/s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 25F408086; Tue, 12 Dec 2023 18:01:19 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 12 Dec 2023 18:01:19 +0800 Received: from damon-pc.localdomain (183.27.97.57) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 12 Dec 2023 18:01:18 +0800 From: demin.han <demin.han@starfivetech.com> To: <gcc-patches@gcc.gnu.org> CC: <juzhe.zhong@rivai.ai>, <pan2.li@intel.com> Subject: [PATCH] RISC-V: Fix dynamic lmul tests depended on abi Date: Tue, 12 Dec 2023 18:01:32 +0800 Message-ID: <20231212100132.3006956-1-demin.han@starfivetech.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [183.27.97.57] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785069906683849942 X-GMAIL-MSGID: 1785069906683849942 |
Series |
RISC-V: Fix dynamic lmul tests depended on abi
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
demin.han
Dec. 12, 2023, 10:01 a.m. UTC
These two tests depend on -mabi.
Other toolchain configs would report:
fatal error: gnu/stubs-ilp32.h: No such file or directory
gcc/testsuite/ChangeLog:
* gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c: Fix abi issue
* gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c: Ditto
Signed-off-by: demin.han <demin.han@starfivetech.com>
---
.../gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c | 4 +++-
.../gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
Comments
A more reasonable solution is the add riscv_vector.h into gcc.dg/vect/costmodel/riscv/rvv with the following codes in riscv_vector.h: /* Wrapper of riscv_vector.h, prevent riscv_vector.h including stdint.h from C library, that might cause problem on testing RV32 related testcase when we disable multilib. */ #ifndef _RISCV_VECTOR_WRAP_H #define _GCC_WRAP_STDINT_H #include "stdint-gcc.h" #include_next <riscv_vector.h> #define _RISCV_VECTOR_WRAP_H #endif juzhe.zhong@rivai.ai From: demin.han Date: 2023-12-12 18:01 To: gcc-patches@gcc.gnu.org CC: juzhe.zhong@rivai.ai; pan2.li@intel.com Subject: [PATCH] RISC-V: Fix dynamic lmul tests depended on abi These two tests depend on -mabi. Other toolchain configs would report: fatal error: gnu/stubs-ilp32.h: No such file or directory gcc/testsuite/ChangeLog: * gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c: Fix abi issue * gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c: Ditto Signed-off-by: demin.han <demin.han@starfivetech.com> --- .../gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c | 4 +++- .../gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c b/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c index 8e6610b0e11..7fd397b782e 100644 --- a/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c +++ b/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c @@ -1,5 +1,7 @@ /* { dg-do compile } */ -/* { dg-options "-march=rv32gcv -mabi=ilp32 -O3 -ftree-vectorize --param riscv-autovec-lmul=dynamic -Wno-psabi -fdump-tree-vect-details" } */ +/* { dg-options "-O3 -ftree-vectorize --param riscv-autovec-lmul=dynamic -Wno-psabi -fdump-tree-vect-details" } */ +/* { dg-additional-options "-march=rv32gcv" { target riscv32*-*-* } } */ +/* { dg-additional-options "-march=rv64gcv" { target riscv64*-*-* } } */ #include "riscv_vector.h" diff --git a/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c b/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c index b3498ad8210..5fd27cb01e1 100644 --- a/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c +++ b/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c @@ -1,5 +1,7 @@ /* { dg-do compile } */ -/* { dg-options "-march=rv32gcv -mabi=ilp32 -O3 -ftree-vectorize --param riscv-autovec-lmul=dynamic -fdump-tree-vect-details" } */ +/* { dg-options "-O3 -ftree-vectorize --param riscv-autovec-lmul=dynamic -fdump-tree-vect-details" } */ +/* { dg-additional-options "-march=rv32gcv" { target riscv32*-*-* } } */ +/* { dg-additional-options "-march=rv64gcv" { target riscv64*-*-* } } */ #include "riscv_vector.h" -- 2.43.0
Thanks for the suggestion. The target selector method can not cover some cases. On 2023/12/12 18:05, juzhe.zhong@rivai.ai wrote: > A more reasonable solution is the add riscv_vector.h into gcc.dg/vect/costmodel/riscv/rvv > with the following codes in riscv_vector.h: > > /* Wrapper of riscv_vector.h, prevent riscv_vector.h including stdint.h from > C library, that might cause problem on testing RV32 related testcase when > we disable multilib. */ > #ifndef _RISCV_VECTOR_WRAP_H > > #define _GCC_WRAP_STDINT_H > #include "stdint-gcc.h" > #include_next <riscv_vector.h> > #define _RISCV_VECTOR_WRAP_H > > #endif > > > > juzhe.zhong@rivai.ai > > From: demin.han > Date: 2023-12-12 18:01 > To: gcc-patches@gcc.gnu.org > CC: juzhe.zhong@rivai.ai; pan2.li@intel.com > Subject: [PATCH] RISC-V: Fix dynamic lmul tests depended on abi > These two tests depend on -mabi. > Other toolchain configs would report: > fatal error: gnu/stubs-ilp32.h: No such file or directory > > gcc/testsuite/ChangeLog: > > * gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c: Fix abi issue > * gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c: Ditto > > Signed-off-by: demin.han <demin.han@starfivetech.com> > --- > .../gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c | 4 +++- > .../gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c b/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c > index 8e6610b0e11..7fd397b782e 100644 > --- a/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c > +++ b/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c > @@ -1,5 +1,7 @@ > /* { dg-do compile } */ > -/* { dg-options "-march=rv32gcv -mabi=ilp32 -O3 -ftree-vectorize --param riscv-autovec-lmul=dynamic -Wno-psabi -fdump-tree-vect-details" } */ > +/* { dg-options "-O3 -ftree-vectorize --param riscv-autovec-lmul=dynamic -Wno-psabi -fdump-tree-vect-details" } */ > +/* { dg-additional-options "-march=rv32gcv" { target riscv32*-*-* } } */ > +/* { dg-additional-options "-march=rv64gcv" { target riscv64*-*-* } } */ > #include "riscv_vector.h" > diff --git a/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c b/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c > index b3498ad8210..5fd27cb01e1 100644 > --- a/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c > +++ b/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c > @@ -1,5 +1,7 @@ > /* { dg-do compile } */ > -/* { dg-options "-march=rv32gcv -mabi=ilp32 -O3 -ftree-vectorize --param riscv-autovec-lmul=dynamic -fdump-tree-vect-details" } */ > +/* { dg-options "-O3 -ftree-vectorize --param riscv-autovec-lmul=dynamic -fdump-tree-vect-details" } */ > +/* { dg-additional-options "-march=rv32gcv" { target riscv32*-*-* } } */ > +/* { dg-additional-options "-march=rv64gcv" { target riscv64*-*-* } } */ > #include "riscv_vector.h"
diff --git a/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c b/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c index 8e6610b0e11..7fd397b782e 100644 --- a/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c +++ b/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul1-7.c @@ -1,5 +1,7 @@ /* { dg-do compile } */ -/* { dg-options "-march=rv32gcv -mabi=ilp32 -O3 -ftree-vectorize --param riscv-autovec-lmul=dynamic -Wno-psabi -fdump-tree-vect-details" } */ +/* { dg-options "-O3 -ftree-vectorize --param riscv-autovec-lmul=dynamic -Wno-psabi -fdump-tree-vect-details" } */ +/* { dg-additional-options "-march=rv32gcv" { target riscv32*-*-* } } */ +/* { dg-additional-options "-march=rv64gcv" { target riscv64*-*-* } } */ #include "riscv_vector.h" diff --git a/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c b/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c index b3498ad8210..5fd27cb01e1 100644 --- a/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c +++ b/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/dynamic-lmul2-4.c @@ -1,5 +1,7 @@ /* { dg-do compile } */ -/* { dg-options "-march=rv32gcv -mabi=ilp32 -O3 -ftree-vectorize --param riscv-autovec-lmul=dynamic -fdump-tree-vect-details" } */ +/* { dg-options "-O3 -ftree-vectorize --param riscv-autovec-lmul=dynamic -fdump-tree-vect-details" } */ +/* { dg-additional-options "-march=rv32gcv" { target riscv32*-*-* } } */ +/* { dg-additional-options "-march=rv64gcv" { target riscv64*-*-* } } */ #include "riscv_vector.h"