From patchwork Mon Dec 11 21:22:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 176917 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp7345767vqy; Mon, 11 Dec 2023 13:23:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IHoTFGIH5D1ugjmNod919OoAdATnFfngNijqB3Pj7MwEJgJt1j1IfO3KtEFfkTfbuV+ggiO X-Received: by 2002:a05:6808:3308:b0:3ba:fcd:a98f with SMTP id ca8-20020a056808330800b003ba0fcda98fmr2109123oib.51.1702329787268; Mon, 11 Dec 2023 13:23:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702329787; cv=pass; d=google.com; s=arc-20160816; b=jwGtm+RVCxT5Fy+Y1n0TDcGrSZm2lBkJ+nbnv86+EPqcqrJIqy3la500C/7DTtLa5B +gAKD9OgSUCeLG1UxBxYsFnNPOKuYIvyXmm9oiPn9z7T0etZn+9llqeLc8PDyO6wUL/m ZRMOKf6zYSjn3eMDtM579XktUTV53q5UznnBmpoqCWsfoJ04c6J8uHJjn+lALSdu1KF+ XCD8Y4rHZkXorVhCInbgmFAuAImHx36MEholhZk0X+se2m/WkZXS9sWn/pcB+TcW489F SQfSTMDYL8DJ4j7vXWzOtTeJBhUM8bAhITp79ERNCElOtNcO7JXv/Yu6dSH5JjxjsrGW LMgg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=5rdPQVEnN8Hac9S7q5/7kwwXBTcxZ3wWbvnNbxLhjRs=; fh=NXemEfxTRbZtBxUkxR2ehQUaYlcDfMdzPkO8MChVQE4=; b=kyugLZVCkLOMgydvzvD5nUfE93tRWhE4lbHZ8AWtcewotQShg3dEpBL7HLJVp4uCHr Um0OhShFi0PWGPHYCoAAEg1iBVLZQ9usFKS+AeZzhVsW8ELxORe4olNQAqcZvc4AeMcK PVuy2R0bRo3x50CxqpF2bpE+Tqv5vFhEnrowjP8Hn6tZBy/XkNNESJlQpBPD6hM7FTAU EdYLtctcv4Uq1lI3WIOr3srKOFsuBsSaLsqGC+6wSTaa6pkuBFHgwRVwij+qhT1na7fm Om+tZYsgqsqTrgcdhHiKIjSkfFX6av+yMihvL+nwgG4h3OoQDEygyHXNAAXOCMm0K1AP /azA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="JJ/qjlVz"; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id bp32-20020a05620a45a000b0077d67a9e295si9189267qkb.319.2023.12.11.13.23.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 13:23:07 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="JJ/qjlVz"; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 095F73858C5F for ; Mon, 11 Dec 2023 21:23:07 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 48C743858C5F for ; Mon, 11 Dec 2023 21:22:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 48C743858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 48C743858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702329765; cv=none; b=Heb52dsrCx2ua/M+dTuESHPaE7Sjd7gLZgRClDh1uZmrJSA+dfKMzb3w4ExMqXRQy5HNAm1Jb5W0i9hTGEBoLKR7mVAXnXtdl/3BZVR0VECEZPzUpidCiP2GmLROdFXWpieKMG7qCSZto/BpUPSmoe7JzFym3iXbPNYTn7CW1xQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702329765; c=relaxed/simple; bh=asm8xQkZDjLpag76MrI0EDFU5o3CX8hhQm/jPm9cp8Q=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=maMvvq/6/0K4PZDg//s2N9tmuQUWoLsJYpMsqlNAcY+7xtPnbgI8vvzLuTtWu7TOb6FpdAKYSf1FkRsjPHq0YdUzEPs+reKKtff2Fkq9ka5H6WLYPWAR3Lu6UYZVjy5X54CuXLs0EoDzZZtPOrw64tQWI+VgjGI0SLfOguxBDSQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702329763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5rdPQVEnN8Hac9S7q5/7kwwXBTcxZ3wWbvnNbxLhjRs=; b=JJ/qjlVz3+uVsVL+l4f749mpGV8h6jXQWEVzTvHuR74MJKQ1vehf0p+RAh5MSjX4PyiKr2 AfGpvoulr6ksTaYhtcd33JDh8/4YDdYh+Z82yuaxqgFXIkF3/HrNAzSPUVMNW1xK0UHQM1 lQz2pdC9a5JCJ9LAVSkBIUfuqFR8kpY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-150-21C3cKb8NiKo5zmwPEI9vQ-1; Mon, 11 Dec 2023 16:22:42 -0500 X-MC-Unique: 21C3cKb8NiKo5zmwPEI9vQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F3B17870825 for ; Mon, 11 Dec 2023 21:22:41 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.22.8.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB79C3C25; Mon, 11 Dec 2023 21:22:41 +0000 (UTC) From: David Malcolm To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [PATCH] analyzer: fix uninitialized bitmap [PR112955] Date: Mon, 11 Dec 2023 16:22:40 -0500 Message-Id: <20231211212240.3029438-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785022158751521410 X-GMAIL-MSGID: 1785022158751521410 In r14-5566-g841008d3966c0f I added a new ctor for feasibility_state, but failed to call bitmap_clear on m_snodes_visited. Fixed thusly. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Verified fix manually with valgrind on gcc.dg/analyzer/data-model-20.c. Pushed to trunk as r14-6434-g6008b80b25d718. gcc/analyzer/ChangeLog: PR analyzer/112955 * engine.cc (feasibility_state::feasibility_state): Initialize m_snodes_visited. --- gcc/analyzer/engine.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/analyzer/engine.cc b/gcc/analyzer/engine.cc index 1f930a21eb37..03750815939a 100644 --- a/gcc/analyzer/engine.cc +++ b/gcc/analyzer/engine.cc @@ -4870,6 +4870,7 @@ feasibility_state::feasibility_state (const region_model &model, : m_model (model), m_snodes_visited (sg.m_nodes.length ()) { + bitmap_clear (m_snodes_visited); } feasibility_state &