From patchwork Sun Dec 10 19:56:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Andrew Pinski (QUIC)" X-Patchwork-Id: 176399 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp6673565vqy; Sun, 10 Dec 2023 11:57:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdNFh0fyy5p/9dZ+3RdVCunJJjEzI6UwWZr1L1a4HdNNQM9C8MMS7zfWfTOkg+RtvtHCCK X-Received: by 2002:ac8:5a8d:0:b0:425:7f98:3867 with SMTP id c13-20020ac85a8d000000b004257f983867mr5738664qtc.112.1702238258258; Sun, 10 Dec 2023 11:57:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702238258; cv=pass; d=google.com; s=arc-20160816; b=b3+75RHzMn/UcbqWWcVq9CSsbPwIFdI/GJZgIqssOsZlFlWQjSyU9vz4OMb1AounKP emkdOiRsNBWvGTOigNSAdPrI646/TpCej7uF0hIJT9QAuFJvIl64Eg0GCJ5hD1dR9kgm DpVmZzXpshEW+Ejma2ZWk0PZftie7enmvqgPDov/hVrF/cYOHbakKlsZ4hGsh7uzLnRr /WgMaw0CTIVmdeGg9Y3skWJTprLbtP8OrG/YBbxC0qLAl/DSHqw/7FTBv2Jzwz8QW5Ij 0/9Jy4q69AGRG7gOvH03KO24Q4gjLW15s5GVajPntRBtmA2040gYqRMGflB2lJD+aiq4 eNzw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=txEAFAqEXjDPtiur+jatS4MpwGgS/t1NiGcTu9xoin8=; fh=gk9A5O7Gbglvz1MjrRQ4hZ2i3c68kYkpOZJg1emXh+g=; b=WojjTq1jrRdPOe7n2LmQ6oGe4J2u2MFIsmPK5fDA4AN6yKJ5/9Tlh2FCK6jLMftDyD nD2PSgg/ZG8Cgpuk6lVBtHpns8PJxxMsHJEiRZXNsfAnZxNOwIMQip7Y37s6vYCpLwNf tBymgmQoIVM/xJi1ISCVJ0Vka/5q1dwVq/Hgm5mpQA0FCUcQKY1FbXx+otLCFF5BPT15 jP7qJbGz42Pl1y/xKpJfm42sfAHwwl1srVQe5McNTZ9XSPAB8qqQLGjfbm89Ch7b8x6x +H678qtmlpT/ZPl+Ufy/1qYRm2TUiseiX826OyjU/laHWf3T4Ywcfh/QWTiIwcmgiIA5 g9IA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=M3nSErg3; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id z1-20020ac87ca1000000b0042377f488b3si6452852qtv.181.2023.12.10.11.57.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Dec 2023 11:57:38 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=M3nSErg3; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 71DA2385AC3A for ; Sun, 10 Dec 2023 19:57:32 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by sourceware.org (Postfix) with ESMTPS id AE7B5385829D for ; Sun, 10 Dec 2023 19:57:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE7B5385829D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AE7B5385829D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702238224; cv=none; b=hZg1F3KVRvil3wAc7k/GIOFKrqj2zxfvgg6W2qLtArV1XFvCLXujoBBc8sZiQHt3APsr5DarPCgrVNDwdg/OnY+Atmo3TPWFq07TeYiwmswofjahXF9qQyyDYHXCjoWAaPUoTAQU8+6Mrr6L1wlBDIxEuopLxdC2z5d7Hb5AOSk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702238224; c=relaxed/simple; bh=pcQjXJXxAktrUUZdMid1lR75kkj4yyjL3shlPPcTn5U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LiMCYpMsg1ZAYIo7iRZu9O14VA287I1TDk91EN3nSbaNuv2gNeZSqi1goDMrGtqeZQwm4iOTO/Xw6s4Hs9oi309clOX7tPh//VEPnieYsjDFEzEcP8DghE8V8eslM1euYlBqfHxjl65SV07m7N+U3cPv+JIfQC7qYcqVG4KLUbI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3BAJhrIp002823 for ; Sun, 10 Dec 2023 19:57:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= qcppdkim1; bh=txEAFAqEXjDPtiur+jatS4MpwGgS/t1NiGcTu9xoin8=; b=M3 nSErg3cAZwumL04e6NLuxXIQi0+goScde5esX5DFIfcAImuTbHu3oBSecG3KdmJD Ig0grhLd5sEHSoL5IWFTbQvDpwv/XabAelozrqtklg+ORf8mkRNiG0+73remhjMX fPpKgCVUlKbF8GyeKGJvU1VnPKE+09O/yis/tfj/e8/5F+wUu/0vi2HWAvHnIkUg at+/Y+EA/U0GpWg1R6w6VkldT734pLGT5IRMtIRMapR2aCfWDwxvYsCOcU0bqunV qpvUXEND5PIQT5tuCIHtOdJY9WQk+2Fbljnb8ql0PU6BoV461ouYKUz7twp4gYGl 0apDseCy3NGdntuJNwuA== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uwjyjr1x9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 10 Dec 2023 19:57:01 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3BAJv0dJ013508 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 10 Dec 2023 19:57:00 GMT Received: from hu-apinski-lv.qualcomm.com (10.49.16.6) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Sun, 10 Dec 2023 11:57:00 -0800 From: Andrew Pinski To: Subject: [PATCH 1/2] analyzer: Remove check of unsigned_char in maybe_undo_optimize_bit_field_compare. Date: Sun, 10 Dec 2023 11:56:49 -0800 Message-ID: <20231210195650.1772459-2-quic_apinski@quicinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231210195650.1772459-1-quic_apinski@quicinc.com> References: <20231210195650.1772459-1-quic_apinski@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 72YBhQWuhdCi5vxSLZEDaryAf4vR7lAE X-Proofpoint-ORIG-GUID: 72YBhQWuhdCi5vxSLZEDaryAf4vR7lAE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 mlxlogscore=715 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2312100175 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784926184111907104 X-GMAIL-MSGID: 1784926184111907104 From: Andrew Pinski The check for the type seems unnecessary and gets in the way sometimes. Also with a patch I am working on for match.pd, it causes a failure to happen. Before my patch the IR was: _1 = BIT_FIELD_REF ; _2 = _1 & 1; _3 = _2 != 0; _4 = (int) _3; __analyzer_eval (_4); Where _2 was an unsigned char type. And After my patch we have: _1 = BIT_FIELD_REF ; _2 = (int) _1; _3 = _2 & 1; __analyzer_eval (_3); But in this case, the BIT_AND_EXPR is in an int type. OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. gcc/analyzer/ChangeLog: * region-model-manager.cc (maybe_undo_optimize_bit_field_compare): Remove the check for type being unsigned_char_type_node. --- gcc/analyzer/region-model-manager.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/gcc/analyzer/region-model-manager.cc b/gcc/analyzer/region-model-manager.cc index b631bcb04d0..26c34e38875 100644 --- a/gcc/analyzer/region-model-manager.cc +++ b/gcc/analyzer/region-model-manager.cc @@ -596,9 +596,6 @@ maybe_undo_optimize_bit_field_compare (tree type, tree cst, const svalue *arg1) { - if (type != unsigned_char_type_node) - return NULL; - const binding_map &map = compound_sval->get_map (); unsigned HOST_WIDE_INT mask = TREE_INT_CST_LOW (cst); /* If "mask" is a contiguous range of set bits, see if the