diff mbox series

testsuite: require avx_runtime for vect-simd-clone-17f

Message ID 20231207162817.686879-1-poulhies@adacore.com
State Accepted
Headers
Series testsuite: require avx_runtime for vect-simd-clone-17f |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Marc Poulhiès Dec. 7, 2023, 4:28 p.m. UTC 
  The test fails parsing the 'vect' dump when not using -mavx. Make the
dependency explicit.

gcc/testsuite/ChangeLog:

	* gcc.dg/vect/vect-simd-clone-17f.c: Add dep on avx_runtime.
---
Tested on x86_64-linux and x86_64-elf.

Ok for master?

 gcc/testsuite/gcc.dg/vect/vect-simd-clone-17f.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jakub Jelinek Dec. 7, 2023, 4:41 p.m. UTC | #1 
On Thu, Dec 07, 2023 at 05:28:09PM +0100, Marc Poulhiès wrote:
> The test fails parsing the 'vect' dump when not using -mavx. Make the
> dependency explicit.
> 
> gcc/testsuite/ChangeLog:
> 
> 	* gcc.dg/vect/vect-simd-clone-17f.c: Add dep on avx_runtime.
> ---
> Tested on x86_64-linux and x86_64-elf.
> 
> Ok for master?
> 
>  gcc/testsuite/gcc.dg/vect/vect-simd-clone-17f.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-17f.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-17f.c
> index 177521dc445..eb2b149981f 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-17f.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-17f.c
> @@ -1,6 +1,7 @@
>  /* { dg-require-effective-target vect_simd_clones } */
> +/* { dg-require-effective-target avx_runtime } */
>  /* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0" } */
> -/* { dg-additional-options "-mavx" { target avx_runtime } } */
> +/* { dg-additional-options "-mavx" } */
>  /* { dg-additional-options "-mno-avx512f" { target { { i?86*-*-* x86_64-*-* } && { ! lp64 } } } } */
>  
>  #define TYPE __INT64_TYPE__

This looks wrong, then it won't be tested at all on non-x86 targets.

	Jakub
Marc Poulhiès Dec. 8, 2023, 8:54 a.m. UTC | #2 
Jakub Jelinek <jakub@redhat.com> writes:

> This looks wrong, then it won't be tested at all on non-x86 targets.

Right, I'll look for a better fix.

Should I revert r14-6272 that has the same issue of disabling the
modified tests on non-x86?

Marc
Marc Poulhiès Dec. 8, 2023, 9:17 a.m. UTC | #3 
Marc Poulhiès <poulhies@adacore.com> writes:

> Should I revert r14-6272 that has the same issue of disabling the
> modified tests on non-x86?

I've reverted the r14-6272.

Marc
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-17f.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-17f.c
index 177521dc445..eb2b149981f 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-17f.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-17f.c
@@ -1,6 +1,7 @@ 
 /* { dg-require-effective-target vect_simd_clones } */
+/* { dg-require-effective-target avx_runtime } */
 /* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0" } */
-/* { dg-additional-options "-mavx" { target avx_runtime } } */
+/* { dg-additional-options "-mavx" } */
 /* { dg-additional-options "-mno-avx512f" { target { { i?86*-*-* x86_64-*-* } && { ! lp64 } } } } */
 
 #define TYPE __INT64_TYPE__