From patchwork Thu Dec 7 05:33:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ken Matsui X-Patchwork-Id: 174938 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp4575630vqy; Wed, 6 Dec 2023 21:51:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IF4hN6FCjSW1BqV2hPn9HqcbPykpppuWa3VNjnqlQKYSUJo8uUIMDMCzXwXF6GbunbKRHyE X-Received: by 2002:a05:6122:a22:b0:4b2:e003:e16 with SMTP id 34-20020a0561220a2200b004b2e0030e16mr2388158vkn.3.1701928299318; Wed, 06 Dec 2023 21:51:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1701928299; cv=pass; d=google.com; s=arc-20160816; b=kQYZH0jNrUwV/ohkcoKXh4PCumA5TqjbKODeTQeXma5Bo01VbsGf1u8oOJ452JSO1o ++BoByZl/m8dCQ/IsU0VXQQU81yKi9Hc0VLGDOq4YAo2206ThtMqlSsOCpRZgqbS60dq XzQqfncAO/YAmrSpb/1MrjaHN1yP61Yno6VNEjxBfRgG5V5y5KsYENLU8S6IlxIll/+c ZUj5gARa+K+zIF6omiph2Hj1jmc1Vyf41pNjckFEFKhYFFzMAALp4DJaN3H2NjFiUimp iPWnLIx0D/G+EDpVlNy28PsG4BvhcQ813j/286HWE+mjaOCW6oFupDDFKaXm4cOx63YI HV3g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=29+2ieOd1DYGTwo3gbrtvyhW2O5XLFUWh+QvxkCzSgU=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=LToxrLMypGC/oxNE81n6YaBrjhpTgKTDxX2VD2ah8cr4bJEY/OvIcbCwomEDAbmzLt ssZ68RCjPNk2FHnnHORAGOyVoQdxg+lK9g78FdR2KanYEnUQY8P+h1Zl4hBQdEjUjsvk 6AqyqYPsk9QdhGVxYFoVxDEFJ4bzMPNGeID39pl0mbW789F7gQQ09wy36zqvae9ghoh9 vaSLsc0737dAIlssziq8E4JpP9EM5ngxXB64E0klDA2Z20CN0fxPPil0f1F/nQNipmql t0/5kewQBDrzVo/1ELyv9oiQ6itPTm29EVxERX+N9Sq2Mdze2N0l0jwmsy8NedU6Fv2K YtcA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=tm8YuByO; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id z8-20020a0ce988000000b0067ab630e73bsi573007qvn.478.2023.12.06.21.51.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 21:51:39 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=tm8YuByO; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 114AB3857340 for ; Thu, 7 Dec 2023 05:51:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 114AB3857340 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1701928299; bh=29+2ieOd1DYGTwo3gbrtvyhW2O5XLFUWh+QvxkCzSgU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tm8YuByOOyML4/wFFe8msZPSNag5dNyae40gar3HEvydeuISDjGighArRksCkvUVP PAAwnsLyEPDhjuLSKrqZL33ciW7OM0TkysBWQGAG//3NNwX1Fm74KkPc9z8IwskkVc DK6Oz4iy74LYYkM4gpxDRvyrkAfH2Qvd5dit8Iho= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-00641c01.pphosted.com (mx0a-00641c01.pphosted.com [205.220.165.146]) by sourceware.org (Postfix) with ESMTPS id 382F6385800D; Thu, 7 Dec 2023 05:50:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 382F6385800D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 382F6385800D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.165.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701928255; cv=none; b=Kr4aXH1wiZll8BOQKX8jFif9LHoDlcRca32p2uwiNoNFlfbOkKRv+sHSKpKRJNd2r8oNmtXVPI0ukQWJ1Hyy9CSR3OnJNDjYU9x0gL4XeaJ9Rx8DnkP7h4/+QDd5JUR/pHSACyZQ1qftrpu8B9cT9/36229gG+va2R/PCVx6s0U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701928255; c=relaxed/simple; bh=EM46pzAHnAaWoa37zj3SssDfcMqNmVcDSq9ayNXTZ7E=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=YpeusMqxJ6c7vAKY10rxTk0QOHmAuhWjUrT/xobZXd5+Ezm9QXwIyXByWyfa5L4NeAqFeVq022AQdFFvP4VouCFKKa/utWzdHEDepY16qVWhPTXrKbrUwM5d6TD/4BxZifrCD1BMzsYWR0PWUUWEeBclWUPo5/+dmXMOMAJw/ZE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247470.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B75k2jQ024280; Thu, 7 Dec 2023 05:50:53 GMT Received: from mxout23.cac.washington.edu (mxout23.cac.washington.edu [140.142.32.140]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3uu035v0ek-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Dec 2023 05:50:53 +0000 Received: from smtp.washington.edu (smtp.washington.edu [128.208.60.54]) by mxout23.cac.washington.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 3B75oNcs000636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 6 Dec 2023 21:50:23 -0800 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.154.75.142]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 3B75adQG020981 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 6 Dec 2023 21:50:23 -0800 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui Subject: [PATCH v26 15/23] libstdc++: Optimize std::is_member_object_pointer compilation performance Date: Wed, 6 Dec 2023 21:33:10 -0800 Message-ID: <20231207053633.1001720-16-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207053633.1001720-1-kmatsui@gcc.gnu.org> References: <20231024020424.699427-1-kmatsui@gcc.gnu.org> <20231207053633.1001720-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 X-Proofpoint-GUID: vLgVSBDegzCwMs1Qeih68X6bJMVDyo14 X-Proofpoint-ORIG-GUID: vLgVSBDegzCwMs1Qeih68X6bJMVDyo14 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-06_20,2023-12-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 spamscore=0 priorityscore=1501 clxscore=1034 mlxscore=0 suspectscore=0 impostorscore=0 mlxlogscore=503 lowpriorityscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312060159 X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780601035717656705 X-GMAIL-MSGID: 1784601168410848583 This patch optimizes the compilation performance of std::is_member_object_pointer by dispatching to the new __is_member_object_pointer built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (is_member_object_pointer): Use __is_member_object_pointer built-in trait. (is_member_object_pointer_v): Likewise. Signed-off-by: Ken Matsui --- libstdc++-v3/include/std/type_traits | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 99ae825301c..1edd05acb4c 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -574,6 +574,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION struct is_rvalue_reference<_Tp&&> : public true_type { }; + /// is_member_object_pointer +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_member_object_pointer) + template + struct is_member_object_pointer + : public __bool_constant<__is_member_object_pointer(_Tp)> + { }; +#else template struct __is_member_object_pointer_helper : public false_type { }; @@ -582,11 +589,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION struct __is_member_object_pointer_helper<_Tp _Cp::*> : public __not_>::type { }; - /// is_member_object_pointer + template struct is_member_object_pointer : public __is_member_object_pointer_helper<__remove_cv_t<_Tp>>::type { }; +#endif #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_member_function_pointer) /// is_member_function_pointer @@ -3213,9 +3221,16 @@ template inline constexpr bool is_rvalue_reference_v = false; template inline constexpr bool is_rvalue_reference_v<_Tp&&> = true; + +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_member_object_pointer) +template + inline constexpr bool is_member_object_pointer_v = + __is_member_object_pointer(_Tp); +#else template inline constexpr bool is_member_object_pointer_v = is_member_object_pointer<_Tp>::value; +#endif #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_member_function_pointer) template