diff mbox series

[5/6] arm: [MVE intrinsics] fix vst1 tests

Message ID 20231116152617.2193377-5-christophe.lyon@linaro.org
State Unresolved
Headers
Series [1/6] arm: Fix arm_simd_types and MVE scalar_types |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

Christophe Lyon Nov. 16, 2023, 3:26 p.m. UTC 
  vst1q intrinsics return void, so we should not do 'return vst1q_f16 (base, value);'

This was OK so far, but will trigger an error/warning with the new
implementation of these intrinsics.

This patch just removes the 'return' keyword.

2023-11-16  Christophe Lyon  <christophe.lyon@linaro.org>

	gcc/testsuite/
	* gcc.target/arm/mve/intrinsics/vst1q_f16.c: Remove 'return'.
	* gcc.target/arm/mve/intrinsics/vst1q_f32.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vst1q_s16.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vst1q_s32.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vst1q_s8.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vst1q_u16.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vst1q_u32.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vst1q_u8.c: Likewise.
---
 gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f16.c | 4 ++--
 gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f32.c | 4 ++--
 gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s16.c | 4 ++--
 gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s32.c | 4 ++--
 gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s8.c  | 4 ++--
 gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u16.c | 4 ++--
 gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u32.c | 4 ++--
 gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u8.c  | 4 ++--
 8 files changed, 16 insertions(+), 16 deletions(-)

Comments

Christophe Lyon Nov. 16, 2023, 3:37 p.m. UTC | #1 
On Thu, 16 Nov 2023 at 16:30, Kyrylo Tkachov <Kyrylo.Tkachov@arm.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Christophe Lyon <christophe.lyon@linaro.org>
> > Sent: Thursday, November 16, 2023 3:26 PM
> > To: gcc-patches@gcc.gnu.org; Richard Sandiford
> > <Richard.Sandiford@arm.com>; Richard Earnshaw
> > <Richard.Earnshaw@arm.com>; Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
> > Cc: Christophe Lyon <christophe.lyon@linaro.org>
> > Subject: [PATCH 5/6] arm: [MVE intrinsics] fix vst1 tests
> >
> > vst1q intrinsics return void, so we should not do 'return vst1q_f16 (base,
> > value);'
> >
> > This was OK so far, but will trigger an error/warning with the new
> > implementation of these intrinsics.
> >
>
> Whoops!
> Ok (could have gone in as obvious IMO).

Indeed, I'll try to remember that when I write the same patch for the
other vst* intrinsics tests ;-)

Thanks,

Christophe

> Thanks,
> Kyrill
>
> > This patch just removes the 'return' keyword.
> >
> > 2023-11-16  Christophe Lyon  <christophe.lyon@linaro.org>
> >
> >       gcc/testsuite/
> >       * gcc.target/arm/mve/intrinsics/vst1q_f16.c: Remove 'return'.
> >       * gcc.target/arm/mve/intrinsics/vst1q_f32.c: Likewise.
> >       * gcc.target/arm/mve/intrinsics/vst1q_s16.c: Likewise.
> >       * gcc.target/arm/mve/intrinsics/vst1q_s32.c: Likewise.
> >       * gcc.target/arm/mve/intrinsics/vst1q_s8.c: Likewise.
> >       * gcc.target/arm/mve/intrinsics/vst1q_u16.c: Likewise.
> >       * gcc.target/arm/mve/intrinsics/vst1q_u32.c: Likewise.
> >       * gcc.target/arm/mve/intrinsics/vst1q_u8.c: Likewise.
> > ---
> >  gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f16.c | 4 ++--
> >  gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f32.c | 4 ++--
> >  gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s16.c | 4 ++--
> >  gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s32.c | 4 ++--
> >  gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s8.c  | 4 ++--
> >  gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u16.c | 4 ++--
> >  gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u32.c | 4 ++--
> >  gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u8.c  | 4 ++--
> >  8 files changed, 16 insertions(+), 16 deletions(-)
> >
> > diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f16.c
> > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f16.c
> > index 1fa02f00f53..e4b40604d54 100644
> > --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f16.c
> > +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f16.c
> > @@ -18,7 +18,7 @@ extern "C" {
> >  void
> >  foo (float16_t *base, float16x8_t value)
> >  {
> > -  return vst1q_f16 (base, value);
> > +  vst1q_f16 (base, value);
> >  }
> >
> >
> > @@ -31,7 +31,7 @@ foo (float16_t *base, float16x8_t value)
> >  void
> >  foo1 (float16_t *base, float16x8_t value)
> >  {
> > -  return vst1q (base, value);
> > +  vst1q (base, value);
> >  }
> >
> >  #ifdef __cplusplus
> > diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f32.c
> > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f32.c
> > index 67cc3ae3b47..8f42323c603 100644
> > --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f32.c
> > +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f32.c
> > @@ -18,7 +18,7 @@ extern "C" {
> >  void
> >  foo (float32_t *base, float32x4_t value)
> >  {
> > -  return vst1q_f32 (base, value);
> > +  vst1q_f32 (base, value);
> >  }
> >
> >
> > @@ -31,7 +31,7 @@ foo (float32_t *base, float32x4_t value)
> >  void
> >  foo1 (float32_t *base, float32x4_t value)
> >  {
> > -  return vst1q (base, value);
> > +  vst1q (base, value);
> >  }
> >
> >  #ifdef __cplusplus
> > diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s16.c
> > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s16.c
> > index 052959b2083..891ac4155d9 100644
> > --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s16.c
> > +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s16.c
> > @@ -18,7 +18,7 @@ extern "C" {
> >  void
> >  foo (int16_t *base, int16x8_t value)
> >  {
> > -  return vst1q_s16 (base, value);
> > +  vst1q_s16 (base, value);
> >  }
> >
> >
> > @@ -31,7 +31,7 @@ foo (int16_t *base, int16x8_t value)
> >  void
> >  foo1 (int16_t *base, int16x8_t value)
> >  {
> > -  return vst1q (base, value);
> > +  vst1q (base, value);
> >  }
> >
> >  #ifdef __cplusplus
> > diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s32.c
> > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s32.c
> > index 444ad07f4ef..a28d1eb98db 100644
> > --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s32.c
> > +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s32.c
> > @@ -18,7 +18,7 @@ extern "C" {
> >  void
> >  foo (int32_t *base, int32x4_t value)
> >  {
> > -  return vst1q_s32 (base, value);
> > +  vst1q_s32 (base, value);
> >  }
> >
> >
> > @@ -31,7 +31,7 @@ foo (int32_t *base, int32x4_t value)
> >  void
> >  foo1 (int32_t *base, int32x4_t value)
> >  {
> > -  return vst1q (base, value);
> > +  vst1q (base, value);
> >  }
> >
> >  #ifdef __cplusplus
> > diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s8.c
> > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s8.c
> > index 684ff0aca5b..81c141a63e0 100644
> > --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s8.c
> > +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s8.c
> > @@ -18,7 +18,7 @@ extern "C" {
> >  void
> >  foo (int8_t *base, int8x16_t value)
> >  {
> > -  return vst1q_s8 (base, value);
> > +  vst1q_s8 (base, value);
> >  }
> >
> >
> > @@ -31,7 +31,7 @@ foo (int8_t *base, int8x16_t value)
> >  void
> >  foo1 (int8_t *base, int8x16_t value)
> >  {
> > -  return vst1q (base, value);
> > +  vst1q (base, value);
> >  }
> >
> >  #ifdef __cplusplus
> > diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u16.c
> > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u16.c
> > index 1fea2de1e76..b8ce7fbe6ee 100644
> > --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u16.c
> > +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u16.c
> > @@ -18,7 +18,7 @@ extern "C" {
> >  void
> >  foo (uint16_t *base, uint16x8_t value)
> >  {
> > -  return vst1q_u16 (base, value);
> > +  vst1q_u16 (base, value);
> >  }
> >
> >
> > @@ -31,7 +31,7 @@ foo (uint16_t *base, uint16x8_t value)
> >  void
> >  foo1 (uint16_t *base, uint16x8_t value)
> >  {
> > -  return vst1q (base, value);
> > +  vst1q (base, value);
> >  }
> >
> >  #ifdef __cplusplus
> > diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u32.c
> > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u32.c
> > index 64c43c59d47..1dbb55538a9 100644
> > --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u32.c
> > +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u32.c
> > @@ -18,7 +18,7 @@ extern "C" {
> >  void
> >  foo (uint32_t *base, uint32x4_t value)
> >  {
> > -  return vst1q_u32 (base, value);
> > +  vst1q_u32 (base, value);
> >  }
> >
> >
> > @@ -31,7 +31,7 @@ foo (uint32_t *base, uint32x4_t value)
> >  void
> >  foo1 (uint32_t *base, uint32x4_t value)
> >  {
> > -  return vst1q (base, value);
> > +  vst1q (base, value);
> >  }
> >
> >  #ifdef __cplusplus
> > diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u8.c
> > b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u8.c
> > index 5517611bba6..ab22be81647 100644
> > --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u8.c
> > +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u8.c
> > @@ -18,7 +18,7 @@ extern "C" {
> >  void
> >  foo (uint8_t *base, uint8x16_t value)
> >  {
> > -  return vst1q_u8 (base, value);
> > +  vst1q_u8 (base, value);
> >  }
> >
> >
> > @@ -31,7 +31,7 @@ foo (uint8_t *base, uint8x16_t value)
> >  void
> >  foo1 (uint8_t *base, uint8x16_t value)
> >  {
> > -  return vst1q (base, value);
> > +  vst1q (base, value);
> >  }
> >
> >  #ifdef __cplusplus
> > --
> > 2.34.1
>
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f16.c b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f16.c
index 1fa02f00f53..e4b40604d54 100644
--- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f16.c
+++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f16.c
@@ -18,7 +18,7 @@  extern "C" {
 void
 foo (float16_t *base, float16x8_t value)
 {
-  return vst1q_f16 (base, value);
+  vst1q_f16 (base, value);
 }
 
 
@@ -31,7 +31,7 @@  foo (float16_t *base, float16x8_t value)
 void
 foo1 (float16_t *base, float16x8_t value)
 {
-  return vst1q (base, value);
+  vst1q (base, value);
 }
 
 #ifdef __cplusplus
diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f32.c b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f32.c
index 67cc3ae3b47..8f42323c603 100644
--- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f32.c
+++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_f32.c
@@ -18,7 +18,7 @@  extern "C" {
 void
 foo (float32_t *base, float32x4_t value)
 {
-  return vst1q_f32 (base, value);
+  vst1q_f32 (base, value);
 }
 
 
@@ -31,7 +31,7 @@  foo (float32_t *base, float32x4_t value)
 void
 foo1 (float32_t *base, float32x4_t value)
 {
-  return vst1q (base, value);
+  vst1q (base, value);
 }
 
 #ifdef __cplusplus
diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s16.c b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s16.c
index 052959b2083..891ac4155d9 100644
--- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s16.c
+++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s16.c
@@ -18,7 +18,7 @@  extern "C" {
 void
 foo (int16_t *base, int16x8_t value)
 {
-  return vst1q_s16 (base, value);
+  vst1q_s16 (base, value);
 }
 
 
@@ -31,7 +31,7 @@  foo (int16_t *base, int16x8_t value)
 void
 foo1 (int16_t *base, int16x8_t value)
 {
-  return vst1q (base, value);
+  vst1q (base, value);
 }
 
 #ifdef __cplusplus
diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s32.c b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s32.c
index 444ad07f4ef..a28d1eb98db 100644
--- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s32.c
+++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s32.c
@@ -18,7 +18,7 @@  extern "C" {
 void
 foo (int32_t *base, int32x4_t value)
 {
-  return vst1q_s32 (base, value);
+  vst1q_s32 (base, value);
 }
 
 
@@ -31,7 +31,7 @@  foo (int32_t *base, int32x4_t value)
 void
 foo1 (int32_t *base, int32x4_t value)
 {
-  return vst1q (base, value);
+  vst1q (base, value);
 }
 
 #ifdef __cplusplus
diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s8.c b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s8.c
index 684ff0aca5b..81c141a63e0 100644
--- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s8.c
+++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_s8.c
@@ -18,7 +18,7 @@  extern "C" {
 void
 foo (int8_t *base, int8x16_t value)
 {
-  return vst1q_s8 (base, value);
+  vst1q_s8 (base, value);
 }
 
 
@@ -31,7 +31,7 @@  foo (int8_t *base, int8x16_t value)
 void
 foo1 (int8_t *base, int8x16_t value)
 {
-  return vst1q (base, value);
+  vst1q (base, value);
 }
 
 #ifdef __cplusplus
diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u16.c b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u16.c
index 1fea2de1e76..b8ce7fbe6ee 100644
--- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u16.c
+++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u16.c
@@ -18,7 +18,7 @@  extern "C" {
 void
 foo (uint16_t *base, uint16x8_t value)
 {
-  return vst1q_u16 (base, value);
+  vst1q_u16 (base, value);
 }
 
 
@@ -31,7 +31,7 @@  foo (uint16_t *base, uint16x8_t value)
 void
 foo1 (uint16_t *base, uint16x8_t value)
 {
-  return vst1q (base, value);
+  vst1q (base, value);
 }
 
 #ifdef __cplusplus
diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u32.c b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u32.c
index 64c43c59d47..1dbb55538a9 100644
--- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u32.c
+++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u32.c
@@ -18,7 +18,7 @@  extern "C" {
 void
 foo (uint32_t *base, uint32x4_t value)
 {
-  return vst1q_u32 (base, value);
+  vst1q_u32 (base, value);
 }
 
 
@@ -31,7 +31,7 @@  foo (uint32_t *base, uint32x4_t value)
 void
 foo1 (uint32_t *base, uint32x4_t value)
 {
-  return vst1q (base, value);
+  vst1q (base, value);
 }
 
 #ifdef __cplusplus
diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u8.c b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u8.c
index 5517611bba6..ab22be81647 100644
--- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u8.c
+++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/vst1q_u8.c
@@ -18,7 +18,7 @@  extern "C" {
 void
 foo (uint8_t *base, uint8x16_t value)
 {
-  return vst1q_u8 (base, value);
+  vst1q_u8 (base, value);
 }
 
 
@@ -31,7 +31,7 @@  foo (uint8_t *base, uint8x16_t value)
 void
 foo1 (uint8_t *base, uint8x16_t value)
 {
-  return vst1q (base, value);
+  vst1q (base, value);
 }
 
 #ifdef __cplusplus