From patchwork Thu Nov 9 11:36:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 163358 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp370538vqs; Thu, 9 Nov 2023 03:36:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IGTwNosKCj/GOwayb5wXX4oAA9u3tap0zD7M5qGaY4NOqtJXlD7xOdtZxDrUz49o+5Jw0+b X-Received: by 2002:ac8:7dc1:0:b0:419:4d8a:336 with SMTP id c1-20020ac87dc1000000b004194d8a0336mr5163799qte.60.1699529811171; Thu, 09 Nov 2023 03:36:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1699529811; cv=pass; d=google.com; s=arc-20160816; b=ZZKeSmAybwljc97Acad5DaJ+70mYGtyc2JDIesV/gpY2pqwZ2wSEfxoKFRk6Afagxb pgzCbcJjVzzNzE41qcVi1XS/4IcY7872YXryjF5Ij89vBGUv0i9uhr4MytkCzxaXtWIT vu6iQRJ50GS7RRcpaXNIXWN1b7PfTR8Vfesh2KlTnhqAy9hUd2AK4T4gzvYBMKvaISx2 +HpEGcf8HRJYgOPfHS+aYQH6emM4kZ/41koM5ie2zB/spRJr0Bsew86B4bZUQ11cgtFi HthlTH67ltSnPpakdMdPFd69V+eRDncFLAetBv1Y1wTjHQg6ITlyLOl77TW6qbGy5P3S z96g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:errors-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :user-agent:subject:to:from:date:dkim-signature:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=nDl9nGkVyu70kseMfNaqiI6govg/Cbi4cEXAwn+uOW8=; fh=hPrbWPhweUx4V0GV9uXJqbyAzg2ABmTz7kczrAQqMmM=; b=YqsM6kc8z7GAh9DDAcad3q4/YXcPKaUnovaNHebR3aOYVN8pXwitSScK06ZuyY+yN5 FJVjyz5C8chmDKxytiODovzWRyWsAzsx1eD4Oye933HBamf/adoMaWYkKLBiTdGBKfXO 7eWZu1FUEYROr6USaycOjFOirS4GzGLWZ9s4CmSiDKXN8n3U/RjdHuA0GI+WDQ64a1lo /Q8tOvykZUi+giBA2uyCZhqvaDjbqiFLlwuwikB8K2V/XCWbujDD3+lLQLCXcRa1BvPP TOMfkuTXXoUovQEGVEKX4lz9pqg9aDIu1DvyRXo34kKv0pNQOc8nhZkcTxjvSLofupcG orOA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=kUrR7av2; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id c6-20020ac87dc6000000b0041812c417ebsi2775822qte.750.2023.11.09.03.36.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 03:36:51 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=kUrR7av2; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EB1D63858296 for ; Thu, 9 Nov 2023 11:36:50 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 588F83858035 for ; Thu, 9 Nov 2023 11:36:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 588F83858035 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 588F83858035 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.220.29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699529787; cv=none; b=kKQYOD72KIDOknrX4qI7onLG/iJR7XHd2MdMOA/TBSkhe7znB6uc1A63VjEI0wmsKKqX4/6AobSNRNJQktvjBZsgGfc6Ql7qft90ZLBj/swGlw8nZh6radqcPbT+ndxGtAvTO4wA92G2f3X60ZP2/HqJDsee7llxeJI4Frjx7GE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699529787; c=relaxed/simple; bh=Pio8gBQXOm5tdYU4TQZB42n9gFSkQYnF/REQ9yoixUY=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:MIME-Version; b=mi+m9YHvC7mMlZIB6h3X9WqUU5CARbi9FS4rqKOtKyZuwvD1jLDRZeXMZtcU9vrme4SnV7ukCMtJFJuFGa7ltHgqIFY8DVxOpYC+m3VM2WMqeJAD/0TNC8rjqnae7Npex/in4dOAyLnCoExw0ogFXzsCrrSEhcqR09qkCTBj5dI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 7C46F1F8AB for ; Thu, 9 Nov 2023 11:36:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1699529784; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=nDl9nGkVyu70kseMfNaqiI6govg/Cbi4cEXAwn+uOW8=; b=kUrR7av2J7dNtj3kgnMI5ex3Z90FCTGNCN3A6ts/mbZJBk9jLuVrvwe6YMEdU1s880+ftC wK8nOx+/k6BdV4f5dkz7PVgSQLqIDFnxvDjlw4rKl+cXqqBsY8xaQmQ/B+SlDMYibakz0e utC4tNDL/v/ER4j/BeoGJruVEl2xRkg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1699529784; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=nDl9nGkVyu70kseMfNaqiI6govg/Cbi4cEXAwn+uOW8=; b=piNRjo4QUnuwQv5hZ1wHHvo9BOzCQPKU0zHx9Co/DzBwhIOmWt8u+hxSuGGq3idvcOmFkX 0wg0JCiySFXTgxCg== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 515D12C608 for ; Thu, 9 Nov 2023 11:36:24 +0000 (UTC) Date: Thu, 9 Nov 2023 11:36:24 +0000 (UTC) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/112450 - avoid AVX512 style masking for BImode masks User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Message-Id: <20231109113650.EB1D63858296@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782086171460817492 X-GMAIL-MSGID: 1782086171460817492 The following avoids running into the AVX512 style masking code for RVV which would theoretically be able to handle it if I were not relying on integer mode maskness in vect_get_loop_mask. While that's easy to fix (patch in PR), the preference is to not have AVX512 style masking for RVV, thus the following. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. * tree-vect-loop.cc (vect_verify_full_masking_avx512): Check we have integer mode masks as required by vect_get_loop_mask. --- gcc/tree-vect-loop.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc index a544bc9b059..8abc1937d74 100644 --- a/gcc/tree-vect-loop.cc +++ b/gcc/tree-vect-loop.cc @@ -1462,7 +1462,10 @@ vect_verify_full_masking_avx512 (loop_vec_info loop_vinfo) if (!mask_type) continue; - if (TYPE_PRECISION (TREE_TYPE (mask_type)) != 1) + /* For now vect_get_loop_mask only supports integer mode masks + when we need to split it. */ + if (GET_MODE_CLASS (TYPE_MODE (mask_type)) != MODE_INT + || TYPE_PRECISION (TREE_TYPE (mask_type)) != 1) { ok = false; break;