diff mbox series

rs6000, testcase: Add require-effective-target has_arch_ppc64 to pr106550_1.c

Message ID 20231106072004.3002543-1-guojiufu@linux.ibm.com
State Accepted
Headers
Series rs6000, testcase: Add require-effective-target has_arch_ppc64 to pr106550_1.c |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Jiufu Guo Nov. 6, 2023, 7:20 a.m. UTC 
  Hi,

With latest trunk, case pr106550_1.c can run with failure on ppc under -m32.
While, the case is testing 64bit constant building. So, "has_arch_ppc64"
is required.

Test pass on ppc64{,le}.

BR,
Jeff (Jiufu Guo)

gcc/testsuite/ChangeLog:

	* gcc.target/powerpc/pr106550_1.c: Add has_arch_ppc64 target require.

---
 gcc/testsuite/gcc.target/powerpc/pr106550_1.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kewen.Lin Nov. 7, 2023, 2:27 a.m. UTC | #1 
Hi,

on 2023/11/6 15:20, Jiufu Guo wrote:
> Hi,
> 
> With latest trunk, case pr106550_1.c can run with failure on ppc under -m32.
> While, the case is testing 64bit constant building. So, "has_arch_ppc64"
> is required.

Please also mention that it failed with ICE initially due to PR111971, now
that PR got fixed so this omission is exposed.

> 
> Test pass on ppc64{,le}.
> 
> BR,
> Jeff (Jiufu Guo)
> 
> gcc/testsuite/ChangeLog:
> 

There is PR112340, need a corresponding PR marker line.

OK for trunk with these nits tweaked, thanks!

BR,
Kewen

> 	* gcc.target/powerpc/pr106550_1.c: Add has_arch_ppc64 target require.
> 
> ---
>  gcc/testsuite/gcc.target/powerpc/pr106550_1.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gcc/testsuite/gcc.target/powerpc/pr106550_1.c b/gcc/testsuite/gcc.target/powerpc/pr106550_1.c
> index 7e709fcf9d8..5ab40d71a56 100644
> --- a/gcc/testsuite/gcc.target/powerpc/pr106550_1.c
> +++ b/gcc/testsuite/gcc.target/powerpc/pr106550_1.c
> @@ -1,5 +1,6 @@
>  /* PR target/106550 */
>  /* { dg-require-effective-target power10_ok } */
> +/* { dg-require-effective-target has_arch_ppc64 } */
>  /* { dg-options "-O2 -mdejagnu-cpu=power10 -fdisable-rtl-split1" } */
>  /* force the constant splitter run after RA: -fdisable-rtl-split1.  */
>
Jiufu Guo Nov. 7, 2023, 9:36 a.m. UTC | #2 
Hi,

"Kewen.Lin" <linkw@linux.ibm.com> writes:

> Hi,
>
> on 2023/11/6 15:20, Jiufu Guo wrote:
>> Hi,
>> 
>> With latest trunk, case pr106550_1.c can run with failure on ppc under -m32.
>> While, the case is testing 64bit constant building. So, "has_arch_ppc64"
>> is required.
>
> Please also mention that it failed with ICE initially due to PR111971, now
> that PR got fixed so this omission is exposed.
Thanks!
>
>> 
>> Test pass on ppc64{,le}.
>> 
>> BR,
>> Jeff (Jiufu Guo)
>> 
>> gcc/testsuite/ChangeLog:
>> 
>
> There is PR112340, need a corresponding PR marker line.
Yeap! Thanks for pointing out this!

>
> OK for trunk with these nits tweaked, thanks!

Committed via r14-5184.

BR,
Jeff (Jiufu Guo)

>
> BR,
> Kewen
>
>> 	* gcc.target/powerpc/pr106550_1.c: Add has_arch_ppc64 target require.
>> 
>> ---
>>  gcc/testsuite/gcc.target/powerpc/pr106550_1.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/gcc/testsuite/gcc.target/powerpc/pr106550_1.c b/gcc/testsuite/gcc.target/powerpc/pr106550_1.c
>> index 7e709fcf9d8..5ab40d71a56 100644
>> --- a/gcc/testsuite/gcc.target/powerpc/pr106550_1.c
>> +++ b/gcc/testsuite/gcc.target/powerpc/pr106550_1.c
>> @@ -1,5 +1,6 @@
>>  /* PR target/106550 */
>>  /* { dg-require-effective-target power10_ok } */
>> +/* { dg-require-effective-target has_arch_ppc64 } */
>>  /* { dg-options "-O2 -mdejagnu-cpu=power10 -fdisable-rtl-split1" } */
>>  /* force the constant splitter run after RA: -fdisable-rtl-split1.  */
>>
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/powerpc/pr106550_1.c b/gcc/testsuite/gcc.target/powerpc/pr106550_1.c
index 7e709fcf9d8..5ab40d71a56 100644
--- a/gcc/testsuite/gcc.target/powerpc/pr106550_1.c
+++ b/gcc/testsuite/gcc.target/powerpc/pr106550_1.c
@@ -1,5 +1,6 @@ 
 /* PR target/106550 */
 /* { dg-require-effective-target power10_ok } */
+/* { dg-require-effective-target has_arch_ppc64 } */
 /* { dg-options "-O2 -mdejagnu-cpu=power10 -fdisable-rtl-split1" } */
 /* force the constant splitter run after RA: -fdisable-rtl-split1.  */