From patchwork Fri Oct 20 06:54:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: liuhongt X-Patchwork-Id: 155849 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2010:b0:403:3b70:6f57 with SMTP id fe16csp870094vqb; Thu, 19 Oct 2023 23:54:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGR/V7bfvYqMehwPL6d9dRhXXZmI1J0UfomGTvm50an+++M3J/VPZ1UhyV6iGvRHJ2PF8np X-Received: by 2002:a05:6214:234d:b0:66c:f0b8:a2c2 with SMTP id hu13-20020a056214234d00b0066cf0b8a2c2mr1389746qvb.65.1697784871680; Thu, 19 Oct 2023 23:54:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1697784871; cv=pass; d=google.com; s=arc-20160816; b=B6dwL8n3jLsTDueHayfq3cpf9mJuUUTVjhWWtBwZ+TWbEUoEuy1oYgTSreTqT26eVY dEDRcmmq8GuRlzVVLQleqckWO8AbQ8Fxv2i5ZP/Mj5KrZSdtWyZwT4FfDNE/3hBGkj1O TFmqWosUWl4E22iKrPoEAyzvKN/PigmMEyTfOw5Kdzitgx+5yBg46BHst7nMXmoWmBi1 F08/o3nmPbScCcdGz1PhrRSIiiq/tC+bUWadjhs3s0EUL242qe5FoOJP3yStkKOTMY1G BD4G+24f2bpmJAAp+mYtQfxahbZyDV2Lmx4ZKYwyhu3INyFGtIiDJTDpTH5Rqw16gyDp BiiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=vedSUPVtiASNFGXk+DrY1LdUctBWrnRVE125kaE1YuA=; fh=M9XNq6pp4cuYh4m9HuQL4m4KupZ49y5jyliIXWeb38Y=; b=nU9RYZUvVjIPMRyxGGkAImvfVTORFlUeem4rNc3hIYH5NdH35STVb4jFeaw9W2FUYi LT2Ev9uQbzrXK+BYX3azyOTxtfzG0HdjGxJA8Gw96HBJak3qtxwhpJi56NlQjYl5rx+c pKLFOvfbWT5GxEho9wNZ7M9KT+ZZLMkSmJo4fScfAXQp6Ws8jG7oAhw+wGf+4xddaDVY JmSKhO+Uf02V/5x2i30GtRpcKLvBQCFpuqFlGHu+GMjOdwpBvlgVzkFIJ15O7UsYyf3b NNQ8a/8d+bh7xEYauvow8EKnzdhMhUonblWpkvzD3KpS5EcwW8MjCJSeVyQTctQYSEwF eGxw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iSBTnI2C; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id l16-20020ad44d10000000b0066d044ec93esi895881qvl.332.2023.10.19.23.54.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 23:54:31 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iSBTnI2C; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 74FD5385701B for ; Fri, 20 Oct 2023 06:54:31 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id 943BD3858D1E for ; Fri, 20 Oct 2023 06:54:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 943BD3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 943BD3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.55.52.43 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697784847; cv=none; b=xPCzBfedafwzcYoALFVzgnnI/7mWFVD6TqLlivcTegPA9P+f8N+y0wuBZzjEfSO4pKPf78llk7r7/gHe2tKHUOOIhQldgNuJpRVUO/3bYvWIP4+NfPUcYduoDTinclEJXLsO+yCxYsu7ioyP73ooiLLYPyEO1iiXQKoUrmJRxSI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697784847; c=relaxed/simple; bh=afVbpofvQI7Fyx9DNh8Qd1mJF6xV4AQ3W6LZdlnCyJc=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=rlMEsygKPVLDSvsrruVxT6vmVh7rBbymvTV37/r25jV/7JA0DGVgJGKm0ovV/lv1DZ3VLGDPUaJXFlqZyvl/0mTvIZrdduaEMSs0V98hgLRzgaEaCyMrDd5xTwvWtHWheykz0efdF85ww78jMw0e++8tYr+D4m9zJHXqdokT6Zs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697784845; x=1729320845; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=afVbpofvQI7Fyx9DNh8Qd1mJF6xV4AQ3W6LZdlnCyJc=; b=iSBTnI2CkLOx99jPQ9IcPpO7GA0XnPqGnhP7CBUqEkph/S2CJ3O/BL+t Aqcm8NmM2uhyNVkRIjNG2fO2kYa6QsMFKW7whJr+jg87lEa/fsuRJrSmi qIC+SdLGH5n9dTYED4M+5iam2dB+AYfAqhVCkLTB3KWkcYCGYuCqu0zz3 riByis1vuZ1lZDUkB9tzMxdtMk9HvFgKNY2dxvN3MzxMM5qDnCMRCYY2b QPqeCUl+nnemyV7CNec/ee/4O75jeNPo8+rt03FZiB28C4D3YPYAbPazO 7Cl6rhmlzHV2MKTzKZkarSy2Kdb+UNVr9LiP8gQFfR4g4GyiDajn3B4bP w==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="472666852" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="472666852" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 23:54:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="757357865" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="757357865" Received: from shvmail03.sh.intel.com ([10.239.245.20]) by orsmga002.jf.intel.com with ESMTP; 19 Oct 2023 23:54:02 -0700 Received: from shliclel4217.sh.intel.com (shliclel4217.sh.intel.com [10.239.240.127]) by shvmail03.sh.intel.com (Postfix) with ESMTP id CB028100568A; Fri, 20 Oct 2023 14:54:01 +0800 (CST) From: liuhongt To: gcc-patches@gcc.gnu.org Cc: ubizjak@gmail.com Subject: [PATCH] [x86] Remove unused mmx_pinsrw. Date: Fri, 20 Oct 2023 14:54:01 +0800 Message-Id: <20231020065401.1086359-1-hongtao.liu@intel.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780256469827438223 X-GMAIL-MSGID: 1780256469827438223 When I'm working on enable more 32/64-bit vectorization for _Float16, I notice there's 1 redundant define_expand, the patch removed the expander. Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. Ok for trunk? gcc/ChangeLog: * config/i386/mmx.md (mmx_pinsrw): Removed. --- gcc/config/i386/mmx.md | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md index 491a0a51272..d1e1f733566 100644 --- a/gcc/config/i386/mmx.md +++ b/gcc/config/i386/mmx.md @@ -4574,20 +4574,6 @@ (define_insn "*mmx_pinsrd" (set_attr "prefix" "orig,vex") (set_attr "mode" "TI")]) -(define_expand "mmx_pinsrw" - [(set (match_operand:V4HI 0 "register_operand") - (vec_merge:V4HI - (vec_duplicate:V4HI - (match_operand:SI 2 "nonimmediate_operand")) - (match_operand:V4HI 1 "register_operand") - (match_operand:SI 3 "const_0_to_3_operand")))] - "(TARGET_MMX || TARGET_MMX_WITH_SSE) - && (TARGET_SSE || TARGET_3DNOW_A)" -{ - operands[2] = gen_lowpart (HImode, operands[2]); - operands[3] = GEN_INT (1 << INTVAL (operands[3])); -}) - (define_insn "*mmx_pinsrw" [(set (match_operand:V4HI 0 "register_operand" "=y,x,YW") (vec_merge:V4HI