From patchwork Tue Oct 17 11:27:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ken Matsui X-Patchwork-Id: 154097 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp4069983vqb; Tue, 17 Oct 2023 04:39:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExjFvnbd60y80l+tUwFbvc17hVCHLW87JaFA6aWDDKyyQZALe1CsJ5V6w3dPaHM5FCSqnE X-Received: by 2002:a67:b048:0:b0:457:c9ae:6c6e with SMTP id q8-20020a67b048000000b00457c9ae6c6emr2191307vsh.12.1697542780234; Tue, 17 Oct 2023 04:39:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1697542780; cv=pass; d=google.com; s=arc-20160816; b=lPmtI7HLhc9V0dUiQe6XmyotaYDB77dPjrZQCL8BT3m8ebTxUVf2JyOcIHI/JISzQD sY4CavMNGqm53eMsl5FETOcole+cm5fSC4WS7SwFvI1/mkwqdjN2qxvSiGXpEEUrcCli F7YDU/PeA8tmg/tFsTgwFnoRwhvw1L4JiLGM2h8I6pvFScMH54u2yH9+1YeuZ6mHRY/o aOJTQQbozelFrQ4hcVMEybclFVUBvnJbKKgdGmG9qzQRNn6R4oWJszxzFUJ0E90pnC1L 0Zp5M7N1NIWWmu3pHw7So5yNdWaD4E4NuAo7NQdUd7V5Dp6IXs5One/ov6Xc3O0KLVQ6 ofXg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=MoFGZrXYWQnuxLLXozlmHXoHbLqNuKGteZmjnUBj1G4=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=VbNXg4zTrmi6of/oqCnZ4n3VkOpasMeZGgxvyToFKBbKo9JAZcICGsiujJ4OYokqeh P9plJcxn8L4/1n2KWGE4DrHTtMRVAckUgh3sk3Mbz4HT+A5CCluorhqrgi4CF4yiXnyU aEEKuThedmidTD1sgGNUrr2/+NzYdIhQfEY4L72/RhkI/28MuQRQhVV9c3QE/n6IF9LM xy4nKYyiwEHiPl6gtPVYbffcSjoYhxLKYaZq9taQkGWkoWuchBoVna28tFRK51v06WBt dZ9yLiBmOlatdHswXq6XGLP4yytT6Od7vOXmei0qT5i9/+rLixEnSSpEumCjxBp/ElO8 bEmQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=sZnrwSZ+; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id t5-20020a05622a148500b004199dd362ffsi959832qtx.402.2023.10.17.04.39.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 04:39:40 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=sZnrwSZ+; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 84DF23861858 for ; Tue, 17 Oct 2023 11:39:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 84DF23861858 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1697542742; bh=MoFGZrXYWQnuxLLXozlmHXoHbLqNuKGteZmjnUBj1G4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sZnrwSZ+Z+shyeh/pXF+9lsKG47L/9QsiSwbLI7RuCWTZgTSw8IZhwZMvh+FxWEPf QbG22fd61e3G2C8N9w3RUvMxCyCZ63evQrBdbuL2njQ5fn6rPLYnRe1qQGQwYdv+se uDrLNLE7D8uSsCmbRAtLr2Cy3Zwzcjtsf+20MCIk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-00641c01.pphosted.com (mx0a-00641c01.pphosted.com [205.220.165.146]) by sourceware.org (Postfix) with ESMTPS id 1C296385B53E; Tue, 17 Oct 2023 11:36:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C296385B53E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1C296385B53E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.165.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697542566; cv=none; b=EYCNKpoOm5pWmUkSfVj9VjSmYoZZfLOIeW4gwqXk2dHzGZs1qSGBalyqozBciEnGy06BC8bpz74GvGnBReBty/heLz/F+B/TpZyes+/8HbJaiaKpfpvmMWhj8u+t0t4J37Innp3YomoKFsFo9xX6BVdIJI9yUjaJKbj2wImxoog= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697542566; c=relaxed/simple; bh=Gm1sCosWhoGfMkhnlmEt/iwf6ndEw3EeBrJJMskswyo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=NWPMRFAgRCsBZn7s8UB01Ha22UV00hqX/a1uT3aJaRk7i1DtYuj6GbxnLEWWc8Hh6VKhH2c6ykYO0nZuW6weCLwLEAMF3J6MXLzH5LMgETCuX2RSphsbfkR4k9xjsWn4Kuq8/UqrjxJ3/voW1t2N4NjWJQnZjC4XNeB3rAmjqrc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247470.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39HBOQc4002951; Tue, 17 Oct 2023 11:36:02 GMT Received: from mxout23.cac.washington.edu (mxout23.cac.washington.edu [140.142.32.140]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3tsa9e5pms-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Oct 2023 11:36:02 +0000 Received: from smtp.washington.edu (smtp.washington.edu [140.142.234.157]) by mxout23.cac.washington.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 39HBZltm004608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Oct 2023 04:35:47 -0700 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.19.18.191]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 39HBWiMb001840 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Oct 2023 04:35:47 -0700 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui Subject: [PATCH v21 24/30] libstdc++: Optimize std::is_function compilation performance Date: Tue, 17 Oct 2023 04:27:55 -0700 Message-ID: <20231017113242.664523-25-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231017113242.664523-1-kmatsui@gcc.gnu.org> References: <20231016001227.2717180-1-kmatsui@gcc.gnu.org> <20231017113242.664523-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: yTSdIWVY_FP1yN7SK1fsh0Gg_vSMMHEE X-Proofpoint-GUID: yTSdIWVY_FP1yN7SK1fsh0Gg_vSMMHEE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-16_13,2023-10-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=386 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 clxscore=1034 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310170097 X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780002618169089074 X-GMAIL-MSGID: 1780002618169089074 This patch optimizes the compilation performance of std::is_function by dispatching to the new __is_function built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (is_function): Use __is_function built-in trait. (is_function_v): Likewise. Optimize its implementation. Signed-off-by: Ken Matsui --- libstdc++-v3/include/std/type_traits | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 36ad9814047..bd57488824b 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -637,6 +637,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION { }; /// is_function +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_function) + template + struct is_function + : public __bool_constant<__is_function(_Tp)> + { }; +#else template struct is_function : public __bool_constant::value> { }; @@ -648,6 +654,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template struct is_function<_Tp&&> : public false_type { }; +#endif #ifdef __cpp_lib_is_null_pointer // C++ >= 11 /// is_null_pointer (LWG 2247). @@ -3269,8 +3276,18 @@ template inline constexpr bool is_union_v = __is_union(_Tp); template inline constexpr bool is_class_v = __is_class(_Tp); + +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_function) template - inline constexpr bool is_function_v = is_function<_Tp>::value; + inline constexpr bool is_function_v = __is_function(_Tp); +#else +template + inline constexpr bool is_function_v = !is_const_v; +template + inline constexpr bool is_function_v<_Tp&> = false; +template + inline constexpr bool is_function_v<_Tp&&> = false; +#endif #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_reference) template